New issue
Advanced search Search tips
Starred by 4 users
Status: Fixed
Owner:
Closed: Sep 25
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Android , Windows , Chrome , Mac
Pri: 2
Type: Bug



Sign in to add a comment
visualViewport event handlers do not work
Project Member Reported by jakearchibald@chromium.org, Aug 31 Back to list
http://output.jsbin.com/hayimin/quiet

The above includes:

visualViewport.onscroll = () => console.log('scroll');
visualViewport.onresize = () => console.log('resize');

I could expect to see "scroll" and "resize" logged as I scroll & resize the viewport, but I don't.

Alternatively http://output.jsbin.com/hobopu/quiet includes:

visualViewport.addEventListener('scroll', () => console.log('scroll'));
visualViewport.addEventListener('resize', () => console.log('resize'));

…and it works as expected.
 
Components: -Blink>DOM Blink
It looks we don't have a Bug Components for visualViewport.
Cc: -bokan@chromium.org
Components: -Blink Blink>Scroll
Owner: bokan@chromium.org
Status: Assigned
Uncaught ReferenceError: visualViewport is not defined
Sorry, this needs to be tested in M61 or newer.
Labels: -Pri-3 Hotlist-Input-Dev M-62 OS-Android OS-Chrome OS-Linux OS-Mac OS-Windows Pri-2
Yikes! I'll try to get a fix merged back to M62.
Project Member Comment 5 by bugdroid1@chromium.org, Sep 14
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c3d1b5db2b08e3762fb9aab3d82ad5d6ff799103

commit c3d1b5db2b08e3762fb9aab3d82ad5d6ff799103
Author: David Bokan <bokan@chromium.org>
Date: Thu Sep 14 03:11:12 2017

Add attribute event listeners to visualViewport

These were previously available but removed in r407955. In the mean time
they made their way into the visualViewport draft spec:

https://wicg.github.io/ViewportAPI/spec.html#dom-visualviewport-onresize

But we forgot to actually re-add them. This patch adds them back in.

Bug:  760916 
Change-Id: Ib2dc3dbd21d648d9118bbb88e61bba7b65369688
Reviewed-on: https://chromium-review.googlesource.com/658318
Reviewed-by: Dave Tapuska <dtapuska@chromium.org>
Reviewed-by: Kent Tamura <tkent@chromium.org>
Commit-Queue: David Bokan <bokan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#501855}
[modify] https://crrev.com/c3d1b5db2b08e3762fb9aab3d82ad5d6ff799103/third_party/WebKit/LayoutTests/NeverFixTests
[add] https://crrev.com/c3d1b5db2b08e3762fb9aab3d82ad5d6ff799103/third_party/WebKit/LayoutTests/external/wpt/viewport/viewport-attribute-event-handlers-manual.html
[modify] https://crrev.com/c3d1b5db2b08e3762fb9aab3d82ad5d6ff799103/third_party/WebKit/LayoutTests/fast/dom/Window/property-access-on-cached-properties-after-frame-navigated-expected.txt
[modify] https://crrev.com/c3d1b5db2b08e3762fb9aab3d82ad5d6ff799103/third_party/WebKit/LayoutTests/fast/dom/Window/property-access-on-cached-properties-after-frame-removed-and-gced-expected.txt
[modify] https://crrev.com/c3d1b5db2b08e3762fb9aab3d82ad5d6ff799103/third_party/WebKit/LayoutTests/fast/dom/Window/property-access-on-cached-properties-after-frame-removed-expected.txt
[modify] https://crrev.com/c3d1b5db2b08e3762fb9aab3d82ad5d6ff799103/third_party/WebKit/LayoutTests/fast/dom/Window/property-access-on-cached-window-after-frame-navigated-expected.txt
[modify] https://crrev.com/c3d1b5db2b08e3762fb9aab3d82ad5d6ff799103/third_party/WebKit/LayoutTests/fast/dom/Window/property-access-on-cached-window-after-frame-removed-and-gced-expected.txt
[modify] https://crrev.com/c3d1b5db2b08e3762fb9aab3d82ad5d6ff799103/third_party/WebKit/LayoutTests/fast/dom/Window/property-access-on-cached-window-after-frame-removed-expected.txt
[modify] https://crrev.com/c3d1b5db2b08e3762fb9aab3d82ad5d6ff799103/third_party/WebKit/LayoutTests/platform/mac/virtual/stable/webexposed/global-interface-listing-expected.txt
[modify] https://crrev.com/c3d1b5db2b08e3762fb9aab3d82ad5d6ff799103/third_party/WebKit/LayoutTests/platform/win/virtual/stable/webexposed/global-interface-listing-expected.txt
[modify] https://crrev.com/c3d1b5db2b08e3762fb9aab3d82ad5d6ff799103/third_party/WebKit/LayoutTests/webexposed/global-interface-listing-expected.txt
[modify] https://crrev.com/c3d1b5db2b08e3762fb9aab3d82ad5d6ff799103/third_party/WebKit/Source/core/frame/DOMVisualViewport.h
[modify] https://crrev.com/c3d1b5db2b08e3762fb9aab3d82ad5d6ff799103/third_party/WebKit/Source/core/frame/VisualViewport.idl

Labels: Merge-Request-62
Confirmed fix in Dev channel. Requesting merge back to M62.

This should be a low risk merge as it's addressing an issue in a newly shipped API.
Project Member Comment 7 by sheriffbot@chromium.org, Sep 25
Labels: -Merge-Request-62 Merge-Review-62 Hotlist-Merge-Review
This bug requires manual review: M62 has already been promoted to the beta branch, so this requires manual review
Please contact the milestone owner if you have questions.
Owners: amineer@(Android), cmasso@(iOS), bhthompson@(ChromeOS), abdulsyed@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Labels: -Merge-Review-62 Merge-Approved-62
Per comment 6, safe merge overall and fixed in Dev Channel. Approving merge to M62. Branch:3202
Project Member Comment 9 by bugdroid1@chromium.org, Sep 25
Labels: -merge-approved-62 merge-merged-3202
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8c3e8988855b0cf695f535439451784745d27f76

commit 8c3e8988855b0cf695f535439451784745d27f76
Author: David Bokan <bokan@chromium.org>
Date: Mon Sep 25 20:29:28 2017

Add attribute event listeners to visualViewport

These were previously available but removed in r407955. In the mean time
they made their way into the visualViewport draft spec:

https://wicg.github.io/ViewportAPI/spec.html#dom-visualviewport-onresize

But we forgot to actually re-add them. This patch adds them back in.

TBR=bokan@chromium.org

(cherry picked from commit c3d1b5db2b08e3762fb9aab3d82ad5d6ff799103)

Bug:  760916 
Change-Id: Ib2dc3dbd21d648d9118bbb88e61bba7b65369688
Reviewed-on: https://chromium-review.googlesource.com/658318
Reviewed-by: Dave Tapuska <dtapuska@chromium.org>
Reviewed-by: Kent Tamura <tkent@chromium.org>
Commit-Queue: David Bokan <bokan@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#501855}
Reviewed-on: https://chromium-review.googlesource.com/682875
Reviewed-by: David Bokan <bokan@chromium.org>
Cr-Commit-Position: refs/branch-heads/3202@{#435}
Cr-Branched-From: fa6a5d87adff761bc16afc5498c3f5944c1daa68-refs/heads/master@{#499098}
[modify] https://crrev.com/8c3e8988855b0cf695f535439451784745d27f76/third_party/WebKit/LayoutTests/NeverFixTests
[add] https://crrev.com/8c3e8988855b0cf695f535439451784745d27f76/third_party/WebKit/LayoutTests/external/wpt/viewport/viewport-attribute-event-handlers-manual.html
[modify] https://crrev.com/8c3e8988855b0cf695f535439451784745d27f76/third_party/WebKit/LayoutTests/fast/dom/Window/property-access-on-cached-properties-after-frame-navigated-expected.txt
[modify] https://crrev.com/8c3e8988855b0cf695f535439451784745d27f76/third_party/WebKit/LayoutTests/fast/dom/Window/property-access-on-cached-properties-after-frame-removed-and-gced-expected.txt
[modify] https://crrev.com/8c3e8988855b0cf695f535439451784745d27f76/third_party/WebKit/LayoutTests/fast/dom/Window/property-access-on-cached-properties-after-frame-removed-expected.txt
[modify] https://crrev.com/8c3e8988855b0cf695f535439451784745d27f76/third_party/WebKit/LayoutTests/fast/dom/Window/property-access-on-cached-window-after-frame-navigated-expected.txt
[modify] https://crrev.com/8c3e8988855b0cf695f535439451784745d27f76/third_party/WebKit/LayoutTests/fast/dom/Window/property-access-on-cached-window-after-frame-removed-and-gced-expected.txt
[modify] https://crrev.com/8c3e8988855b0cf695f535439451784745d27f76/third_party/WebKit/LayoutTests/fast/dom/Window/property-access-on-cached-window-after-frame-removed-expected.txt
[modify] https://crrev.com/8c3e8988855b0cf695f535439451784745d27f76/third_party/WebKit/LayoutTests/platform/mac/virtual/stable/webexposed/global-interface-listing-expected.txt
[modify] https://crrev.com/8c3e8988855b0cf695f535439451784745d27f76/third_party/WebKit/LayoutTests/platform/win/virtual/stable/webexposed/global-interface-listing-expected.txt
[modify] https://crrev.com/8c3e8988855b0cf695f535439451784745d27f76/third_party/WebKit/LayoutTests/webexposed/global-interface-listing-expected.txt
[modify] https://crrev.com/8c3e8988855b0cf695f535439451784745d27f76/third_party/WebKit/Source/core/frame/DOMVisualViewport.h
[modify] https://crrev.com/8c3e8988855b0cf695f535439451784745d27f76/third_party/WebKit/Source/core/frame/VisualViewport.idl

Status: Fixed
Sign in to add a comment