New issue
Advanced search Search tips

Issue 760895 link

Starred by 2 users

Issue metadata

Status: WontFix
Owner:
Closed: Sep 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug-Regression



Sign in to add a comment

8.9%-16.6% regression in v8.runtimestats.browsing_desktop at 498055:498146

Project Member Reported by hablich@chromium.org, Aug 31 2017

Issue description

See the link to graphs below.
 
Project Member

Comment 1 by 42576172...@developer.gserviceaccount.com, Aug 31 2017

All graphs for this bug:
  https://chromeperf.appspot.com/group_report?bug_id=760895

(For debugging:) Original alerts at time of bug-filing:
  https://chromeperf.appspot.com/group_report?sid=fe4c46da402089da14659e76778eea8e2db99a7dc0f62051a47a71c47a6c44db


Bot(s) for this bug's original alert(s):

chromium-rel-win7-dual
chromium-rel-win7-gpu-ati
chromium-rel-win7-gpu-intel
chromium-rel-win7-gpu-nvidia
chromium-rel-win7-x64-dual
chromium-rel-win8-dual
Cc: cbruni@chromium.org

Comment 4 by cbruni@chromium.org, Aug 31 2017

I presume this is going to point to the following commit: 

ed7155c [runtime-call-stats] Fix a long standing crash in RuntimeCallStats::Leave by Alexei Filippov ยท 2 days ago


Which means that we didn't properly account before and this issue can be closed.

Waiting for the bisect results for the next steps.
Project Member

Comment 5 by 42576172...@developer.gserviceaccount.com, Aug 31 2017

Cc: alph@chromium.org
Owner: alph@chromium.org
Status: Assigned (was: Untriaged)

=== Auto-CCing suspected CL author alph@chromium.org ===

Hi alph@chromium.org, the bisect results pointed to your CL, please take a look at the
results.


=== BISECT JOB RESULTS ===
Perf regression found with culprit

Suspected Commit
  Author : Alexei Filippov
  Commit : ed7155c678a647e0a97f915b150c5c65a417de4d
  Date   : Tue Aug 29 07:50:24 2017
  Subject: [runtime-call-stats] Fix a long standing crash in RuntimeCallStats::Leave

Bisect Details
  Configuration: win_8_perf_bisect
  Benchmark    : v8.runtimestats.browsing_desktop
  Metric       : V8 C++:duration_avg/browse_social/browse_social_tumblr_infinite_scroll
  Change       : 9.88% | 159.311666667 -> 175.049

Revision                           Result                  N
chromium@498054                    159.312 +- 251.702      21      good
chromium@498075                    138.543 +- 52.8754      9       good
chromium@498080                    149.575 +- 157.718      9       good
chromium@498083                    143.953 +- 102.9        9       good
chromium@498083,v8@edc03cead9      130.598 +- 4.04316      6       good
chromium@498083,v8@402f5151cd      129.225 +- 4.54629      6       good
chromium@498083,v8@ed7155c678      149.237 +- 14.2565      6       bad       <--
chromium@498083,v8@6b6691f18a      146.231 +- 10.6388      6       bad
chromium@498084                    160.02 +- 127.893       9       bad
chromium@498085                    163.739 +- 146.08       9       bad
chromium@498095                    175.049 +- 220.423      14      bad

To Run This Test
  src/tools/perf/run_benchmark -v --browser=release --output-format=chartjson --upload-results --pageset-repeat=1 --also-run-disabled-tests --story-filter=browse.social.tumblr.infinite.scroll v8.runtimestats.browsing_desktop

More information on addressing performance regressions:
  http://g.co/ChromePerformanceRegressions

Debug information about this bisect:
  https://chromeperf.appspot.com/buildbucket_job_status/8969754807175089200


For feedback, file a bug with component Speed>Bisection
Status: WontFix (was: Assigned)
as expected... marking as WontFix since we just changed the measurements.

Sign in to add a comment