Regression : Unwanted scrollbar is observed on PDF page, when clicking outside error dialog box.
Reported by
avsha...@etouch.net,
Aug 31 2017
|
||||||||
Issue descriptionChrome version : 62.0.3201.0 (Official Build) 5d0afdac43361da3ee5cb6f11f756c07423756ba-refs/heads/master@{#498715} 32/64 bit OS : Windows(7,8,10), Linux(14.04 LTS), Mac(10.11.6, 10.12.3, 10.12.5) Test URL : http://www.orimi.com/pdf-test.pdf What steps will reproduce the problem? 1. Launch chrome, navigate to above test URL, right click on PDF and select 'Inspect' option (separate devtools window opens). 2. Hit F5 key to reload devtools window and close the devtools window. (Error message dialog appears on PDF) 3. Now click on the black screen outside error dialog box. 4. Observe the vertical scrollbar at the RHS of page. Actual Result : Unwanted scrollbar is observed on PDF page, when clicking outside error dialog box. Expected Result : Scrollbar should not be seen on PDF page while clicking outside the error dialog box. This is a regression issue broken in ‘M-61’, below is the manual regression range and will soon update bisect info. Good build : 61.0.3155.0 Bad build : 61.0.3156.0 Note : This issue can be reproduced with any PDF page.
,
Aug 31 2017
Using the per-revision bisect providing the bisect results, Good build:61.0.3155.0(Revision:485784). Bad build:61.0.3156.0(Revision:486205). You are probably looking for a change made after 486134 (known good), but no later than 486135 (first known bad). CHANGE-LOG URL: --------------- https://chromium.googlesource.com/chromium/src/+/1da9af16908d1288e8c9d08b6bd27e964b4ae15c From the CL above, assigning the issue to the concern owner @dpapad : Could you please look into the issue, pardon me if it has nothing to do with your changes and if possible please assign it to concern owner. Review-URL:https://chromium-review.googlesource.com/566093 Note :Able to reproduce the issue in Win 10.0,Ubuntu 14.04 & Mac 10.12.5 and Able to reproduce in latest Canary #62.0.3201.0 Adding Release Block-Stable for this issue.Please remove if not the case.
,
Aug 31 2017
,
Aug 31 2017
URGENT - PTAL. M61 Stable promotion is coming soon and your bug is labelled as Stable ReleaseBlock, pls make sure to land the fix and get it merged into the release branch ASAP. Note: We're planning to cut M61 Stable RC tomorrow.
,
Aug 31 2017
I'm taking a look since dpapad@ is not available. I personally don't think this is a stable release blocker though, since it only happens for a very corner case, and the impact is just the page looking slightly awkward for less than half a second. Please let me know if you think this absolutely needs to be considered a blocker.
,
Aug 31 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/5677b32274aec4890c7dd991a6a84924e65d4853 commit 5677b32274aec4890c7dd991a6a84924e65d4853 Author: Scott Chen <scottchen@chromium.org> Date: Thu Aug 31 23:16:59 2017 WebUI: fix cr-dialog pulsing animation leaking out of viewport There were margin on all 4 sides of the dialog, and animating scale() was also enlarging those margin and creating unnecessary scroll bars. This CL centers the dialog with translate instead of margin, so that animating scale() for a reasonably sized dialog would not cause parts to be pushed beyond viewport. TBR=dpapad Bug: 760888 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I16f50a6a54421b2a25023ba5ebe979a2d2aa25c7 Reviewed-on: https://chromium-review.googlesource.com/646631 Reviewed-by: Dave Schuyler <dschuyler@chromium.org> Reviewed-by: Scott Chen <scottchen@chromium.org> Commit-Queue: Scott Chen <scottchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#499066} [modify] https://crrev.com/5677b32274aec4890c7dd991a6a84924e65d4853/ui/webui/resources/cr_elements/cr_dialog/cr_dialog.html [modify] https://crrev.com/5677b32274aec4890c7dd991a6a84924e65d4853/ui/webui/resources/cr_elements/cr_dialog/cr_dialog.js
,
Sep 1 2017
Update : Retested above issue in latest chrome canary #62.0.3202.0 on Windows(7,8,10), Linux(14.04 LTS) & Mac(10.11.6, 10.12.3, 10.12.5) OS and issue is not reproducible. Issue is fixed now and it is working as intended. Kindly review an attached screen cast. Thank you!
,
Sep 5 2017
,
Sep 6 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/5282c59aa39d5ced02eea99766ab471da7351d1e commit 5282c59aa39d5ced02eea99766ab471da7351d1e Author: Scott Chen <scottchen@chromium.org> Date: Wed Sep 06 23:48:05 2017 WebUI: fix cr-dialog bugs related to positioning/pulsing A previous attempt to fix dialog pulsing bug introduced other unexpected issues, so this CL reverts it and approaches the bug in a different way (without using css-transform). Bug: 760888 , 761982 , 761252 , 761244 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: Ib1b11e1d497e2796c7c0804341e3548588bd16c5 Reviewed-on: https://chromium-review.googlesource.com/651576 Reviewed-by: Dave Schuyler <dschuyler@chromium.org> Commit-Queue: Scott Chen <scottchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#500131} [modify] https://crrev.com/5282c59aa39d5ced02eea99766ab471da7351d1e/ui/webui/resources/cr_elements/cr_dialog/cr_dialog.html [modify] https://crrev.com/5282c59aa39d5ced02eea99766ab471da7351d1e/ui/webui/resources/cr_elements/cr_dialog/cr_dialog.js
,
Sep 7 2017
Retested issue in latest canary #63.0.3208.0 on Windows(7,8,10), Linux(14.04 LTS) & Mac(10.11.6, 10.12.3, 10.12.5) OS and issue is fixed. Now, no scroll bar is observed on PDF page when clicking outside an error dialog box and it is working as intended. Attaching a screen-cast for the reference. Thank you!!
,
Sep 13 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/249854ac8778ef30cd5ba302d17ddba0ba611f9f commit 249854ac8778ef30cd5ba302d17ddba0ba611f9f Author: Scott Chen <scottchen@chromium.org> Date: Wed Sep 13 20:57:48 2017 WebUI: fix cr-dialog bugs related to positioning/pulsing A previous attempt to fix dialog pulsing bug introduced other unexpected issues, so this CL reverts it and approaches the bug in a different way (without using css-transform). Bug: 760888 , 761982 , 761252 , 761244 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: Ib1b11e1d497e2796c7c0804341e3548588bd16c5 Reviewed-on: https://chromium-review.googlesource.com/651576 Reviewed-by: Dave Schuyler <dschuyler@chromium.org> Commit-Queue: Scott Chen <scottchen@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#500131}(cherry picked from commit 5282c59aa39d5ced02eea99766ab471da7351d1e) Reviewed-on: https://chromium-review.googlesource.com/665100 Reviewed-by: Scott Chen <scottchen@chromium.org> Cr-Commit-Position: refs/branch-heads/3202@{#210} Cr-Branched-From: fa6a5d87adff761bc16afc5498c3f5944c1daa68-refs/heads/master@{#499098} [modify] https://crrev.com/249854ac8778ef30cd5ba302d17ddba0ba611f9f/ui/webui/resources/cr_elements/cr_dialog/cr_dialog.html [modify] https://crrev.com/249854ac8778ef30cd5ba302d17ddba0ba611f9f/ui/webui/resources/cr_elements/cr_dialog/cr_dialog.js |
||||||||
►
Sign in to add a comment |
||||||||
Comment 1 by nyerramilli@chromium.org
, Aug 31 2017Status: Untriaged (was: Unconfirmed)