Issue metadata
Sign in to add a comment
|
Handle SSL errors when WebState is not in a tab. |
||||||||||||||||||||||
Issue descriptionSome WebState are not displayed in a tab (if the web state is used to fetch web pages, like Reading List pages). The current SSL error process is to show an interstitial that requires user action. For these WebStates, this will never happen. This case should be handled differently.
,
Sep 5 2017
Oliver could you please provide steps to reproduce, actual behavior and expected behavior. It is not WebState's job to show an interstitial, this job is delegated to //chrome layer, because SSL interstitial is UI concept. But in order to understand how Reading List should handle this flow correctly, I need more information.
,
Sep 6 2017
As you reviewed https://chromium-review.googlesource.com/c/chromium/src/+/643295, you may already have a better understanding of the issue. Problem is that iOS ChromeWebClient forwards SSL errors of all WebStates to IOSSSLErrorHandler, and IOSSSLErrorHandler shows an interstitial. On WebStates that have no UI, this interstitial is never displayed to the user, and AFAICT, the webState is frozen. I think either IOSSSLErrorHandler should not display interstitial if the WebState is in background, or ChromeWebClient should do the test (more desktop like).
,
Sep 6 2017
,
Sep 7 2017
Thanks Olivier! Seems like we need WebState::IsVisible() API to support this scenario.
,
Sep 26 2017
,
Nov 10 2017
,
Feb 18 2018
|
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by huangml@chromium.org
, Aug 31 2017Status: Assigned (was: Untriaged)