Regression: image decode bench segfaults at startup |
||
Issue descriptionFYI: image decode bench segfaults at startup Steps to reproduce the problem: 1. ninja -C out/Release image-decode-bench 2. run out/Release/image-decode-bench What went wrong? 3. seg fault. Did this work before? Yes M62, this is a regression.
,
Aug 31 2017
Change mentioned in #1 added these lines to blink::Platform::Initialize https://cs.chromium.org/chromium/src/third_party/WebKit/Source/platform/exported/Platform.cpp?q=blink::platform+initialize&sq=package:chromium&dr=CSs&l=161 + if (BlinkResourceCoordinatorBase::IsEnabled()) + RendererResourceCoordinator::Initialize(); workaround: comment out those lines => no segfault in image decode bench.
,
Sep 7 2017
,
Sep 7 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/2a47f2a7fd08ee7fa20baa6900ab6516febc6be4 commit 2a47f2a7fd08ee7fa20baa6900ab6516febc6be4 Author: Sam McNally <sammc@chromium.org> Date: Thu Sep 07 09:07:21 2017 ImageDecodeBench: Initialize mojo and create a MessageLoop. blink::Platform now requires mojo to be initialized so add mojo::edk::Init() and base::MessageLoop in main(). Bug: 760864 Change-Id: Iaa61bb3b06765047cc34b607d827a0f45210e779 Reviewed-on: https://chromium-review.googlesource.com/654467 Reviewed-by: Noel Gordon <noel@chromium.org> Commit-Queue: Sam McNally <sammc@chromium.org> Cr-Commit-Position: refs/heads/master@{#500250} [modify] https://crrev.com/2a47f2a7fd08ee7fa20baa6900ab6516febc6be4/third_party/WebKit/Source/platform/BUILD.gn [modify] https://crrev.com/2a47f2a7fd08ee7fa20baa6900ab6516febc6be4/third_party/WebKit/Source/platform/testing/ImageDecodeBench.cpp
,
Sep 7 2017
Right, back in business. Let's not break the image_decode_bench folks. |
||
►
Sign in to add a comment |
||
Comment 1 by noel@chromium.org
, Aug 31 2017