New issue
Advanced search Search tips

Issue 760860 link

Starred by 4 users

Issue metadata

Status: Fixed
Owner:
Closed: Aug 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug



Sign in to add a comment

Regression: cros-disks fails to mount /dev/sr0

Project Member Reported by benchan@chromium.org, Aug 31 2017

Issue description

cros-disks now runs as a unprivileged 'cros-disks' user ( issue 726036 ) and doesn't have the permissions to access /dev/sr0 (for CD / DVD drive), which is owned by root:cdrom.  cros-disks needs to be in the 'cdcom' group to access /dev/sr0.
 
Status: Started (was: Assigned)
Oh wow how did you find this? Do you still have a device with a CDROM? Or did this come from the QA team?
b:65148883 came to my attention. And luckily I managed to find a USB DVD drive :)
Project Member

Comment 4 by bugdroid1@chromium.org, Aug 31 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/eclass-overlay/+/b973ac6566d307dd8bc758f12d70368bf7ca7fd3

commit b973ac6566d307dd8bc758f12d70368bf7ca7fd3
Author: Ben Chan <benchan@chromium.org>
Date: Thu Aug 31 21:19:55 2017

Add 'cros-disks' user to 'cdrom' and 'cdrw' group.

cros-disks now runs as the 'cros-disks' user and needs to be in the
'cdrom' and 'cdrw' group for accessing and mounting CD-ROM, CD-RW and
DVD media.

BUG= chromium:760860 
CQ-DEPEND=CL:644235
TEST=Verify that Files.app can mount CD/DVD media via cros-disks.
TEST=Run updated security_AccountsBaseline (CL:644235).

Change-Id: I0453fa2b86dd7682fe0891a220703c0cc1594a08
Reviewed-on: https://chromium-review.googlesource.com/644776
Commit-Ready: Ben Chan <benchan@chromium.org>
Tested-by: Ben Chan <benchan@chromium.org>
Reviewed-by: Jorge Lucangeli Obes <jorgelo@chromium.org>

[modify] https://crrev.com/b973ac6566d307dd8bc758f12d70368bf7ca7fd3/profiles/base/accounts/group/cdrw
[modify] https://crrev.com/b973ac6566d307dd8bc758f12d70368bf7ca7fd3/profiles/base/accounts/group/cdrom

Project Member

Comment 5 by bugdroid1@chromium.org, Aug 31 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/autotest/+/00b7e3d35932c328800b6416b16cce704382f1ed

commit 00b7e3d35932c328800b6416b16cce704382f1ed
Author: Ben Chan <benchan@chromium.org>
Date: Thu Aug 31 21:19:56 2017

security_AccountsBaseline: add 'cros-disks' user to 'cdrom' and 'cdrw' group

CL:644776 adds the 'cros-disks' user to the 'cdrom' and 'cdrw' group.
This CL updates security_AccountsBaseline accordingly.

BUG= chromium:760860 
CQ-DEPEND=CL:644776
TEST=Run security_AccountsBaseline with CL:644776.

Change-Id: I54cab2598ee248c5b30b59ebc16ad860233d7953
Reviewed-on: https://chromium-review.googlesource.com/644235
Commit-Ready: Ben Chan <benchan@chromium.org>
Tested-by: Ben Chan <benchan@chromium.org>
Reviewed-by: Jorge Lucangeli Obes <jorgelo@chromium.org>

[modify] https://crrev.com/00b7e3d35932c328800b6416b16cce704382f1ed/client/site_tests/security_AccountsBaseline/baseline.group

Status: Fixed (was: Started)

Comment 7 by dchan@chromium.org, Jan 22 2018

Status: Archived (was: Fixed)

Comment 8 by dchan@chromium.org, Jan 23 2018

Status: Fixed (was: Archived)

Sign in to add a comment