Layout Tests shouldn't need --debug argument when running on swarming |
|||
Issue descriptionFrom Dirk's comments on https://chromium-review.googlesource.com/c/chromium/src/+/627551 ----------------------- Well, --debug also tells run-webkit-tests that this is a debug build and that the [ Debug ] expectations apply, but that doesn't really matter. What I was getting at is that we can and should be able to figure this out from the actual build, and you shouldn't have to specify the path to the build directory. That information is in the args.build_config_fs info that is passed to the //testing/scripts/run_isolated_script_test.py wrapper. However, looking at this in more detail now I can see that the interaction of arguments between the wrapper, the gn_isolate_map.pyl entry, and the stuff in the JSON file is awkward would make that kinda difficult. So, this is probably the best fix for now but something we should clean up down the road. -----------------------
,
Sep 3
This issue has been Available for over a year. If it's no longer important or seems unlikely to be fixed, please consider closing it out. If it is important, please re-triage the issue. Sorry for the inconvenience if the bug really should have been left as Available. For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Sep 4
Not sure what the "One True Test Step effort" is. Something that might show up on ICC's roadmap in the future? Moving into our back-log until it has.
,
Sep 4
That's the effort theoretically described by bit.ly/chromium-test-step-api. More recently seen in the idea that everything should use the IsolatedScriptTest interface and bin/run_* wrapper scripts. |
|||
►
Sign in to add a comment |
|||
Comment 1 by dpranke@chromium.org
, Sep 1 2017Components: Infra>Client>Chrome
Status: Available (was: Unconfirmed)