NetworkService: Committed Interstitials broke some tests |
||||||
Issue descriptionCommitted Interstitials project (https://crbug.com/448486) probably broke some tests. Example build: https://build.chromium.org/p/chromium.fyi/builders/Mojo%20Linux/builds/4781 After r498645 https://chromium-review.googlesource.com/609542 we're failing: LayoutTests: * external/wpt/cssom-view/scrolling-quirks-vs-nonquirks.html * external/wpt/cssom-view/scrollingElement.html * external/wpt/html/semantics/embedded-content/the-iframe-element/iframe-load-event.html * external/wpt/html/syntax/parsing/html5lib_tests1.html?run_type=uri * http/tests/security/contentSecurityPolicy/cascade/same-origin-window-open.html * http/tests/security/contentSecurityPolicy/cascade/same-origin-with-own-policy-window-open.html * http/tests/security/contentSecurityPolicy/cascade/same-origin-with-own-policy.html * http/tests/security/contentSecurityPolicy/cascade/same-origin.html content_browsertests: NavigationControllerBrowserTest.ForwardInSubframeWithPendingForward BrowserSideNavigationBrowserTest.SanitizeReferrer SitePerProcessBrowserTest.RFHTransfersWhilePendingDeletion NavigationControllerBrowserTest.SameDocumentNavigationDoesntDeleteNavigationHandle NavigationHandleImplBrowserTest.ThrottleDefer Error is: [13833:13833:0830/155210.757237:30319050223:FATAL:render_frame_host_impl.cc(3374)] Check failed: net::OK != navigation_handle_->GetNetErrorCode() (0 vs. 0) #0 0x000001b3cc17 base::debug::StackTrace::StackTrace() #1 0x000001b53a61 logging::LogMessage::~LogMessage() #2 0x0000015fca28 content::RenderFrameHostImpl::FailedNavigation() #3 0x0000015deb0c content::NavigationRequest::OnRequestFailed() #4 0x0000016c3473 content::NavigationURLLoaderNetworkService::OnComplete() #5 0x00000051ee94 _ZN4base8internal7InvokerINS0_9BindStateINS0_18IgnoreResultHelperIMN3IPC8ListenerEFbRKNS4_7MessageEEEEJNS_7WeakPtrIS5_EES6_EEEFvvEE3RunEPNS0_13BindStateBaseE #6 0x000001b3d379 base::debug::TaskAnnotator::RunTask() Will add suppressions for now and see if I can debug. As this is a recent, clear regression I decided to file a new bug and set it to block issue 729848 and issue 729849 but we can merge if needed.
,
Aug 31 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/87a4fb316370bdfe457a83e9842e6e2f030baad5 commit 87a4fb316370bdfe457a83e9842e6e2f030baad5 Author: Matt Falkenhagen <falken@chromium.org> Date: Thu Aug 31 02:17:06 2017 NetworkService: Suppress failing tests after Committed Interstitials patch These tests started failing after r498645. NOTRY=true Bug: 760831 Change-Id: Id3e74fdf6af050bc74f06965644f94d273ea6134 TBR: kinuko Reviewed-on: https://chromium-review.googlesource.com/644648 Reviewed-by: Matt Falkenhagen <falken@chromium.org> Commit-Queue: Matt Falkenhagen <falken@chromium.org> Cr-Commit-Position: refs/heads/master@{#498728} [modify] https://crrev.com/87a4fb316370bdfe457a83e9842e6e2f030baad5/testing/buildbot/filters/mojo.fyi.network_content_browsertests.filter [modify] https://crrev.com/87a4fb316370bdfe457a83e9842e6e2f030baad5/third_party/WebKit/LayoutTests/FlagExpectations/enable-features=NetworkService
,
Aug 31 2017
Ah this might be expected, the CL added some TODOs around the crash stack like: TODO( crbug.com/751941 ): Pass certificate_error_info to navigation throttles. And we have existing TODOs in NavigationURLLoaderNetworkService::OnComplete like: // TODO( https://crbug.com/757633 ): Pass real values in the case of cert // errors. +lgarron as FYI (NetworkService is still just an FYI bot)
,
Aug 31 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/d2bc9edfd8862f72ec34f4e18a7858e5bc1f326a commit d2bc9edfd8862f72ec34f4e18a7858e5bc1f326a Author: Matt Falkenhagen <falken@chromium.org> Date: Thu Aug 31 04:20:22 2017 NetworkService: Disable another NavigationHandleImplBrowserTest NavigationHandleImplBrowserTest.VerifyRequestContextTypeForFrameTree also fails since r498645. It's flaky so I didn't notice it in the first bot failure. NOTRY=true Bug: 760831 Change-Id: I62bcff8b59abc359e2cb392781726c525af344c2 TBR: kinuko Reviewed-on: https://chromium-review.googlesource.com/645026 Reviewed-by: Matt Falkenhagen <falken@chromium.org> Commit-Queue: Matt Falkenhagen <falken@chromium.org> Cr-Commit-Position: refs/heads/master@{#498752} [modify] https://crrev.com/d2bc9edfd8862f72ec34f4e18a7858e5bc1f326a/testing/buildbot/filters/mojo.fyi.network_content_browsertests.filter
,
Nov 7 2017
Apologies, applied the wrong component in bulk.
,
May 17 2018
,
May 18 2018
,
Jun 7 2018
these tests are passing now. |
||||||
►
Sign in to add a comment |
||||||
Comment 1 by falken@chromium.org
, Aug 31 2017