New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 760812 link

Starred by 1 user
Status: Verified
Owner:
wylieb@chromium.org
Closed: Sep 2017
Cc:
█ robert...@chromium.org
chanli@chromium.org
lijeffrey@chromium.org
liaoyuke@chromium.org
st...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

[Findit] Flake Analyzer - TypeError: unsupported operand type(s) for +: 'int' and 'NoneType'

Project Member Reported by wylieb@chromium.org, Aug 31 2017 
None is in the iterations field. Make EstimateSwarmingIterationTimeout defensive.

It's strange that this happens, if you add a data point to the analysis it should be well-formed.
Project Member

Comment 1 by bugdroid1@chromium.org, Aug 31 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra/+/30b662a54ae150829a440de508e26f4d34f3ef30

commit 30b662a54ae150829a440de508e26f4d34f3ef30
Author: Brandon Wyliemake <wylieb@chromium.org>
Date: Thu Aug 31 17:52:32 2017

[Findit] Flake Analyzer - DataPoints have None for iterations.

The function EstimateSwarmingIterationTimeout examines the analysis for
data points and uses the datapoints + swarming tasks to estimate a
a timeout for one iteration.

For whatever reason some datapoints have None in the place of
iterations.

This change makes EstimateSwarmingIterationTimeout defensive, although
the assumption that FlakeSwarmingTask is well-formed is still there.

Bug:760812
Change-Id: If1d4ff4dc9146c78ac6ed7cc7f77e3edce4ab911
Reviewed-on: https://chromium-review.googlesource.com/644726
Commit-Queue: Brandon Wylie <wylieb@chromium.org>
Reviewed-by: Shuotao Gao <stgao@chromium.org>

[modify] https://crrev.com/30b662a54ae150829a440de508e26f4d34f3ef30/appengine/findit/waterfall/flake/test/flake_analysis_util_test.py
[modify] https://crrev.com/30b662a54ae150829a440de508e26f4d34f3ef30/appengine/findit/waterfall/flake/flake_analysis_util.py

Comment 2 by wylieb@chromium.org, Sep 6 2017

Status: Verified (was: Started)
►

Sign in to add a comment