mash: Support tablet mode |
||||||||
Issue descriptionThere's a bunch of code in chrome that uses ash::Shell::Get()->tablet_mode_controller(). This won't work with go/mustash. Mostly it is checking to see if tablet mode is enabled or not. We ought to be able to store that in chrome somewhere, maybe with a mojom::TabletModeObserver that caches the state. (The most recent example is a chrome --mash crash in ImmersiveModeControllerAsh when opening the settings window. But there are lots of places that check for tablet mode.) Thoughts?
,
Feb 26 2018
,
Apr 19 2018
,
Jul 26
,
Aug 2
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/d689b3355eccb93a97a70c00ea37abf24388951b commit d689b3355eccb93a97a70c00ea37abf24388951b Author: Evan Stade <estade@chromium.org> Date: Thu Aug 02 01:17:22 2018 OopAsh: make browser frame respond to changes in tablet mode. Tested via --ash-debug-shortcuts and Ctrl+Alt+Shift+T Bug: 854704 ,760811 Change-Id: Ia3aadae89fcd50d95a84fdf7d275e97bc2e9e2e9 Reviewed-on: https://chromium-review.googlesource.com/1152230 Commit-Queue: Evan Stade <estade@chromium.org> Reviewed-by: Tom Sepez <tsepez@chromium.org> Reviewed-by: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#580021} [modify] https://crrev.com/d689b3355eccb93a97a70c00ea37abf24388951b/ash/frame/custom_frame_view_ash.cc [modify] https://crrev.com/d689b3355eccb93a97a70c00ea37abf24388951b/ash/public/interfaces/shell_test_api.mojom [modify] https://crrev.com/d689b3355eccb93a97a70c00ea37abf24388951b/ash/shell_test_api.cc [modify] https://crrev.com/d689b3355eccb93a97a70c00ea37abf24388951b/ash/shell_test_api.h [modify] https://crrev.com/d689b3355eccb93a97a70c00ea37abf24388951b/chrome/browser/ui/views/frame/browser_non_client_frame_view_ash.cc [modify] https://crrev.com/d689b3355eccb93a97a70c00ea37abf24388951b/chrome/browser/ui/views/frame/immersive_mode_controller_ash.cc [modify] https://crrev.com/d689b3355eccb93a97a70c00ea37abf24388951b/chrome/browser/ui/views/frame/immersive_mode_controller_ash_browsertest.cc [modify] https://crrev.com/d689b3355eccb93a97a70c00ea37abf24388951b/testing/buildbot/filters/mash.browser_tests.filter
,
Aug 13
,
Aug 15
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/d9b50c2957bc1910f7fc5cfae2914a08cf170c84 commit d9b50c2957bc1910f7fc5cfae2914a08cf170c84 Author: Evan Stade <estade@chromium.org> Date: Wed Aug 15 00:05:37 2018 Update ChromeNativeAppWindowViewsAuraAshBrowserTest wrt tablet mode Use the shell test api (mojo) instead of direct access to ash::Shell. Bug: 760811 Change-Id: If8526428917d72eeeb852698cb6cb31498eef741 Reviewed-on: https://chromium-review.googlesource.com/1175068 Commit-Queue: Evan Stade <estade@chromium.org> Reviewed-by: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#583093} [add] https://crrev.com/d9b50c2957bc1910f7fc5cfae2914a08cf170c84/chrome/browser/ui/ash/tablet_mode_client_test_util.cc [add] https://crrev.com/d9b50c2957bc1910f7fc5cfae2914a08cf170c84/chrome/browser/ui/ash/tablet_mode_client_test_util.h [modify] https://crrev.com/d9b50c2957bc1910f7fc5cfae2914a08cf170c84/chrome/browser/ui/views/apps/chrome_native_app_window_views_aura_ash_browsertest.cc [modify] https://crrev.com/d9b50c2957bc1910f7fc5cfae2914a08cf170c84/chrome/browser/ui/views/frame/immersive_mode_controller_ash_browsertest.cc [modify] https://crrev.com/d9b50c2957bc1910f7fc5cfae2914a08cf170c84/chrome/test/BUILD.gn
,
Aug 15
I'm tagging this with single-process mash mode. I suspect we don't necessarily need everything for single-process mash, but that needs to be evaluated.
,
Sep 4
I believe all non-test references are already fixed, and the test references are only in non-mash tests. DisplayInfoProviderChromeosTest uses Shell::tablet_mode_controller, but has bigger issues in single process Mash (two InputDeviceManagers on the same thread).
,
Sep 5
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/d680197598954dcdd42f350ff96241df809b519c commit d680197598954dcdd42f350ff96241df809b519c Author: Evan Stade <estade@chromium.org> Date: Wed Sep 05 15:31:03 2018 Mash: Clean up various Ash includes in Chrome tests. Bug: 760811 Change-Id: If4f19ebfeb32cfdfca8aa94eac26c9c7afbf44fa Reviewed-on: https://chromium-review.googlesource.com/1204591 Commit-Queue: Evan Stade <estade@chromium.org> Reviewed-by: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#588871} [modify] https://crrev.com/d680197598954dcdd42f350ff96241df809b519c/chrome/browser/ui/ash/launcher/chrome_launcher_controller_unittest.cc [modify] https://crrev.com/d680197598954dcdd42f350ff96241df809b519c/chrome/browser/ui/views/frame/browser_non_client_frame_view_ash_browsertest.cc [modify] https://crrev.com/d680197598954dcdd42f350ff96241df809b519c/chrome/browser/ui/views/frame/immersive_mode_controller_ash_browsertest.cc
,
Oct 1
,
Nov 1
Evan, Is there still work to do here for single-process-mash?
,
Nov 1
I think we're done for single process mash, and even for oopash I think we only need to update a test or two.
,
Nov 5
Excellent! I'm going to retarget for multi-process then. |
||||||||
►
Sign in to add a comment |
||||||||
Comment 1 by bugdroid1@chromium.org
, Aug 31 2017