[MD settings] gather uma on cookies exceptions and local data |
||||||
Issue descriptionIn issue 759252 the cookies exceptions and local data were separated to different pages. Track the hits to the different URLs to determine usage of each.
,
Sep 1 2017
,
Sep 1 2017
,
Sep 2 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/be66a71bd92a620b21fcff0eafe5ba73f4da140d commit be66a71bd92a620b21fcff0eafe5ba73f4da140d Author: Dave Schuyler <dschuyler@chromium.org> Date: Sat Sep 02 01:26:28 2017 [MD settings] UMA for page visits. This CL adds UMA for visiting pages within chrome://settings/. We previously had UMA for visiting top-level chrome://settings/, but it didn't record paths within settings or navigations within chrome://settings/. e.g. chrome://settings/appearance/ or chrome://settings/content/cookies/ TBR=thakis@chromium.org Bug: 760804 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I9735e20e32bea060bdd8ef8b5910da7667a73653 Reviewed-on: https://chromium-review.googlesource.com/646911 Commit-Queue: Dave Schuyler <dschuyler@chromium.org> Reviewed-by: Ilya Sherman <isherman@chromium.org> Reviewed-by: Tommy Li <tommycli@chromium.org> Reviewed-by: Reilly Grant <reillyg@chromium.org> Cr-Commit-Position: refs/heads/master@{#499367} [modify] https://crrev.com/be66a71bd92a620b21fcff0eafe5ba73f4da140d/chrome/browser/resources/settings/compiled_resources2.gyp [modify] https://crrev.com/be66a71bd92a620b21fcff0eafe5ba73f4da140d/chrome/browser/resources/settings/route.js [modify] https://crrev.com/be66a71bd92a620b21fcff0eafe5ba73f4da140d/extensions/browser/api/metrics_private/metrics_private_api.cc [modify] https://crrev.com/be66a71bd92a620b21fcff0eafe5ba73f4da140d/extensions/browser/api/metrics_private/metrics_private_api.h [modify] https://crrev.com/be66a71bd92a620b21fcff0eafe5ba73f4da140d/extensions/browser/extension_function_histogram_value.h [modify] https://crrev.com/be66a71bd92a620b21fcff0eafe5ba73f4da140d/extensions/common/api/metrics_private.json [modify] https://crrev.com/be66a71bd92a620b21fcff0eafe5ba73f4da140d/third_party/closure_compiler/externs/metrics_private.js [modify] https://crrev.com/be66a71bd92a620b21fcff0eafe5ba73f4da140d/tools/metrics/histograms/enums.xml [modify] https://crrev.com/be66a71bd92a620b21fcff0eafe5ba73f4da140d/tools/metrics/histograms/histograms.xml
,
Sep 2 2017
,
Sep 3 2017
Your change meets the bar and is auto-approved for M62. Please go ahead and merge the CL to branch 3202 manually. Please contact milestone owner if you have questions. Owners: amineer@(Android), cmasso@(iOS), bhthompson@(ChromeOS), abdulsyed@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Sep 6 2017
This issue has been approved for a merge. Please merge the fix to any appropriate branches as soon as possible! If all merges have been completed, please remove any remaining Merge-Approved labels from this issue. Thanks for your time! To disable nags, add the Disable-Nags label. For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Sep 6 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/6ce49c82745f133cc393af45a5748b912622aa66 commit 6ce49c82745f133cc393af45a5748b912622aa66 Author: Dave Schuyler <dschuyler@chromium.org> Date: Wed Sep 06 22:15:54 2017 [MD settings] UMA for page visits. This CL adds UMA for visiting pages within chrome://settings/. We previously had UMA for visiting top-level chrome://settings/, but it didn't record paths within settings or navigations within chrome://settings/. e.g. chrome://settings/appearance/ or chrome://settings/content/cookies/ TBR=dschuyler@chromium.org, thakis@chromium.org (cherry picked from commit be66a71bd92a620b21fcff0eafe5ba73f4da140d) Bug: 760804 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I9735e20e32bea060bdd8ef8b5910da7667a73653 Reviewed-on: https://chromium-review.googlesource.com/646911 Commit-Queue: Dave Schuyler <dschuyler@chromium.org> Reviewed-by: Ilya Sherman <isherman@chromium.org> Reviewed-by: Tommy Li <tommycli@chromium.org> Reviewed-by: Reilly Grant <reillyg@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#499367} Reviewed-on: https://chromium-review.googlesource.com/653479 Reviewed-by: Dave Schuyler <dschuyler@chromium.org> Cr-Commit-Position: refs/branch-heads/3202@{#56} Cr-Branched-From: fa6a5d87adff761bc16afc5498c3f5944c1daa68-refs/heads/master@{#499098} [modify] https://crrev.com/6ce49c82745f133cc393af45a5748b912622aa66/chrome/browser/resources/settings/compiled_resources2.gyp [modify] https://crrev.com/6ce49c82745f133cc393af45a5748b912622aa66/chrome/browser/resources/settings/route.js [modify] https://crrev.com/6ce49c82745f133cc393af45a5748b912622aa66/extensions/browser/api/metrics_private/metrics_private_api.cc [modify] https://crrev.com/6ce49c82745f133cc393af45a5748b912622aa66/extensions/browser/api/metrics_private/metrics_private_api.h [modify] https://crrev.com/6ce49c82745f133cc393af45a5748b912622aa66/extensions/browser/extension_function_histogram_value.h [modify] https://crrev.com/6ce49c82745f133cc393af45a5748b912622aa66/extensions/common/api/metrics_private.json [modify] https://crrev.com/6ce49c82745f133cc393af45a5748b912622aa66/third_party/closure_compiler/externs/metrics_private.js [modify] https://crrev.com/6ce49c82745f133cc393af45a5748b912622aa66/tools/metrics/histograms/enums.xml [modify] https://crrev.com/6ce49c82745f133cc393af45a5748b912622aa66/tools/metrics/histograms/histograms.xml
,
Sep 6 2017
|
||||||
►
Sign in to add a comment |
||||||
Comment 1 by dschuyler@chromium.org
, Aug 31 2017