New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 760783 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Aug 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug



Sign in to add a comment

Remove "enable Bluetooth" notification

Project Member Reported by khorimoto@chromium.org, Aug 30 2017

Issue description

This is a new requirement to get UX launch approval.
 
Blocking: 759257
Blocking: -759257
This issue is not blocking issue 759257. They can be worked on in parallel.
Status: Started (was: Assigned)
Project Member

Comment 4 by bugdroid1@chromium.org, Aug 31 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d0c017bb5cfaaa9c7945664ca2a3d6ed321f806a

commit d0c017bb5cfaaa9c7945664ca2a3d6ed321f806a
Author: Kyle Horimoto <khorimoto@google.com>
Date: Thu Aug 31 02:42:56 2017

[CrOS Tether] Remove the "enable Bluetooth" notification.

UX has decided that this should no longer be part of Instant Tethering.

Bug:  760783 , 672263
Change-Id: I2584964a926106a03a9e1b17757cdca27c9eefc7
Reviewed-on: https://chromium-review.googlesource.com/644103
Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Commit-Queue: Kyle Horimoto <khorimoto@chromium.org>
Cr-Commit-Position: refs/heads/master@{#498737}
[modify] https://crrev.com/d0c017bb5cfaaa9c7945664ca2a3d6ed321f806a/chrome/browser/chromeos/net/tether_notification_presenter.cc
[modify] https://crrev.com/d0c017bb5cfaaa9c7945664ca2a3d6ed321f806a/chrome/browser/chromeos/net/tether_notification_presenter.h
[modify] https://crrev.com/d0c017bb5cfaaa9c7945664ca2a3d6ed321f806a/chrome/browser/chromeos/net/tether_notification_presenter_unittest.cc
[modify] https://crrev.com/d0c017bb5cfaaa9c7945664ca2a3d6ed321f806a/chrome/browser/chromeos/tether/tether_service.cc
[modify] https://crrev.com/d0c017bb5cfaaa9c7945664ca2a3d6ed321f806a/chrome/browser/chromeos/tether/tether_service.h
[modify] https://crrev.com/d0c017bb5cfaaa9c7945664ca2a3d6ed321f806a/chrome/browser/chromeos/tether/tether_service_unittest.cc
[modify] https://crrev.com/d0c017bb5cfaaa9c7945664ca2a3d6ed321f806a/chromeos/components/tether/fake_notification_presenter.cc
[modify] https://crrev.com/d0c017bb5cfaaa9c7945664ca2a3d6ed321f806a/chromeos/components/tether/fake_notification_presenter.h
[modify] https://crrev.com/d0c017bb5cfaaa9c7945664ca2a3d6ed321f806a/chromeos/components/tether/notification_presenter.h

Labels: Merge-Request-61
Project Member

Comment 6 by sheriffbot@chromium.org, Aug 31 2017

Labels: -Merge-Request-61 Merge-Review-61 Hotlist-Merge-Review
This bug requires manual review: We are only 4 days from stable.
Please contact the milestone owner if you have questions.
Owners: amineer@(Android), cmasso@(iOS), ketakid@(ChromeOS), govind@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Comment 7 by ketakid@google.com, Aug 31 2017

Labels: -Merge-Review-61 Merge-Approved-61
Approving merge to M61. 
Project Member

Comment 8 by bugdroid1@chromium.org, Aug 31 2017

Labels: -merge-approved-61 merge-merged-3163
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8ab2c8e877fd05f1cc784ffa8bbaaebf8154d845

commit 8ab2c8e877fd05f1cc784ffa8bbaaebf8154d845
Author: Kyle Horimoto <khorimoto@google.com>
Date: Thu Aug 31 03:23:51 2017

[CrOS Tether] Remove the "enable Bluetooth" notification.

UX has decided that this should no longer be part of Instant Tethering.

TBR=khorimoto@google.com

(cherry picked from commit d0c017bb5cfaaa9c7945664ca2a3d6ed321f806a)

Bug:  760783 , 672263
Change-Id: I2584964a926106a03a9e1b17757cdca27c9eefc7
Reviewed-on: https://chromium-review.googlesource.com/644103
Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Commit-Queue: Kyle Horimoto <khorimoto@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#498737}
Reviewed-on: https://chromium-review.googlesource.com/644070
Reviewed-by: Kyle Horimoto <khorimoto@chromium.org>
Cr-Commit-Position: refs/branch-heads/3163@{#1028}
Cr-Branched-From: ff259bab28b35d242e10186cd63af7ed404fae0d-refs/heads/master@{#488528}
[modify] https://crrev.com/8ab2c8e877fd05f1cc784ffa8bbaaebf8154d845/chrome/browser/chromeos/net/tether_notification_presenter.cc
[modify] https://crrev.com/8ab2c8e877fd05f1cc784ffa8bbaaebf8154d845/chrome/browser/chromeos/net/tether_notification_presenter.h
[modify] https://crrev.com/8ab2c8e877fd05f1cc784ffa8bbaaebf8154d845/chrome/browser/chromeos/net/tether_notification_presenter_unittest.cc
[modify] https://crrev.com/8ab2c8e877fd05f1cc784ffa8bbaaebf8154d845/chrome/browser/chromeos/tether/tether_service.cc
[modify] https://crrev.com/8ab2c8e877fd05f1cc784ffa8bbaaebf8154d845/chrome/browser/chromeos/tether/tether_service.h
[modify] https://crrev.com/8ab2c8e877fd05f1cc784ffa8bbaaebf8154d845/chrome/browser/chromeos/tether/tether_service_unittest.cc
[modify] https://crrev.com/8ab2c8e877fd05f1cc784ffa8bbaaebf8154d845/chromeos/components/tether/fake_notification_presenter.cc
[modify] https://crrev.com/8ab2c8e877fd05f1cc784ffa8bbaaebf8154d845/chromeos/components/tether/fake_notification_presenter.h
[modify] https://crrev.com/8ab2c8e877fd05f1cc784ffa8bbaaebf8154d845/chromeos/components/tether/notification_presenter.h

Status: Fixed (was: Started)

Comment 10 by dchan@chromium.org, Jan 22 2018

Status: Archived (was: Fixed)

Comment 11 by dchan@chromium.org, Jan 23 2018

Status: Fixed (was: Archived)

Sign in to add a comment