New issue
Advanced search Search tips

Issue 760764 link

Starred by 2 users
Status: Available
Owner: ----
Cc:
dgro...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Android , Windows , Chrome , Mac , Fuchsia
Pri: 3
Type: Bug



Sign in to add a comment

In fixed layout tables, Blink distributes column width differently than FF/Edge

Project Member Reported by dgro...@chromium.org, Aug 30 2017 
When a fixed layout table has extra width after a first pass assigning width to columns, FF/Edge/css-tables-3 distributes it to
(1) auto columns, or
(2) fixed width columns, or
(3) percent columns

Blink/WebKit distributes to
(1) auto columns, or
(2) BOTH fixed and percent columns

E.g. https://jsfiddle.net/dgrogan/1bsdtse9/

<table style="table-layout: fixed; width: 300px">
  <tr>
    <td style="width: 20px">A</td>
    <td style="width: 10px">B</td>
    <td style="width: 10%">C</td>
  </tr>
</table>

First pass:
A = 20px B = 10px C = 30px

Second pass:
A = 180px B = 90px C = 30px <-- FF/Edge
A = 100px B = 50px C = 150px <-- Chrome

See https://github.com/w3c/csswg-drafts/issues/484
Project Member

Comment 1 by bugdroid1@chromium.org, Aug 31 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/cf1c597e7a016c4d05e68059bd968403e7850516

commit cf1c597e7a016c4d05e68059bd968403e7850516
Author: David Grogan <dgrogan@chromium.org>
Date: Thu Aug 31 20:16:38 2017

[css-tables] Collect UMA for layout change

Blink distributes width to columns in fixed-layout tables differently
than FF/Edge. Before we change to match, see how many sites might break.

Notes:
 - This mechanism isn't perfect, rounding might be a little different.
 - There's no existing bug about this so it's probably low impact.
 - The included test triggers the UseCounter

Bug: 760764
Change-Id: Ia6ae189f0056681a8bba382cbfe889cf79f16acc
Reviewed-on: https://chromium-review.googlesource.com/644188
Reviewed-by: Morten Stenshorne <mstensho@opera.com>
Commit-Queue: David Grogan <dgrogan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#498972}
[add] https://crrev.com/cf1c597e7a016c4d05e68059bd968403e7850516/third_party/WebKit/LayoutTests/external/wpt/css/css-tables-3/fixed-layout-excess-width-distribution-001-expected.txt
[add] https://crrev.com/cf1c597e7a016c4d05e68059bd968403e7850516/third_party/WebKit/LayoutTests/external/wpt/css/css-tables-3/fixed-layout-excess-width-distribution-001.html
[add] https://crrev.com/cf1c597e7a016c4d05e68059bd968403e7850516/third_party/WebKit/LayoutTests/external/wpt/css/css-tables-3/support/check-layout-th.js
[modify] https://crrev.com/cf1c597e7a016c4d05e68059bd968403e7850516/third_party/WebKit/Source/core/layout/TableLayoutAlgorithmFixed.cpp
[modify] https://crrev.com/cf1c597e7a016c4d05e68059bd968403e7850516/third_party/WebKit/Source/core/layout/TableLayoutAlgorithmFixed.h
[modify] https://crrev.com/cf1c597e7a016c4d05e68059bd968403e7850516/third_party/WebKit/public/platform/web_feature.mojom
[modify] https://crrev.com/cf1c597e7a016c4d05e68059bd968403e7850516/tools/metrics/histograms/enums.xml

Comment 2 by dgro...@chromium.org, May 4 2018

Owner: ----
Status: Available (was: Started)
I'm not going to get to this in the near future. Marking available in case someone else is interested.

Comment 3 by dgro...@chromium.org, May 4 2018

Status: Started (was: Available)
The data we've collected to date:
https://www.chromestatus.com/metrics/feature/timeline/popularity/2122

Comment 4 by e...@chromium.org, Oct 23

Status: Available (was: Started)
►

Sign in to add a comment