Tab title color incorrect when Chrome Home Modern is enabled. |
||||||
Issue descriptionIn Chrome Modern, the tab theme color is always white in the tab switcher. Pages that would ordinarily use a dark theme color (requiring light title text) are still causing light titles to be generated, making the text invisible.
,
Sep 1 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/61d5c5f930134eb43cf45dbe2b2167bd07337250 commit 61d5c5f930134eb43cf45dbe2b2167bd07337250 Author: Matthew Jones <mdjones@chromium.org> Date: Fri Sep 01 15:05:42 2017 [Home] Fix tab title color in Chrome Modern Tab title colors are computed from the tab's theme color. In the modern tab switcher, the theme color is always white but the tab's original theme color is used to determine text color; white on white making the text invisible. This change adds logic to the LayerTitleCache to always use dark text for tab titles. BUG= 760740 Change-Id: Ibb05251c1c2a1115d4145f3f954d3017e93d97fe Reviewed-on: https://chromium-review.googlesource.com/644172 Commit-Queue: Matthew Jones <mdjones@chromium.org> Reviewed-by: Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#499199} [modify] https://crrev.com/61d5c5f930134eb43cf45dbe2b2167bd07337250/chrome/android/java/src/org/chromium/chrome/browser/compositor/LayerTitleCache.java
,
Sep 1 2017
,
Sep 1 2017
Marking as RBS since this seems like a sufficiently bad experience.
,
Sep 1 2017
You probably missed branch so make sure you double check that.
,
Sep 5 2017
Issue 761947 has been merged into this issue.
,
Sep 5 2017
Requesting a merge since this will result in invisible tab titles and is a 5 line change.
,
Sep 5 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/fba6588489fd94a60be80552b0415548540bf936 commit fba6588489fd94a60be80552b0415548540bf936 Author: Matthew Jones <mdjones@chromium.org> Date: Tue Sep 05 22:58:35 2017 [Home] Account for incognito in modern tab title Titles in Chrome Modern are not always white, incognito still uses a dark theme. BUG= 760740 Change-Id: I82800234101f3755dcb3214c65942ae82e59b3d9 Reviewed-on: https://chromium-review.googlesource.com/651570 Reviewed-by: Theresa <twellington@chromium.org> Commit-Queue: Matthew Jones <mdjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#499781} [modify] https://crrev.com/fba6588489fd94a60be80552b0415548540bf936/chrome/android/java/src/org/chromium/chrome/browser/compositor/LayerTitleCache.java
,
Sep 5 2017
The change that just landed is the one that will be merged.
,
Sep 6 2017
Your change meets the bar and is auto-approved for M62. Please go ahead and merge the CL to branch 3202 manually. Please contact milestone owner if you have questions. Owners: amineer@(Android), cmasso@(iOS), bhthompson@(ChromeOS), abdulsyed@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Sep 11 2017
This issue has been approved for a merge. Please merge the fix to any appropriate branches as soon as possible! If all merges have been completed, please remove any remaining Merge-Approved labels from this issue. Thanks for your time! To disable nags, add the Disable-Nags label. For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Sep 11 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/6dd103c99f5d0da25e410e1b23ce8a5dc29cd876 commit 6dd103c99f5d0da25e410e1b23ce8a5dc29cd876 Author: Matthew Jones <mdjones@chromium.org> Date: Mon Sep 11 20:37:19 2017 [Home] Account for incognito in modern tab title Titles in Chrome Modern are not always white, incognito still uses a dark theme. BUG= 760740 TBR=mdjones@chromium.org (cherry picked from commit fba6588489fd94a60be80552b0415548540bf936) Change-Id: I82800234101f3755dcb3214c65942ae82e59b3d9 Reviewed-on: https://chromium-review.googlesource.com/651570 Reviewed-by: Theresa <twellington@chromium.org> Commit-Queue: Matthew Jones <mdjones@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#499781} Reviewed-on: https://chromium-review.googlesource.com/661319 Reviewed-by: Matthew Jones <mdjones@chromium.org> Cr-Commit-Position: refs/branch-heads/3202@{#147} Cr-Branched-From: fa6a5d87adff761bc16afc5498c3f5944c1daa68-refs/heads/master@{#499098} [modify] https://crrev.com/6dd103c99f5d0da25e410e1b23ce8a5dc29cd876/chrome/android/java/src/org/chromium/chrome/browser/compositor/LayerTitleCache.java
,
Sep 12 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/b0bb3a87fba58edbd3c19b2b6ad3e4a9e6fb8258 commit b0bb3a87fba58edbd3c19b2b6ad3e4a9e6fb8258 Author: John Mellor <johnme@chromium.org> Date: Tue Sep 12 14:01:16 2017 Revert "[Home] Account for incognito in modern tab title" This reverts commit 6dd103c99f5d0da25e410e1b23ce8a5dc29cd876. Reason for revert: this broke https://uberchromegw.corp.google.com/i/official.android/builders/official-arm/builds/2411 with error message: ../../chrome/android/java/src/org/chromium/chrome/browser/compositor/LayerTitleCache.java:128: error: cannot find symbol if (!DeviceFormFactor.isTablet() && !FeatureUtilities.isChromeHomeModernEnabled()) Original change's description: > [Home] Account for incognito in modern tab title > > Titles in Chrome Modern are not always white, incognito still uses a > dark theme. > > BUG= 760740 > TBR=mdjones@chromium.org > > (cherry picked from commit fba6588489fd94a60be80552b0415548540bf936) > > Change-Id: I82800234101f3755dcb3214c65942ae82e59b3d9 > Reviewed-on: https://chromium-review.googlesource.com/651570 > Reviewed-by: Theresa <twellington@chromium.org> > Commit-Queue: Matthew Jones <mdjones@chromium.org> > Cr-Original-Commit-Position: refs/heads/master@{#499781} > Reviewed-on: https://chromium-review.googlesource.com/661319 > Reviewed-by: Matthew Jones <mdjones@chromium.org> > Cr-Commit-Position: refs/branch-heads/3202@{#147} > Cr-Branched-From: fa6a5d87adff761bc16afc5498c3f5944c1daa68-refs/heads/master@{#499098} TBR=twellington@chromium.org,mdjones@chromium.org Change-Id: I12ab4b52aa3c9f6007f26388cfe14e40b3e90f90 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 764200, 760740 Reviewed-on: https://chromium-review.googlesource.com/663381 Reviewed-by: John Mellor <johnme@chromium.org> Cr-Commit-Position: refs/branch-heads/3202@{#162} Cr-Branched-From: fa6a5d87adff761bc16afc5498c3f5944c1daa68-refs/heads/master@{#499098} [modify] https://crrev.com/b0bb3a87fba58edbd3c19b2b6ad3e4a9e6fb8258/chrome/android/java/src/org/chromium/chrome/browser/compositor/LayerTitleCache.java
,
Sep 12 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/31e34ea154cf66281f3e95602f407802ccea8a0b commit 31e34ea154cf66281f3e95602f407802ccea8a0b Author: Matthew Jones <mdjones@chromium.org> Date: Tue Sep 12 15:46:46 2017 Revert "Revert "[Home] Account for incognito in modern tab title"" This reverts commit b0bb3a87fba58edbd3c19b2b6ad3e4a9e6fb8258. Reason for revert: <INSERT REASONING HERE> Original change's description: > Revert "[Home] Account for incognito in modern tab title" > > This reverts commit 6dd103c99f5d0da25e410e1b23ce8a5dc29cd876. > > Reason for revert: this broke > https://uberchromegw.corp.google.com/i/official.android/builders/official-arm/builds/2411 > with error message: > ../../chrome/android/java/src/org/chromium/chrome/browser/compositor/LayerTitleCache.java:128: error: cannot find symbol > if (!DeviceFormFactor.isTablet() && !FeatureUtilities.isChromeHomeModernEnabled()) > > Original change's description: > > [Home] Account for incognito in modern tab title > > > > Titles in Chrome Modern are not always white, incognito still uses a > > dark theme. > > > > BUG= 760740 > > TBR=mdjones@chromium.org > > > > (cherry picked from commit fba6588489fd94a60be80552b0415548540bf936) > > > > Change-Id: I82800234101f3755dcb3214c65942ae82e59b3d9 > > Reviewed-on: https://chromium-review.googlesource.com/651570 > > Reviewed-by: Theresa <twellington@chromium.org> > > Commit-Queue: Matthew Jones <mdjones@chromium.org> > > Cr-Original-Commit-Position: refs/heads/master@{#499781} > > Reviewed-on: https://chromium-review.googlesource.com/661319 > > Reviewed-by: Matthew Jones <mdjones@chromium.org> > > Cr-Commit-Position: refs/branch-heads/3202@{#147} > > Cr-Branched-From: fa6a5d87adff761bc16afc5498c3f5944c1daa68-refs/heads/master@{#499098} > > TBR=twellington@chromium.org,mdjones@chromium.org > > Change-Id: I12ab4b52aa3c9f6007f26388cfe14e40b3e90f90 > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: 764200, 760740 > Reviewed-on: https://chromium-review.googlesource.com/663381 > Reviewed-by: John Mellor <johnme@chromium.org> > Cr-Commit-Position: refs/branch-heads/3202@{#162} > Cr-Branched-From: fa6a5d87adff761bc16afc5498c3f5944c1daa68-refs/heads/master@{#499098} TBR=johnme@chromium.org,twellington@chromium.org,mdjones@chromium.org Change-Id: I8afb1fdf63fefacf33bba8bde5a9065eac85a295 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 764200, 760740 Reviewed-on: https://chromium-review.googlesource.com/663738 Reviewed-by: Matthew Jones <mdjones@chromium.org> Cr-Commit-Position: refs/branch-heads/3202@{#166} Cr-Branched-From: fa6a5d87adff761bc16afc5498c3f5944c1daa68-refs/heads/master@{#499098} [modify] https://crrev.com/31e34ea154cf66281f3e95602f407802ccea8a0b/chrome/android/java/src/org/chromium/chrome/browser/compositor/LayerTitleCache.java |
||||||
►
Sign in to add a comment |
||||||
Comment 1 by kings...@google.com
, Aug 31 2017