New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 760735 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Sep 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

[autotest] LXC unittests fail on moblab

Project Member Reported by kenobi@chromium.org, Aug 30 2017

Issue description

Various lxc unittests are failing on moblab with errors related to lxc-clone.  Code is attempting to create snapshot clones on moblab, which shouldn't be happening.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Sep 2 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/autotest/+/6b1bf747a68d91ac6a3835c3a71d8b779ce4c1f0

commit 6b1bf747a68d91ac6a3835c3a71d8b779ce4c1f0
Author: Ben Kwa <kenobi@google.com>
Date: Sat Sep 02 02:01:35 2017

[autotest] Fix container cloning on moblab.

The code for properly setting snapshot settings was in the
ContainerBucket, so container cloning only worked properly everywhere if
it was invoked via the ContainerBucket.create_from_base function.  In
particular, this causes unit tests to fail on moblab.

Fix the code so that Container.clone works everywhere.

Also, disable some newly-added tests that are guaranteed to fail on
moblab.

BUG= chromium:760735 
TEST=sudo python base_image_unittest.py
TEST=sudo python container_unittest.py
TEST=sudo python lxc_functional_test.py

Change-Id: I75e3ffa9a3d6ccf3cf2ad1b720a81d4bf814ec89
Reviewed-on: https://chromium-review.googlesource.com/644322
Commit-Ready: Ben Kwa <kenobi@chromium.org>
Tested-by: Ben Kwa <kenobi@chromium.org>
Reviewed-by: Ben Kwa <kenobi@chromium.org>

[modify] https://crrev.com/6b1bf747a68d91ac6a3835c3a71d8b779ce4c1f0/site_utils/lxc/base_image_unittest.py
[modify] https://crrev.com/6b1bf747a68d91ac6a3835c3a71d8b779ce4c1f0/site_utils/lxc/container.py
[modify] https://crrev.com/6b1bf747a68d91ac6a3835c3a71d8b779ce4c1f0/site_utils/lxc/utils.py
[modify] https://crrev.com/6b1bf747a68d91ac6a3835c3a71d8b779ce4c1f0/site_utils/lxc/lxc_functional_test.py
[modify] https://crrev.com/6b1bf747a68d91ac6a3835c3a71d8b779ce4c1f0/site_utils/lxc/container_bucket.py

Status: Fixed (was: Started)

Sign in to add a comment