New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 760729 link

Starred by 2 users
Status: Fixed
Owner:
█ spqc...@chromium.org
Last visit > 30 days ago
Closed: Sep 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug

Blocking:
issue 746597



Sign in to add a comment

Refactor the Page Info Icon on Mac

Project Member Reported by spqc...@chromium.org, Aug 30 2017 
The icon is pretty awkward since it's swapped between two different objects.
This caused weird bugs in the past where one object gets update, but the other one doesn't. To fix these issues and make the code easier for the eyes, combine them into one.

Comment 1 by spqc...@chromium.org, Sep 2 2017

Blocking: 746597
Project Member

Comment 2 by bugdroid1@chromium.org, Sep 5 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8a5931edaf7704fceb9d1d7bed291576bd5f9b5f

commit 8a5931edaf7704fceb9d1d7bed291576bd5f9b5f
Author: spqchan <spqchan@chromium.org>
Date: Tue Sep 05 17:05:44 2017

[Mac] Page Icon Refactor

Refactored LocationBarViewMac and combined
LocationIconDecoration and
SecurityStateBubbleDecoration into one.

The ShouldShow***Bubble() methods in
LocationBarViewMacare are also condensed into one
method.

Bug:  760729 
Change-Id: I9865f91ed4d61ef7dd30ed49fdef44a0f92a0bac
Reviewed-on: https://chromium-review.googlesource.com/636753
Reviewed-by: Robert Sesek <rsesek@chromium.org>
Commit-Queue: Sarah Chan <spqchan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#499659}
[modify] https://crrev.com/8a5931edaf7704fceb9d1d7bed291576bd5f9b5f/chrome/browser/ui/BUILD.gn
[modify] https://crrev.com/8a5931edaf7704fceb9d1d7bed291576bd5f9b5f/chrome/browser/ui/cocoa/bubble_anchor_helper_views.mm
[modify] https://crrev.com/8a5931edaf7704fceb9d1d7bed291576bd5f9b5f/chrome/browser/ui/cocoa/location_bar/autocomplete_text_field_cell_unittest.mm
[modify] https://crrev.com/8a5931edaf7704fceb9d1d7bed291576bd5f9b5f/chrome/browser/ui/cocoa/location_bar/bubble_decoration.h
[modify] https://crrev.com/8a5931edaf7704fceb9d1d7bed291576bd5f9b5f/chrome/browser/ui/cocoa/location_bar/bubble_decoration.mm
[modify] https://crrev.com/8a5931edaf7704fceb9d1d7bed291576bd5f9b5f/chrome/browser/ui/cocoa/location_bar/location_bar_view_mac.h
[modify] https://crrev.com/8a5931edaf7704fceb9d1d7bed291576bd5f9b5f/chrome/browser/ui/cocoa/location_bar/location_bar_view_mac.mm
[modify] https://crrev.com/8a5931edaf7704fceb9d1d7bed291576bd5f9b5f/chrome/browser/ui/cocoa/location_bar/location_bar_view_mac_unittest.mm
[delete] https://crrev.com/77b0453156f99cfcef1918b13a943a2780178882/chrome/browser/ui/cocoa/location_bar/location_icon_decoration.h
[delete] https://crrev.com/77b0453156f99cfcef1918b13a943a2780178882/chrome/browser/ui/cocoa/location_bar/location_icon_decoration.mm
[rename] https://crrev.com/8a5931edaf7704fceb9d1d7bed291576bd5f9b5f/chrome/browser/ui/cocoa/location_bar/page_info_bubble_decoration.h
[rename] https://crrev.com/8a5931edaf7704fceb9d1d7bed291576bd5f9b5f/chrome/browser/ui/cocoa/location_bar/page_info_bubble_decoration.mm
[rename] https://crrev.com/8a5931edaf7704fceb9d1d7bed291576bd5f9b5f/chrome/browser/ui/cocoa/location_bar/page_info_bubble_decoration_unittest.mm
[modify] https://crrev.com/8a5931edaf7704fceb9d1d7bed291576bd5f9b5f/chrome/browser/ui/cocoa/page_info/page_info_bubble_controller.mm
[modify] https://crrev.com/8a5931edaf7704fceb9d1d7bed291576bd5f9b5f/chrome/browser/ui/cocoa/page_info/page_info_bubble_controller_unittest.mm
[modify] https://crrev.com/8a5931edaf7704fceb9d1d7bed291576bd5f9b5f/chrome/browser/ui/cocoa/permission_bubble/permission_bubble_controller.mm
[modify] https://crrev.com/8a5931edaf7704fceb9d1d7bed291576bd5f9b5f/chrome/browser/ui/cocoa/permission_bubble/permission_bubble_controller_unittest.mm
[modify] https://crrev.com/8a5931edaf7704fceb9d1d7bed291576bd5f9b5f/chrome/test/BUILD.gn

Comment 3 by spqc...@chromium.org, Sep 6 2017

Status: Fixed (was: Started)
►

Sign in to add a comment