New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 760728 link

Starred by 1 user
Status: Assigned
Owner:
█ dgn@chromium.org
Not on Chrome anymore
Cc:
twelling...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 3
Type: Task



Sign in to add a comment

Cleanup MultiWindowUtils

Project Member Reported by dgn@chromium.org, Aug 30 2017 
twellington@: "The MultiWindowUtils affordance for testing is only used in one place, so we could conceivably move that into ChromeActivity and migrate uses of MultiWindowUtils#isInMultiWindowMode() to ApiCompatibilityUtils#isInMultiWindowMode(). Ideally there is only one #isInMultiWindowMode() method so callers don't have to decide which one to use. The intention when the ApiCompatibilityUtils method was added was to migrate uses at some (unspecified) point in the future."
Project Member

Comment 1 by bugdroid1@chromium.org, Aug 30 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b58e95dfd8c6da9a2eb0b41bfe1d2a357268a79c

commit b58e95dfd8c6da9a2eb0b41bfe1d2a357268a79c
Author: Nicolas Dossou-gbete <dgn@chromium.org>
Date: Wed Aug 30 21:19:44 2017

📱 Cleanup isInMultiWindowMode usage (1/2)

Replaces existing API level checks and reflection by using
ApiCompatibilityUtils.
Also fixes lint warnings in MultiWindowUtils.

Bug: 760728
Change-Id: I9324634d662eb465cec4417f30dc54df08947238
Reviewed-on: https://chromium-review.googlesource.com/643273
Commit-Queue: Nicolas Dossou-Gbété <dgn@chromium.org>
Reviewed-by: Ted Choc <tedchoc@chromium.org>
Reviewed-by: Theresa <twellington@chromium.org>
Cr-Commit-Position: refs/heads/master@{#498610}
[modify] https://crrev.com/b58e95dfd8c6da9a2eb0b41bfe1d2a357268a79c/chrome/android/java/src/org/chromium/chrome/browser/multiwindow/MultiWindowUtils.java
[modify] https://crrev.com/b58e95dfd8c6da9a2eb0b41bfe1d2a357268a79c/content/public/android/java/src/org/chromium/content/browser/input/SuggestionsPopupWindow.java
►

Sign in to add a comment