New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 760684 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Sep 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug



Sign in to add a comment

MD Extensions: sidebar doesn't highlight the right item when opened

Project Member Reported by scottchen@chromium.org, Aug 30 2017

Issue description

if you go to chrome:extensions/apps or chrome:extensions/shortcuts directly and open the sidebar, you'll see that it incorrectly highlights "extensions".
 
Description: Show this description
Components: -Platform>Extensions UI>Browser>ExtensionsManagement UI
Components: -UI
Project Member

Comment 4 by bugdroid1@chromium.org, Sep 7 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d7ea4434e9deb1851a78f84a1827403b109c18c1

commit d7ea4434e9deb1851a78f84a1827403b109c18c1
Author: Scott Chen <scottchen@chromium.org>
Date: Thu Sep 07 21:31:04 2017

MD Extensions: highlight sidebar item according to current page

Bug:  760684 
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I278415c4da1b4a5b82f2f7b6747c14151d7af099
Reviewed-on: https://chromium-review.googlesource.com/644568
Commit-Queue: Scott Chen <scottchen@chromium.org>
Reviewed-by: Hector Carmona <hcarmona@chromium.org>
Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#500393}
[modify] https://crrev.com/d7ea4434e9deb1851a78f84a1827403b109c18c1/chrome/browser/resources/md_extensions/compiled_resources2.gyp
[modify] https://crrev.com/d7ea4434e9deb1851a78f84a1827403b109c18c1/chrome/browser/resources/md_extensions/manager.js
[modify] https://crrev.com/d7ea4434e9deb1851a78f84a1827403b109c18c1/chrome/browser/resources/md_extensions/navigation_helper.js
[modify] https://crrev.com/d7ea4434e9deb1851a78f84a1827403b109c18c1/chrome/browser/resources/md_extensions/sidebar.html
[modify] https://crrev.com/d7ea4434e9deb1851a78f84a1827403b109c18c1/chrome/browser/resources/md_extensions/sidebar.js
[modify] https://crrev.com/d7ea4434e9deb1851a78f84a1827403b109c18c1/chrome/test/data/webui/extensions/cr_extensions_browsertest.js
[modify] https://crrev.com/d7ea4434e9deb1851a78f84a1827403b109c18c1/chrome/test/data/webui/extensions/extension_manager_test.js
[modify] https://crrev.com/d7ea4434e9deb1851a78f84a1827403b109c18c1/chrome/test/data/webui/extensions/extension_sidebar_test.js

Status: Fixed (was: Started)

Sign in to add a comment