New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 760682 link

Starred by 2 users

Issue metadata

Status: Duplicate
Merged: issue 760319
Owner:
Closed: Sep 2017
Cc:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug-Regression



Sign in to add a comment

1.8%-14.6% regression in memory.top_10_mobile at 497956:498063

Project Member Reported by pmeenan@chromium.org, Aug 30 2017

Issue description

See the link to graphs below.
 
Project Member

Comment 1 by 42576172...@developer.gserviceaccount.com, Aug 30 2017

All graphs for this bug:
  https://chromeperf.appspot.com/group_report?bug_id=760682

(For debugging:) Original alerts at time of bug-filing:
  https://chromeperf.appspot.com/group_report?sid=faaa2bddd8152415c57bb5be15b26b402a571c8c44ce1c0f774331daf695fb5c


Bot(s) for this bug's original alert(s):

android-nexus5X
Project Member

Comment 3 by 42576172...@developer.gserviceaccount.com, Aug 31 2017

Cc: timloh@chromium.org
Owner: timloh@chromium.org
Status: Assigned (was: Untriaged)

=== Auto-CCing suspected CL author timloh@chromium.org ===

Hi timloh@chromium.org, the bisect results pointed to your CL, please take a look at the
results.


=== BISECT JOB RESULTS ===
Perf regression found with culprit

Suspected Commit
  Author : Timothy Loh
  Commit : 2db3fa641f2b6a05ee894f158a93a419caf3e896
  Date   : Tue Aug 29 03:09:33 2017
  Subject: Prepare tests for enabling modal permission prompts and remove gesture experiment

Bisect Details
  Configuration: android_nexus5X_perf_bisect
  Benchmark    : memory.top_10_mobile
  Metric       : memory:chrome:all_processes:reported_by_os:gpu_memory:proportional_resident_size_avg/foreground/https_www_google_co_uk_hl_en_q_science
  Change       : 14.62% | 48746496.0 -> 55873536.0

Revision             Result               N
chromium@497955      48746496 +- 0.0      6      good
chromium@497982      48746496 +- 0.0      6      good
chromium@497996      48746496 +- 0.0      6      good
chromium@498003      48746496 +- 0.0      6      good
chromium@498004      55873536 +- 0.0      6      bad       <--
chromium@498005      55873536 +- 0.0      6      bad
chromium@498006      55873536 +- 0.0      6      bad
chromium@498009      55873536 +- 0.0      6      bad
chromium@498063      55873536 +- 0.0      6      bad

Please refer to the following doc on diagnosing memory regressions:
  https://chromium.googlesource.com/chromium/src/+/master/docs/memory-infra/memory_benchmarks.md

To Run This Test
  src/tools/perf/run_benchmark -v --browser=android-chromium --output-format=chartjson --upload-results --pageset-repeat=1 --also-run-disabled-tests memory.top_10_mobile

More information on addressing performance regressions:
  http://g.co/ChromePerformanceRegressions

Debug information about this bisect:
  https://chromeperf.appspot.com/buildbucket_job_status/8969809400442264464


For feedback, file a bug with component Speed>Bisection
Cc: briander...@chromium.org
 Issue 762219  has been merged into this issue.
 Issue 762220  has been merged into this issue.
 Issue 762239  has been merged into this issue.
 Issue 762218  has been merged into this issue.
 Issue 762270  has been merged into this issue.
 Issue 762296  has been merged into this issue.
Haven't looked into this yet. The change in question basically enabled modal permission prompts on Android in testing configurations (per the testing fieldtrial config). Presumably google.co.uk has some sort of permission prompt.
Cc: nedngu...@google.com
+nednguyen since this affects a lot of benchmarks. Ned, any ideas if these modal permission prompts should be enabled in benchmarks, or if maybe having them enabled over-tests them?
Mergedinto: 760319
Status: Duplicate (was: Assigned)

Sign in to add a comment