R62 CTS /GTS suites are not running any tests |
|||||||||||||
Issue description
Suite args changes are suspected.
08/30 11:47:01.438 INFO | dev_server:1108| Staging artifacts on devserver http://192.168.231.1:8080: build=veyron_minnie-release/R62-9894.0.0, artifacts=['control_files', 'test_suites'], files=, archive_url=gs://chromeos-moblab-peng-staging/veyron_minnie-release/R62-9894.0.0
08/30 11:47:02.443 DEBUG| dev_server:1050| response for RPC: 'Success'
08/30 11:47:02.752 DEBUG| dev_server:1006| whether artifact is staged: 'True'
08/30 11:47:02.752 INFO | dev_server:1126| Finished staging artifacts: build=veyron_minnie-release/R62-9894.0.0, artifacts=['control_files', 'test_suites'], files=, archive_url=gs://chromeos-moblab-peng-staging/veyron_minnie-release/R62-9894.0.0
08/30 11:47:02.753 DEBUG| suite:0895| Getting control file list for suite: gts
08/30 11:47:04.097 DEBUG| suite:0901| Parsed 51 control files.
08/30 11:47:04.097 DEBUG| suite:1193| Discovered 0 stable tests.
08/30 11:47:04.097 DEBUG| suite:1195| Discovered 0 unstable tests.
08/30 11:47:04.098 INFO | server_job:0184| INFO ---- Start gts timestamp=1504118824 localtime=Aug 30 11:47:04
08/30 11:47:04.098 DEBUG| suite:1210| Scheduled 0 tests, writing the total to keyval.
08/30 11:47:04.098 INFO | dynamic_suite:0524| wait_for_results is set to False, suite job will exit without waiting for test jobs to f
control.srv:
# INJECT_BEGIN - DO NOT DELETE THIS LINE
job_retry=False
test_args={'wifipass': 'None', 'ssid': 'GoogleGuest'}
suite_args=None
num=None
timeout_mins=1440
max_runtime_mins=1440
devserver_url='http://192.168.231.1:8080'
wait_for_results=False
priority=40
board='veyron_minnie'
build='veyron_minnie-release/R62-9894.0.0'
timeout=24
check_hosts=True
offload_failures_only=False
max_retries=None
pool=''
builds={'cros-version': 'veyron_minnie-release/R62-9894.0.0'}
test_source_build='veyron_minnie-release/R62-9894.0.0'
file_bugs=False
run_prod_code=False
delay_minutes=0
job_keyvals=None
args_dict={'job_retry': False, 'test_args': {'wifipass': 'None', 'ssid': 'GoogleGuest'}, 'suite_args': None, 'num': None, 'timeout_mins': 1440, 'max_runtime_mins': 1440, 'devserver_url': 'http://192.168.231.1:8080', 'wait_for_results': False, 'priority': 40, 'board': 'veyron_minnie', 'build': 'veyron_minnie-release/R62-9894.0.0', 'timeout': 24, 'check_hosts': True, 'offload_failures_only': False, 'max_retries': None, 'pool': '', 'builds': {'cros-version': 'veyron_minnie-release/R62-9894.0.0'}, 'test_source_build': 'veyron_minnie-release/R62-9894.0.0', 'file_bugs': False, 'run_prod_code': False, 'delay_minutes': 0, 'job_keyvals': None}
# INJECT_END - DO NOT DELETE LINE
# Copyright 2016 The Chromium OS Authors. All rights reserved.
# Use of this source code is governed by a BSD-style license that can be
# found in the LICENSE file.
AUTHOR = "ARC++ Team"
NAME = "gts"
PURPOSE = "GTS tests for ARC++"
CRITERIA = "All tests with SUITE=gts must pass."
TIME = "SHORT"
TEST_CATEGORY = "General"
TEST_CLASS = "suite"
TEST_TYPE = "Server"
DOC = """
This suite wraps the current GTS bundle for autotest.
"""
import common
from autotest_lib.server.cros import provision
from autotest_lib.server.cros.dynamic_suite import dynamic_suite
def predicate(test):
if not hasattr(test, 'suite') or not hasattr(test, 'name'):
return False
if not test.suite == NAME:
return False
# Strip off the cheets_GTS. from the test name before comparing to args
name = test.name[test.name.find('.') + 1:]
if name not in args_dict.get('tests', ()):
return False
# TODO(crbug.com/758427): suite_args needed to support being run by old Autotest
try:
if name not in suite_args:
return False
except NameError:
pass
return True
args_dict['name'] = NAME
args_dict['job'] = job
args_dict['add_experimental'] = True
args_dict['version_prefix'] = provision.CROS_VERSION_PREFIX
args_dict['predicate'] = predicate
dynamic_suite.reimage_and_run(**args_dict)
,
Aug 30 2017
,
Aug 30 2017
https://chromium-review.googlesource.com/c/chromiumos/third_party/autotest/+/644125 I inadvertently changed the original logic
,
Aug 31 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/third_party/autotest/+/905d6a397f2f9c5df1de1bf24fcd4111d5e69ada commit 905d6a397f2f9c5df1de1bf24fcd4111d5e69ada Author: Allen Li <ayatane@chromium.org> Date: Thu Aug 31 01:23:30 2017 Restore suite_args existence check Otherwise this returns False when suite_args is empty. Add the check also for args_dict (new style suite args). BUG= chromium:760675 TEST=None Change-Id: Id030fe87fabc4bbb0b592606e710b9ee8ca0510f Reviewed-on: https://chromium-review.googlesource.com/644125 Commit-Ready: Allen Li <ayatane@chromium.org> Tested-by: Allen Li <ayatane@chromium.org> Reviewed-by: Keith Haddow <haddowk@chromium.org> [modify] https://crrev.com/905d6a397f2f9c5df1de1bf24fcd4111d5e69ada/test_suites/control.cts_N_preconditions [modify] https://crrev.com/905d6a397f2f9c5df1de1bf24fcd4111d5e69ada/test_suites/control.cts_N [modify] https://crrev.com/905d6a397f2f9c5df1de1bf24fcd4111d5e69ada/test_suites/control.gts
,
Sep 6 2017
Should be fixed, although I don't have a moblab to flash and test.
,
Sep 15 2017
,
Sep 16 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/third_party/autotest/+/db8b8aeefe1d45ab8dcba81c0eb267ec873a0e63 commit db8b8aeefe1d45ab8dcba81c0eb267ec873a0e63 Author: Allen Li <ayatane@chromium.org> Date: Sat Sep 16 04:25:43 2017 [autotest] Handle CTS/GTS suite_args when empty CTS/GTS depend on the suite_args string being actually empty, or they will start filtering tests based on whether their names appear anywhere in the string. So '' vs '{}' is the different between running all tests or no tests. New CTS/GTS tests are passed a list of test names explicitly, so wont suffer from this problem. BUG= chromium:760675 TEST=Run on moblab Change-Id: I8f58de70b6510f6ea84f598001440a7432f9634d Reviewed-on: https://chromium-review.googlesource.com/668711 Commit-Ready: Allen Li <ayatane@chromium.org> Tested-by: Allen Li <ayatane@chromium.org> Reviewed-by: Keith Haddow <haddowk@chromium.org> [modify] https://crrev.com/db8b8aeefe1d45ab8dcba81c0eb267ec873a0e63/frontend/afe/rpc_interface.py
,
Sep 18 2017
,
Sep 18 2017
Verified by haddowk
,
Sep 18 2017
Need branch merge https://chromium-review.googlesource.com/c/chromiumos/third_party/autotest/+/671506
,
Sep 18 2017
This bug requires manual review: M62 has already been promoted to the beta branch, so this requires manual review Please contact the milestone owner if you have questions. Owners: amineer@(Android), cmasso@(iOS), bhthompson@(ChromeOS), abdulsyed@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Sep 18 2017
Disregard the merge review, this is moblab code with haddowk owns.
,
Oct 4 2017
,
Nov 4 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/third_party/autotest/+/e59bd111f9757ba24cc9ae815e0353432b69e16b commit e59bd111f9757ba24cc9ae815e0353432b69e16b Author: Allen Li <ayatane@chromium.org> Date: Sat Nov 04 01:49:23 2017 [autotest] Handle CTS/GTS suite_args when empty CTS/GTS depend on the suite_args string being actually empty, or they will start filtering tests based on whether their names appear anywhere in the string. So '' vs '{}' is the different between running all tests or no tests. New CTS/GTS tests are passed a list of test names explicitly, so wont suffer from this problem. BUG= chromium:760675 TEST=Run on moblab Change-Id: I8f58de70b6510f6ea84f598001440a7432f9634d Reviewed-on: https://chromium-review.googlesource.com/668711 Commit-Ready: Allen Li <ayatane@chromium.org> Tested-by: Allen Li <ayatane@chromium.org> Reviewed-by: Keith Haddow <haddowk@chromium.org> (cherry picked from commit db8b8aeefe1d45ab8dcba81c0eb267ec873a0e63) Reviewed-on: https://chromium-review.googlesource.com/754305 Commit-Queue: Keith Haddow <haddowk@chromium.org> Tested-by: Keith Haddow <haddowk@chromium.org> [modify] https://crrev.com/e59bd111f9757ba24cc9ae815e0353432b69e16b/frontend/afe/rpc_interface.py
,
Jan 22 2018
,
Jan 23 2018
|
|||||||||||||
►
Sign in to add a comment |
|||||||||||||
Comment 1 by haddowk@chromium.org
, Aug 30 2017