New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 760665 link

Starred by 1 user
Status: Fixed
Owner:
█ justincarlson@chromium.org
Last visit > 30 days ago
Closed: Sep 2017
Cc:
weifangsun@chromium.org
█ justincarlson@chromium.org
█ bblietz@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug

Blocking:
issue 760666



Sign in to add a comment

No Printers Promotion Shows When there are Printers

Project Member Reported by skau@chromium.org, Aug 30 2017 
The no printers promotion as seen from the printer selection dialog in print preview shows when we have detected printers.  It also only references cloud print as it is quite old.  Removing the dialog for now.  Improved UX slated for M63.

Comment 1 by skau@chromium.org, Aug 30 2017

Blocking: 760666

Comment 2 by skau@chromium.org, Aug 30 2017

Cc: justincarlson@chromium.org

Comment 3 by justincarlson@chromium.org, Aug 30 2017

Owner: justincarlson@chromium.org

Comment 4 by justincarlson@chromium.org, Sep 1 2017 

Per conversation with bblietz@, we believe it's reasonable to just remove this promotion altogether.
Project Member

Comment 5 by bugdroid1@chromium.org, Sep 12 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a030cfe148de17d75aa0fb75d114d60125c46c37

commit a030cfe148de17d75aa0fb75d114d60125c46c37
Author: Justin Carlson <justincarlson@chromium.org>
Date: Tue Sep 12 00:47:02 2017

Remove the no-destinations Cloud Print promo and associated metrics.

Bug:  760665 
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I5a3e28e9a140497e536a006b91b101c54125cce1
Reviewed-on: https://chromium-review.googlesource.com/644510
Commit-Queue: Justin Carlson <justincarlson@chromium.org>
Reviewed-by: Rebekah Potter <rbpotter@chromium.org>
Reviewed-by: Lei Zhang <thestig@chromium.org>
Reviewed-by: Dave Schuyler <dschuyler@chromium.org>
Reviewed-by: Alexei Svitkine <asvitkine@chromium.org>
Cr-Commit-Position: refs/heads/master@{#501125}
[modify] https://crrev.com/a030cfe148de17d75aa0fb75d114d60125c46c37/chrome/app/generated_resources.grd
[modify] https://crrev.com/a030cfe148de17d75aa0fb75d114d60125c46c37/chrome/browser/resources/print_preview/data/app_state.js
[modify] https://crrev.com/a030cfe148de17d75aa0fb75d114d60125c46c37/chrome/browser/resources/print_preview/data/destination_store.js
[modify] https://crrev.com/a030cfe148de17d75aa0fb75d114d60125c46c37/chrome/browser/resources/print_preview/metrics.js
[delete] https://crrev.com/308c56662d6a7f0f05282b1c2089e0c0207f986f/chrome/browser/resources/print_preview/no_destinations_promo.css
[delete] https://crrev.com/308c56662d6a7f0f05282b1c2089e0c0207f986f/chrome/browser/resources/print_preview/no_destinations_promo.html
[modify] https://crrev.com/a030cfe148de17d75aa0fb75d114d60125c46c37/chrome/browser/resources/print_preview/print_preview.html
[modify] https://crrev.com/a030cfe148de17d75aa0fb75d114d60125c46c37/chrome/browser/resources/print_preview/print_preview.js
[modify] https://crrev.com/a030cfe148de17d75aa0fb75d114d60125c46c37/chrome/browser/ui/webui/print_preview/print_preview_ui.cc
[modify] https://crrev.com/a030cfe148de17d75aa0fb75d114d60125c46c37/tools/metrics/histograms/histograms.xml

Comment 6 by justincarlson@chromium.org, Sep 12 2017

Labels: Merge-Request-62
Status: Fixed (was: Assigned)
Project Member

Comment 7 by sheriffbot@chromium.org, Sep 13 2017

Labels: -Merge-Request-62 Merge-Review-62 Hotlist-Merge-Review
This bug requires manual review: There is .grd file changes and we are only 33 days from stable.
Please contact the milestone owner if you have questions.
Owners: amineer@(Android), cmasso@(iOS), bhthompson@(ChromeOS), abdulsyed@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Comment 8 by weifangsun@chromium.org, Sep 15 2017

Labels: -M-61

Comment 9 by bhthompson@google.com, Sep 18 2017

Labels: -Hotlist-Merge-Review -Merge-Review-62 Merge-Approved-62
Merge approved for 62.
Project Member

Comment 10 by bugdroid1@chromium.org, Sep 19 2017

Labels: -merge-approved-62 merge-merged-3202
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/92a4758eb383fddb9d3f4720fb8f96f7714729d9

commit 92a4758eb383fddb9d3f4720fb8f96f7714729d9
Author: Justin Carlson <justincarlson@chromium.org>
Date: Tue Sep 19 18:28:07 2017

Remove the no-destinations Cloud Print promo and associated metrics.

Bug:  760665 
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I5a3e28e9a140497e536a006b91b101c54125cce1
Reviewed-on: https://chromium-review.googlesource.com/644510
Commit-Queue: Justin Carlson <justincarlson@chromium.org>
Reviewed-by: Rebekah Potter <rbpotter@chromium.org>
Reviewed-by: Lei Zhang <thestig@chromium.org>
Reviewed-by: Dave Schuyler <dschuyler@chromium.org>
Reviewed-by: Alexei Svitkine <asvitkine@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#501125}(cherry picked from commit a030cfe148de17d75aa0fb75d114d60125c46c37)
Reviewed-on: https://chromium-review.googlesource.com/673106
Reviewed-by: Sean Kau <skau@chromium.org>
Cr-Commit-Position: refs/branch-heads/3202@{#327}
Cr-Branched-From: fa6a5d87adff761bc16afc5498c3f5944c1daa68-refs/heads/master@{#499098}
[modify] https://crrev.com/92a4758eb383fddb9d3f4720fb8f96f7714729d9/chrome/app/generated_resources.grd
[modify] https://crrev.com/92a4758eb383fddb9d3f4720fb8f96f7714729d9/chrome/browser/resources/print_preview/data/app_state.js
[modify] https://crrev.com/92a4758eb383fddb9d3f4720fb8f96f7714729d9/chrome/browser/resources/print_preview/data/destination_store.js
[modify] https://crrev.com/92a4758eb383fddb9d3f4720fb8f96f7714729d9/chrome/browser/resources/print_preview/metrics.js
[delete] https://crrev.com/33f15bdd54b2eae8ac638551b1f8abf688df0347/chrome/browser/resources/print_preview/no_destinations_promo.css
[delete] https://crrev.com/33f15bdd54b2eae8ac638551b1f8abf688df0347/chrome/browser/resources/print_preview/no_destinations_promo.html
[modify] https://crrev.com/92a4758eb383fddb9d3f4720fb8f96f7714729d9/chrome/browser/resources/print_preview/print_preview.html
[modify] https://crrev.com/92a4758eb383fddb9d3f4720fb8f96f7714729d9/chrome/browser/resources/print_preview/print_preview.js
[modify] https://crrev.com/92a4758eb383fddb9d3f4720fb8f96f7714729d9/chrome/browser/ui/webui/print_preview/print_preview_ui.cc
[modify] https://crrev.com/92a4758eb383fddb9d3f4720fb8f96f7714729d9/tools/metrics/histograms/histograms.xml
►

Sign in to add a comment