New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 760655 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Aug 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 1
Type: Bug



Sign in to add a comment

Cronet testSdchEnabled is flaky

Project Member Reported by mge...@chromium.org, Aug 30 2017

Issue description

Example: https://build.chromium.org/p/chromium.android/builders/Android%20Cronet%20ARMv6%20Builder/builds/5638

C  261.013s Main  [FAIL] org.chromium.net.SdchTest#testSdchEnabled:
C  261.013s Main  java.lang.Throwable: CronetTestBase#runTest failed.
C  261.013s Main  	at org.chromium.net.u.a(CronetTestRule.java:1163)
C  261.013s Main  	at org.chromium.net.v.evaluate(CronetTestRule.java:79)
C  261.013s Main  	at org.junit.rules.RunRules.evaluate(RunRules.java:20)
C  261.013s Main  	at org.junit.runners.ParentRunner.runLeaf(ParentRunner.java:325)
C  261.013s Main  	at org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:78)
C  261.013s Main  	at org.chromium.base.test.BaseJUnit4ClassRunner.runChild(BaseJUnit4ClassRunner.java:175)
C  261.013s Main  	at org.chromium.base.test.BaseJUnit4ClassRunner.runChild(BaseJUnit4ClassRunner.java:40)
C  261.013s Main  	at org.junit.runners.ParentRunner$3.run(ParentRunner.java:290)
C  261.014s Main  	at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:71)
C  261.014s Main  	at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:288)
C  261.014s Main  	at org.junit.runners.ParentRunner.access$000(ParentRunner.java:58)
C  261.014s Main  	at org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:268)
C  261.014s Main  	at org.junit.runners.ParentRunner.run(ParentRunner.java:363)
C  261.014s Main  	at org.chromium.base.test.BaseJUnit4ClassRunner.run(BaseJUnit4ClassRunner.java:164)
C  261.014s Main  	at org.junit.runners.Suite.runChild(Suite.java:128)
C  261.014s Main  	at org.junit.runners.Suite.runChild(Suite.java:27)
C  261.014s Main  	at org.junit.runners.ParentRunner$3.run(ParentRunner.java:290)
C  261.014s Main  	at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:71)
C  261.014s Main  	at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:288)
C  261.014s Main  	at org.junit.runners.ParentRunner.access$000(ParentRunner.java:58)
C  261.014s Main  	at org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:268)
C  261.014s Main  	at org.junit.runners.ParentRunner.run(ParentRunner.java:363)
C  261.014s Main  	at org.junit.runner.JUnitCore.run(JUnitCore.java:137)
C  261.014s Main  	at org.junit.runner.JUnitCore.run(JUnitCore.java:115)
C  261.014s Main  	at android.support.test.internal.runner.TestExecutor.a(TestExecutor.java:59)
C  261.014s Main  	at android.support.test.runner.AndroidJUnitRunner.onStart(AndroidJUnitRunner.java:262)
C  261.014s Main  	at org.chromium.base.test.BaseChromiumAndroidJUnitRunner.onStart(BaseChromiumAndroidJUnitRunner.java:98)
C  261.014s Main  	at android.app.Instrumentation$InstrumentationThread.run(Instrumentation.java:1701)
C  261.014s Main  Caused by: junit.framework.AssertionFailedError: Timeout: the dictionary hasn't been added after waiting for 20 seconds
C  261.014s Main  	at junit.framework.Assert.fail(Assert.java:50)
C  261.014s Main  	at org.chromium.net.SdchObserver.a(SdchObserver.java:60)
C  261.014s Main  	at org.chromium.net.SdchTest.testSdchEnabled(SdchTest.java:102)
C  261.014s Main  	at java.lang.reflect.Method.invokeNative(Native Method)
C  261.014s Main  	at java.lang.reflect.Method.invoke(Method.java:515)
C  261.015s Main  	at org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:50)
C  261.015s Main  	at org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12)
C  261.015s Main  	at org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:52)
C  261.015s Main  	at org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:17)
C  261.015s Main  	at org.chromium.base.test.ScreenshotOnFailureStatement.evaluate(ScreenshotOnFailureStatement.java:37)
C  261.015s Main  	at org.junit.internal.runners.statements.RunAfters.evaluate(RunAfters.java:27)
C  261.015s Main  	at org.chromium.net.u.a(CronetTestRule.java:1148)
C  261.015s Main  	... 27 more
 
Thanks for filing the bug! Since we are getting rid of the code in a few weeks, would you mind disable that test in the meanwhile?

Comment 2 by mge...@chromium.org, Aug 30 2017

Owner: mge...@chromium.org
Status: Assigned (was: Untriaged)
Sure.
Project Member

Comment 3 by bugdroid1@chromium.org, Aug 30 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/28f6b8102b883c35e4bcf47450977bd64b27c519

commit 28f6b8102b883c35e4bcf47450977bd64b27c519
Author: Miriam Gershenson <mgersh@chromium.org>
Date: Wed Aug 30 19:20:15 2017

Disable SdchTest#testSdchEnabled

It's flaky, and the code will be deleted in a few weeks.

Bug:  760655 
Cq-Include-Trybots: master.tryserver.chromium.android:android_cronet_tester
Change-Id: Icdced96aa319916ab8ccd50d003a8e687a2a1c1e
Reviewed-on: https://chromium-review.googlesource.com/643342
Reviewed-by: Helen Li <xunjieli@chromium.org>
Commit-Queue: Miriam Gershenson <mgersh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#498564}
[modify] https://crrev.com/28f6b8102b883c35e4bcf47450977bd64b27c519/components/cronet/android/test/javatests/src/org/chromium/net/SdchTest.java

Comment 4 by mge...@chromium.org, Aug 30 2017

Status: Fixed (was: Assigned)

Sign in to add a comment