New issue
Advanced search Search tips

Issue 760615 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Sep 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 2
Type: Bug


Sign in to add a comment

Roll Clang again

Project Member Reported by h...@chromium.org, Aug 30 2017

Issue description

Comment 1 by h...@chromium.org, Aug 30 2017

Should we keep rnk's local patch in this roll?

Comment 2 by r...@chromium.org, Aug 30 2017

I think we should drop the instcombine patch for now. If we want it, let's get it upstream under an -mllvm flag.

Comment 3 by thakis@chromium.org, Aug 30 2017

Agreed.

I'd be cool if we could wait for my -Wdelete-non-virtual-dtor cl too, should make it in today.
Blocking: 755213

Comment 5 by thakis@chromium.org, Aug 30 2017

Blocking: 673171

Comment 6 by h...@chromium.org, Aug 30 2017

Comment 7 by h...@chromium.org, Aug 30 2017

Blockedon: 760725

Comment 8 by h...@chromium.org, Aug 30 2017

Comment 9 by h...@chromium.org, Aug 30 2017

Blockedon: 760768

Comment 11 by h...@chromium.org, Aug 30 2017

The bots are pretty red, but I think most of the issues are accounted for, and the Win redness is due to the  crbug.com/673171  work.

Started packaging here, but I probably won't be around to see it finish tonight: https://chromium-review.googlesource.com/c/chromium/src/+/644095

Comment 12 by h...@chromium.org, Sep 1 2017

Status: Started (was: Assigned)
Tryjobs: https://chromium-review.googlesource.com/c/chromium/src/+/644095
Can we get r312583 in this roll?  It should fix the PDB size issue.

Comment 14 by h...@chromium.org, Sep 5 2017

Blockedon: 762156

Comment 15 by r...@chromium.org, Sep 6 2017

Blocking: 755611
Blocking: 761850

Comment 18 by h...@chromium.org, Sep 7 2017

Goma is ready; running tryjobs.
Project Member

Comment 19 by bugdroid1@chromium.org, Sep 8 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/01f121e242233f5fbbe2669d5d10df6fc0682949

commit 01f121e242233f5fbbe2669d5d10df6fc0682949
Author: Hans Wennborg <hans@chromium.org>
Date: Fri Sep 08 16:45:43 2017

Roll Clang 310694-2:312679

And remove the local patch.

Bug:  760615 , 755611 
Change-Id: Id131f345bdc7d30bbec00e22c562f2662e8bf7ed
Reviewed-on: https://chromium-review.googlesource.com/656062
Reviewed-by: Zachary Turner <zturner@chromium.org>
Commit-Queue: Hans Wennborg <hans@chromium.org>
Cr-Commit-Position: refs/heads/master@{#500608}
[delete] https://crrev.com/71a5f211c38e0f318896ea1492e5dbd82f176ec1/tools/clang/scripts/InstructionCombining.cpp
[modify] https://crrev.com/01f121e242233f5fbbe2669d5d10df6fc0682949/tools/clang/scripts/update.py

Comment 20 by h...@chromium.org, Sep 8 2017

Status: Fixed (was: Started)
It seems to be sticking.

Comment 21 by h...@chromium.org, Oct 13 2017

Blocking: -756153

Sign in to add a comment