New issue
Advanced search Search tips

Issue 760597 link

Starred by 1 user

Issue metadata

Status: Unconfirmed
Owner: ----
Components:
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: 2
Type: Bug



Sign in to add a comment

SSLClientCertificateSelectorMultiTabTest.SelectSecond and CeficateSelectorTest.GetSelectedCert fail when NumLock is On. And pass otherwise

Reported by zy...@yandex-team.ru, Aug 30 2017

Issue description

UserAgent: Mozilla/5.0 (Windows NT 6.1; WOW64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/60.0.3112.90 YaBrowser/17.9.1.215 Yowser/2.5 Safari/537.36

Steps to reproduce the problem:
1. Turn NumLock on.
2. Run interactive_ui_tests --gtest_filter="*SSLClientCertificateSelectorMultiTabTest.SelectSecond*:*GetSelectedCert*"  
2. Both tests fail.
3. Turn NumLock off. Re-run the same tests - they pass.

What is the expected behavior?
Both tests pass regardless NumLock status.

What went wrong?
Both tests fail with NumLock on.

Did this work before? No 

Does this work in other browsers? Yes

Chrome version: 60.0.3112.90  Channel: n/a
OS Version: 6.1 (Windows 7, Windows Server 2008 R2)
Flash Version: Shockwave Flash 26.0 r0

Proposed fix: https://chromium-review.googlesource.com/c/chromium/src/+/636963
 

Comment 1 by mmenke@chromium.org, Aug 30 2017

Components: Internals>Network>Certificate Internals>Views
Not sure who owns this code.  Lives in chrome/browser/ui/views/.

Comment 2 Deleted

These tests are only an examples. The real issue orgin is here: ui/base/test/ui_controls_internal_win.cc
Components: -Internals>Views -Internals>Network>Certificate Tests
This issue is tracking a code defect in test utilities, so "Tests" component should be sufficient.
Project Member

Comment 5 by bugdroid1@chromium.org, Sep 6 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/56474764e7f860cc484aeec4f74d313875e2e975

commit 56474764e7f860cc484aeec4f74d313875e2e975
Author: Zinovy Nis <zynis@yandex-team.ru>
Date: Wed Sep 06 18:28:52 2017

[WIN] Fix for SendKeyPress* sending VKEY_NUMPAD* when NumLock is on.

When NumLock is on, SendKeyPress* sends VKEY_NUMPAD* instead of
VKEY_UP/DOWN/HOME/END/... due to incorrect VKEY->ScanCode mapping.

It affects many tests, for example
SSLClientCertificateSelectorMultiTabTest.SelectSecond and
CeficateSelectorTest.GetSelectedCert. Both tests fail with
NumLock turned ON and pass with OFF.

Bug:  chromium:760597

Change-Id: I047fb536390b9a385373f4f5e9202f6287923fcd
Reviewed-on: https://chromium-review.googlesource.com/636963
Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: Zijie He <zijiehe@chromium.org>
Commit-Queue: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#500013}
[modify] https://crrev.com/56474764e7f860cc484aeec4f74d313875e2e975/ui/base/test/ui_controls_internal_win.cc

Labels: TE-NeedsTriageHelp
Unable to triage this issue from TE-End, hence adding "TE-NeedsTriageHelp" label for further triage.
Labels: -Hotlist-Interop

Sign in to add a comment