New issue
Advanced search Search tips

Issue 760581 link

Starred by 1 user
Status: Fixed
Owner:
toyoshim@chromium.org
Closed: Sep 2017
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

ResourceFetcherTests fail on Mojo Linux FYI bot

Project Member Reported by falken@chromium.org, Aug 30 2017 
Failing tests:
 ResourceFetcherTests.ResourceFetcherTimeout
 ResourceFetcherTests.ResourceFetcherDeletedInCallback

Likely caused by https://chromium-review.googlesource.com/c/chromium/src/+/635703

Example build: https://build.chromium.org/p/chromium.fyi/builders/Mojo%20Linux/builds/4764

0830/051037.853649:ERROR:kill_posix.cc(83)] Unable to terminate process group 23372: No such process (3)
[ RUN      ] ResourceFetcherTests.ResourceFetcherTimeout
Xlib:  extension "RANDR" missing on display ":99".
DevTools listening on ws://127.0.0.1:43722/devtools/browser/ce2af3e4-4c29-4338-9e63-c6f25821c19d
[23372:23472:0830/051032.564640:13292441470:WARNING:histograms.cc(40)] Started multiple compositor clients (Browser, Renderer) in one process. Some metrics will be disabled.
../../content/renderer/fetchers/resource_fetcher_browsertest.cc:86: Failure
Failed
fetch timed out
../../content/renderer/fetchers/resource_fetcher_browsertest.cc:230: Failure
Value of: delegate->completed()
  Actual: false
Expected: true
../../content/renderer/fetchers/resource_fetcher_browsertest.cc:233: Failure
Value of: delegate->timed_out()
  Actual: true
Expected: false
[  FAILED  ] ResourceFetcherTests.ResourceFetcherTimeout, where TypeParam =  and GetParam() =  (5279 ms)
[1672/1906] ResourceFetcherTests.ResourceFetcherTimeout (5503 ms)
[0830/051037.894163:ERROR:kill_posix.cc(83)] Unable to terminate process group 23379: No such process (3)
[ RUN      ] ResourceFetcherTests.ResourceFetcherDeletedInCallback
Xlib:  extension "RANDR" missing on display ":99".
DevTools listening on ws://127.0.0.1:35429/devtools/browser/070694b5-b5ac-4ea1-854e-27fe90646760
[23379:23478:0830/051032.579197:13292456028:WARNING:histograms.cc(40)] Started multiple compositor clients (Browser, Renderer) in one process. Some metrics will be disabled.
../../content/renderer/fetchers/resource_fetcher_browsertest.cc:86: Failure
Failed
fetch timed out
../../content/renderer/fetchers/resource_fetcher_browsertest.cc:248: Failure
Value of: delegate->timed_out()
  Actual: true
Expected: false
[  FAILED  ] ResourceFetcherTests.ResourceFetcherDeletedInCallback, where TypeParam =  and GetParam() =  (5235 ms)

Comment 1 by falken@chromium.org, Aug 30 2017

Description: Show this description

Comment 2 Deleted

Project Member

Comment 3 by bugdroid1@chromium.org, Aug 30 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a6c541ffba71dd88f3a66aed965501a1e581e912

commit a6c541ffba71dd88f3a66aed965501a1e581e912
Author: Matt Falkenhagen <falken@chromium.org>
Date: Wed Aug 30 14:57:34 2017

NetworkService: Suppress two failing ResourceFetcherTests

-ResourceFetcherTests.ResourceFetcherTimeout
-ResourceFetcherTests.ResourceFetcherDeletedInCallback

Regressed with r498421, filed a bug and suppressing in the meantime.

NOTRY=true

Bug:  760581 
Change-Id: I5292d7f0eef2a6af576e705c5d5cf92fa8cda842
TBR: toyoshim
Reviewed-on: https://chromium-review.googlesource.com/643248
Commit-Queue: John Abd-El-Malek <jam@chromium.org>
Reviewed-by: Matt Falkenhagen <falken@chromium.org>
Reviewed-by: Takashi Toyoshima <toyoshim@chromium.org>
Cr-Commit-Position: refs/heads/master@{#498461}
[modify] https://crrev.com/a6c541ffba71dd88f3a66aed965501a1e581e912/testing/buildbot/filters/mojo.fyi.network_content_browsertests.filter
Project Member

Comment 4 by bugdroid1@chromium.org, Sep 5 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5b6a55fadbb408cc4468cded3aa6bacf622aa803

commit 5b6a55fadbb408cc4468cded3aa6bacf622aa803
Author: Takashi Toyoshima <toyoshim@chromium.org>
Date: Tue Sep 05 11:14:24 2017

ResourceFetcherImpl: explicitly complete the request on cancellation

With NetworkService is enabled, OnComplete is not called on resetting
the URLLoader. This patch changes to set |completed_| even on Cancel(),
and do nothing if OnComplete() is called after the Cancel() call.

Bug:  760581 
Change-Id: I7250a9741b281edd0a4926146ed4fb8d9aba0d14
Reviewed-on: https://chromium-review.googlesource.com/645326
Commit-Queue: Takashi Toyoshima <toyoshim@chromium.org>
Reviewed-by: Matt Falkenhagen <falken@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Cr-Commit-Position: refs/heads/master@{#499602}
[modify] https://crrev.com/5b6a55fadbb408cc4468cded3aa6bacf622aa803/content/public/renderer/resource_fetcher.h
[modify] https://crrev.com/5b6a55fadbb408cc4468cded3aa6bacf622aa803/content/renderer/fetchers/resource_fetcher_impl.cc
[modify] https://crrev.com/5b6a55fadbb408cc4468cded3aa6bacf622aa803/testing/buildbot/filters/mojo.fyi.network_content_browsertests.filter

Comment 5 by toyoshim@chromium.org, Sep 5 2017

Status: Fixed (was: Assigned)
Project Member

Comment 6 by bugdroid1@chromium.org, Sep 7 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/beba93274f63489bf938398bde1af649c72985d6

commit beba93274f63489bf938398bde1af649c72985d6
Author: Takashi Toyoshima <toyoshim@chromium.org>
Date: Thu Sep 07 06:27:14 2017

Cleanup content::ResourceFetcher interface a little

This patch adopts following two cleanups.

 1. Remove Cancel() interface
 2. Change Create() to Return a std::unique_ptr<> rather than a raw pointer

The interface of Cancel() was a little confusing because it was expected
to be called by users, but its callback is still invoked. This is
unusual design in loading code, but it's common that just destructing instance
results in aborting, and callback is just ignored. Since there is no
caller of this interface today, this patch just removes the interface.

Create() returned a raw pointer as other legacy code does. But today
using std::unique_ptr<> is very common. With this change, we do not need
to explicitly explain about its ownership as a comment.

TBR=mmenke@chromium.org

Bug:  760581 
Change-Id: Ifa00628aaf765aae4b97a53a7c8befd7381af42c
Reviewed-on: https://chromium-review.googlesource.com/650231
Commit-Queue: Takashi Toyoshima <toyoshim@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: Yutaka Hirano <yhirano@chromium.org>
Cr-Commit-Position: refs/heads/master@{#500234}
[modify] https://crrev.com/beba93274f63489bf938398bde1af649c72985d6/chrome/renderer/net/net_error_helper.cc
[modify] https://crrev.com/beba93274f63489bf938398bde1af649c72985d6/content/public/renderer/resource_fetcher.h
[modify] https://crrev.com/beba93274f63489bf938398bde1af649c72985d6/content/renderer/fetchers/resource_fetcher_impl.cc
[modify] https://crrev.com/beba93274f63489bf938398bde1af649c72985d6/content/renderer/fetchers/resource_fetcher_impl.h
[modify] https://crrev.com/beba93274f63489bf938398bde1af649c72985d6/content/renderer/mojo_context_state.cc

Comment 7 by toyoshim@chromium.org, Sep 7 2017 

Oops, the last commit had a wrong bug id. It should be for 752028.
►

Sign in to add a comment