New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 760564 link

Starred by 3 users

Issue metadata

Status: WontFix
Owner:
Closed: Aug 2017
Cc:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug-Regression



Sign in to add a comment

7.3% regression in thread_times.tough_scrolling_cases at 497683:497687

Project Member Reported by pmeenan@chromium.org, Aug 30 2017

Issue description

See the link to graphs below.
 
Project Member

Comment 1 by 42576172...@developer.gserviceaccount.com, Aug 30 2017

All graphs for this bug:
  https://chromeperf.appspot.com/group_report?bug_id=760564

(For debugging:) Original alerts at time of bug-filing:
  https://chromeperf.appspot.com/group_report?sid=29f3b2953752b5069414394fa2ac11c955c7f28c9ac2bedcfecc5cf70c91467e


Bot(s) for this bug's original alert(s):

chromium-rel-win7-gpu-intel
Project Member

Comment 3 by 42576172...@developer.gserviceaccount.com, Aug 30 2017

Cc: brucedaw...@chromium.org
Owner: brucedaw...@chromium.org
Status: Assigned (was: Untriaged)

=== Auto-CCing suspected CL author brucedawson@chromium.org ===

Hi brucedawson@chromium.org, the bisect results pointed to your CL, please take a look at the
results.


=== BISECT JOB RESULTS ===
Perf regression found with culprit

Suspected Commit
  Author : Bruce Dawson
  Commit : 43b6c849b3c49f71261a71fcb40455d0e263c49d
  Date   : Mon Aug 28 01:12:50 2017
  Subject: Revert "Change default VC++ compiler from 2015 to 2017"

Bisect Details
  Configuration: winx64intel_perf_bisect
  Benchmark    : thread_times.tough_scrolling_cases
  Metric       : thread_raster_cpu_time_per_frame/canvas_60000_pixels_per_second
  Change       : 8.20% | 1.62107236025 -> 1.75398291925

Revision             Result                    N
chromium@497682      1.62107 +- 0.0429631      6      good
chromium@497683      1.62117 +- 0.0440703      6      good
chromium@497684      1.78151 +- 0.0737482      6      bad       <--
chromium@497685      1.74462 +- 0.0191344      6      bad
chromium@497687      1.75398 +- 0.093162       6      bad

To Run This Test
  src/tools/perf/run_benchmark -v --browser=release_x64 --output-format=chartjson --upload-results --pageset-repeat=1 --also-run-disabled-tests --story-filter=canvas.60000.pixels.per.second thread_times.tough_scrolling_cases

More information on addressing performance regressions:
  http://g.co/ChromePerformanceRegressions

Debug information about this bisect:
  https://chromeperf.appspot.com/buildbucket_job_status/8969831237575660736


For feedback, file a bug with component Speed>Bisection
Project Member

Comment 4 by 42576172...@developer.gserviceaccount.com, Aug 30 2017

Cc: hablich@chromium.org
 Issue 760559  has been merged into this issue.
Status: WontFix (was: Assigned)
The culprit change in this case was reverting back to VC++ 2015. That means that changing to VC++ 2017 caused improved performance. Therefore this is a nice 7.3% improvement that we can look forward to. I'm going to close as Won't Fix and link to this from the master VS 2017 bug (683729).
Cc: briander...@chromium.org
 Issue 762212  has been merged into this issue.
 Issue 762211  has been merged into this issue.
 Issue 762202  has been merged into this issue.

Sign in to add a comment