Issue metadata
Sign in to add a comment
|
On interstitials page, toolbar menu use previous page URL |
||||||||||||||||||||
Issue descriptionApp Version (from "Chrome Settings > About Chrome"): 62.0.3200.0 iOS Version: 11 (likely other) Device: iPhone Steps to reproduce: 1. Visit a webpage (https://www.google.com) 2. Visit a page with bad ssl (e.g. https://expired.badssl.com) 3. Open menu 4. Bookmark page Observed behavior: Bookmark is added to URL in 1 Expected behavior: Bookmark is added to URL in 2 Frequency: 5/5 Additional comments: Can reproduce in Stable. Share menu availability is also depending on URL in one (unavailable if it is NTP, available on other URLs).
,
Aug 30 2017
Omnibox has always displayed the visible NavigationItem's virtual URL; this did not change during my refactor. Sending to danyao since she's being refactoring navigation; this regression might be caused by one of her CLs. Olvier, can you clarify about what you're referring to in the last line of your original post about the share menu? This actually *is* one of the places that I touched while getting rid of |-currentURL|.
,
Aug 30 2017
Share menu is not available on NTP. The share icon is disabled. If you are an interstitial, icon is disabled if previous URL is NTP, enabled if it is not. If you actually share the page, the URL shared is the one from the interstitial. (https://expired.badssl.com in the example)
,
Aug 30 2017
This is a regression between M59 and M60. I don't think the recent refactor would have affected this since M60 was branched on May 26, before the refactor work started.
,
Aug 30 2017
The share icon may be a separate issue from bookmark. The share icon seems to be a regression from M60 to M62. How does the toolbar get the URL? Does it use Navigation Manager API? It could be that it's asking for the last committed item instead of visible item. We'd be looking at two separate code changes because the bookmark regression and share icon regression happened in different releases.
,
Sep 5 2017
Over to Mohammed for navigation
,
Sep 5 2017
Kurt, are you sure this regression is not caused by https://codereview.chromium.org/2816203002/patch/1/10001 ? Does anyone see any indication than navigation code works incorrectly?
,
Sep 27
This is still reproducing. If site 1) google.com is already bookmarked, whenever you navigate to site 2)badssl... you will get Edit Bookmark -> google.com.
,
Sep 27
Kurt, PTAL at comment #7 |
|||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||
Comment 1 by jif@chromium.org
, Aug 30 2017Components: -UI>Browser>Toolbar -UI>Browser>Interstitials UI>Browser>TabContents
Owner: kkhorimoto@chromium.org