Issue metadata
Sign in to add a comment
|
Regression: Screen goes black after clicking on Dark screen option from chromevox menu |
||||||||||||||||||||||||
Issue descriptionChrome Version: 62.0.3199.0/9892.0.0 dv-channel Daisy,Kip and Minnie OS: Chrome Steps to Reproduce: 1. Enable chromevox and click on chromevox icon from top menu bar 2. From Chromevox tab click on dark screen and observe Expected: On clicking brightness button screen should comeback to readable view Actual: Instead screen becomes blank and only way to come back is restart of machine. This is a regression issue as same is working fine in 61.0.3136.5/9672.0.0. Issue is not seen with linux and windows
,
Aug 30 2017
No idea about this one, we should bisect.
,
Oct 13 2017
Any update on this bug? We are going for a stable RC next week and this is marked as a blocker. Whom is the right owner here?
,
Oct 18 2017
Any update on this one? We are planning to build a R62 stable RC the evening of the 19th, so we would need to have all fixes merged back to 62 in ~24 hours.
,
Oct 19 2017
Bisect would be appreciated, otherwise assigning to David.
,
Oct 20 2017
I did some bisecting and I think 9765.0.0 introduced this, I took a look at the CLs and I thought crrev.com/c/580667 may be related to this problem, +derat@ can you take a look please?
,
Oct 20 2017
#6: That change was a fix for a bug where powerd would stop honoring a still-active request to force the display off. If this was a side effect, the root cause of the problem is elsewhere. I think this is the Chromevox feature tracked at issue 625741 . David is probably the right person to answer questions about how users are supposed to turn the screen back on. Note that the API used by Chromevox is calling the SetBacklightsForcedOff, so the screen won't turn back on unless that method is called again to stop forcing the backlights off. There's some more discussion in issue 760730 .
,
Oct 20 2017
To be clear, this is the way the feature is supposed to work. Similar features on iOS screen curtain: https://www.youtube.com/watch?v=3JySEFcjks0 Android: dim screen https://support.google.com/accessibility/android/answer/6006589?hl=en These features are independent of system brightness settings. If on Chrome OS, we were actually turning back on the screen again when brightness keys were pressed, then that's unintended. To mitigate non-ChromeVox users turning on the darken screen feature, we removed the menu options but left the keyboard shortcuts. Note that turning off ChromeVox *should* turn back on the screen.
,
Oct 20 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/fcbf4d7f59919810aa9be44cdf0660f5b5e8492b commit fcbf4d7f59919810aa9be44cdf0660f5b5e8492b Author: David Tseng <dtseng@chromium.org> Date: Fri Oct 20 17:53:13 2017 Remove darken and undarken screen from chromeVox menus Bug: 760499 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: Ic2b48fee1d9e31a8e44123102676df1027653be4 Reviewed-on: https://chromium-review.googlesource.com/728939 Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org> Commit-Queue: David Tseng <dtseng@chromium.org> Cr-Commit-Position: refs/heads/master@{#510483} [modify] https://crrev.com/fcbf4d7f59919810aa9be44cdf0660f5b5e8492b/chrome/browser/resources/chromeos/chromevox/common/command_store.js
,
Oct 23 2017
Should we merge this back to 63/62? Consider this merge approved if so. We build the R62 stable RC tomorrow, we need a fix in the next 24 hours.
,
Oct 24 2017
If we want this change, can we merge it today?
,
Oct 24 2017
I don't think this is a release blocker in any case. Thanks!
,
Oct 24 2017
SGTM, removing RBS, thanks!
,
Oct 27 2017
This issue has been approved for a merge. Please merge the fix to any appropriate branches as soon as possible! If all merges have been completed, please remove any remaining Merge-Approved labels from this issue. Thanks for your time! To disable nags, add the Disable-Nags label. For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Oct 30 2017
This issue has been approved for a merge. Please merge the fix to any appropriate branches as soon as possible! If all merges have been completed, please remove any remaining Merge-Approved labels from this issue. Thanks for your time! To disable nags, add the Disable-Nags label. For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Dec 11 2017
This issue hasn't been updated in the last 6 weeks, so removing its merge approval label. Please re-request a merge if needed. For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Dec 11 2017
Too late to merge into M63. |
|||||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||||
Comment 1 by mmanchala@chromium.org
, Aug 30 2017Labels: ReleaseBlock-Stable
Owner: dmazz...@chromium.org
Status: Assigned (was: Unconfirmed)
Summary: Regression: Screen goes black after clicking on Dark screen option from chromevox menu (was: Regression: Screen goes blck after clicking on dark screen option from chromevox menu)
15.7 MB
15.7 MB Download
14.5 MB
14.5 MB View Download