New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 760495 link

Starred by 1 user
Status: Assigned
Owner:
█ dgn@chromium.org
Not on Chrome anymore
Cc:
twelling...@chromium.org
mvanouwe...@chromium.org
huayinz@chromium.org
█ ramyan@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 3
Type: Task



Sign in to add a comment

Unify tile generation code across home, bookmarks, recents etc

Project Member Reported by dgn@chromium.org, Aug 30 2017 
They currently use RoundedIconGenerator on their own, but it probably would be better to all rely on some sort of SiteIconGenerator that would deduplicate more things and make sure we have a consistent UI everywhere (e.g. avoid issue 760088).

It looks like the only parameterization there would be the desired icon size (and a context), the rest should be same across surfaces.

Comment 1 by mvanouwe...@chromium.org, Aug 30 2017

Components: UI>Browser>NewTabPage
Labels: zine-triaged
Sounds like a nice cleanup. Note that issue 760088 seems to specify square scrabble tiles, so maybe we need a param for corner radius or simply a boolean for square vs round.

Comment 2 by dgn@chromium.org, Aug 30 2017 

It could just rely on whether we are using modern style? Then adjust the corner radius depending on the requested tile size?

Comment 3 by twelling...@chromium.org, Aug 30 2017 

+1 to unifying home, bookmarks and history (and anything else displaying favicons). We could certainly rely on #isChromeHomeModernEnabled() to determine whether the corner radius needs to be adjusted.
►

Sign in to add a comment