Duplicated selectors 'textFieldConfigs' and 'buttonConfigs' in class TestDialogMediator |
||
Issue descriptionWhen building ios_clean_chrome_unittests, I get the following warning: ld: warning: instance method 'textFieldConfigs' in category from ios_clang_x86/obj/ios/clean/chrome/browser/ui/dialogs/test_helpers/test_helpers/test_dialog_mediator.o overrides method from class in ios_clang_x86/obj/ios/clean/chrome/browser/ui/dialogs/test_helpers/test_helpers/test_dialog_mediator.o ld: warning: instance method 'buttonConfigs' in category from ios_clang_x86/obj/ios/clean/chrome/browser/ui/dialogs/test_helpers/test_helpers/test_dialog_mediator.o overrides method from class in ios_clang_x86/obj/ios/clean/chrome/browser/ui/dialogs/test_helpers/test_helpers/test_dialog_mediator.o I think this is because the property are both @synthesize and have an explicit getter (because they are inherited). I think the @synthesize needs to be removed.
,
Aug 31 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/3174e6f68077dd3e89f63993473f6647b57c763c commit 3174e6f68077dd3e89f63993473f6647b57c763c Author: Kurt Horimoto <kkhorimoto@chromium.org> Date: Thu Aug 31 13:07:33 2017 [iOS Clean] Fix compiler warning for TestDialogMediator. The getter in the category implementation overrode the synthesized getter. Bug: 760494 Change-Id: I25825d31169fd54cbf081600e7a6a17aafbeae64 Reviewed-on: https://chromium-review.googlesource.com/643792 Reviewed-by: Sylvain Defresne <sdefresne@chromium.org> Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Cr-Commit-Position: refs/heads/master@{#498836} [modify] https://crrev.com/3174e6f68077dd3e89f63993473f6647b57c763c/ios/clean/chrome/browser/ui/dialogs/dialog_mediator_unittest.mm [modify] https://crrev.com/3174e6f68077dd3e89f63993473f6647b57c763c/ios/clean/chrome/browser/ui/dialogs/test_helpers/test_dialog_mediator.h [modify] https://crrev.com/3174e6f68077dd3e89f63993473f6647b57c763c/ios/clean/chrome/browser/ui/dialogs/test_helpers/test_dialog_mediator.mm
,
Aug 31 2017
|
||
►
Sign in to add a comment |
||
Comment 1 by kkhorimoto@chromium.org
, Aug 30 2017