Issue metadata
Sign in to add a comment
|
Regression : Tab Focus is seen missing on Checkbox at 'Optional' text in EULA screen |
||||||||||||||||||||||
Issue descriptionChrome Version: 62.0.3199.0/9892.0.0 dv-channel Daisy,Kip and Minnie OS: Chrome What steps will reproduce the problem? (1)Recover build -> In OOBE screen click on "Let's go" > In 'Connect to Network' screen Connect to any Wi-Fi network (2)Now in EULA screen press 'Tab' button until focus reaches to Checkbox at 'Optional' text and Observe focus is seen missing and on clicking 'Enter' button blue trace is seen (Please refer video and Screenshot) Expected: Focus should be seen on Checkbox at 'Optional' text and on clicking 'Enter' button no such blue trace should be seen Actual: Instead focus is seen missing on Checkbox at 'Optional' text and on clicking 'Enter' button blue trace is seen This is Regression Issue as same is working fine for 62.0.3193.0/9869.0.0 dev-channel Kip @alemate : Please confirm the issue
,
Sep 7 2017
It is actually focused. Here are three screenshots with all the possible states. https://screenshot.googleplex.com/ki9vAJYZ6K8.png https://screenshot.googleplex.com/TPWKOfD0Bj3.png https://screenshot.googleplex.com/PKQPNsTAqOZ.png We need UI decision on how to display focusing of this checkbox.
,
Sep 8 2017
,
Sep 18 2017
,
Sep 18 2017
Please use the same treatment as the one in the expected focus video. It should be already built in.
,
Sep 25 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/9cb8fa9df0db7a0d55950527766d7227c7c8d23e commit 9cb8fa9df0db7a0d55950527766d7227c7c8d23e Author: Alexander Alekseev <alemate@chromium.org> Date: Mon Sep 25 20:23:23 2017 Chrome OS EULA screen: update focus ring size. Bug: 760490 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I2e0046a02ad521fdf060e2677ae7d657a602a3d0 Reviewed-on: https://chromium-review.googlesource.com/682154 Reviewed-by: Wenzhao (Colin) Zang <wzang@chromium.org> Commit-Queue: Alexander Alekseev <alemate@chromium.org> Cr-Commit-Position: refs/heads/master@{#504150} [modify] https://crrev.com/9cb8fa9df0db7a0d55950527766d7227c7c8d23e/chrome/browser/resources/chromeos/login/oobe_eula.css
,
Sep 25 2017
,
Sep 26 2017
,
Sep 27 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/d4740bd0a540486f46022e5bc13f85a7f367f319 commit d4740bd0a540486f46022e5bc13f85a7f367f319 Author: Alexander Alekseev <alemate@chromium.org> Date: Wed Sep 27 13:16:54 2017 Chrome OS EULA screen: update focus ring size. TBR=alemate@chromium.org (cherry picked from commit 9cb8fa9df0db7a0d55950527766d7227c7c8d23e) Bug: 760490 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I2e0046a02ad521fdf060e2677ae7d657a602a3d0 Reviewed-on: https://chromium-review.googlesource.com/682154 Reviewed-by: Wenzhao (Colin) Zang <wzang@chromium.org> Commit-Queue: Alexander Alekseev <alemate@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#504150} Reviewed-on: https://chromium-review.googlesource.com/686835 Reviewed-by: Alexander Alekseev <alemate@chromium.org> Cr-Commit-Position: refs/branch-heads/3202@{#467} Cr-Branched-From: fa6a5d87adff761bc16afc5498c3f5944c1daa68-refs/heads/master@{#499098} [modify] https://crrev.com/d4740bd0a540486f46022e5bc13f85a7f367f319/chrome/browser/resources/chromeos/login/oobe_eula.css |
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by kochi@chromium.org
, Aug 30 2017