Chrome Version : 62.0.3199.0 OS Version: 9889.0.0 Steps to reproduce: - Go to https://storage.googleapis.com/media-session/caminandes/short.mp4 - Video element should be centered vertically and horizontally (Chrome Stable does that) What happens instead: Video element is placed at the top left corner of the page. Please let's fix this! It looks like it is due to https://bugs.chromium.org/p/chromium/issues/detail?id=672539#c6 And worst, if you go to https://storage.googleapis.com/media-session/sintel/snow-fight.mp3, there's no element displayed anymore ;(
CL here: https://chromium-review.googlesource.com/c/chromium/src/+/646526
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/f628f1cfaf8aa160417049718324d6c2023142f7 commit f628f1cfaf8aa160417049718324d6c2023142f7 Author: Min Qin <qinmin@chromium.org> Date: Fri Sep 01 07:40:18 2017 Fix media element position on MediaDocument The element should be centered Adding back media/media-document-audio-repaint.html which is accidentally removed. And rebaseline the text expectation so it can capture future regressions. BUG= 760484 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: If7fded84745f1a6a04feab9a7b6c3d237b08c301 Reviewed-on: https://chromium-review.googlesource.com/646526 Reviewed-by: Xianzhu Wang <wangxianzhu@chromium.org> Reviewed-by: Mounir Lamouri <mlamouri@chromium.org> Commit-Queue: Min Qin <qinmin@chromium.org> Cr-Commit-Position: refs/heads/master@{#499149} [add] https://crrev.com/f628f1cfaf8aa160417049718324d6c2023142f7/third_party/WebKit/LayoutTests/media/media-document-audio-repaint.html [modify] https://crrev.com/f628f1cfaf8aa160417049718324d6c2023142f7/third_party/WebKit/LayoutTests/platform/linux/media/media-document-audio-repaint-expected.png [modify] https://crrev.com/f628f1cfaf8aa160417049718324d6c2023142f7/third_party/WebKit/LayoutTests/platform/linux/media/media-document-audio-repaint-expected.txt [modify] https://crrev.com/f628f1cfaf8aa160417049718324d6c2023142f7/third_party/WebKit/LayoutTests/platform/mac/media/media-document-audio-repaint-expected.png [modify] https://crrev.com/f628f1cfaf8aa160417049718324d6c2023142f7/third_party/WebKit/LayoutTests/platform/mac/media/media-document-audio-repaint-expected.txt [modify] https://crrev.com/f628f1cfaf8aa160417049718324d6c2023142f7/third_party/WebKit/LayoutTests/platform/win/media/media-document-audio-repaint-expected.png [modify] https://crrev.com/f628f1cfaf8aa160417049718324d6c2023142f7/third_party/WebKit/LayoutTests/platform/win/media/media-document-audio-repaint-expected.txt [delete] https://crrev.com/85b2a0fca5a5721bd32d0dc71d703c9b700b6852/third_party/WebKit/LayoutTests/platform/win7/media/media-document-audio-repaint-expected.png [delete] https://crrev.com/85b2a0fca5a5721bd32d0dc71d703c9b700b6852/third_party/WebKit/LayoutTests/platform/win7/media/media-document-audio-repaint-expected.txt [modify] https://crrev.com/f628f1cfaf8aa160417049718324d6c2023142f7/third_party/WebKit/Source/core/html/media/MediaDocument.cpp [modify] https://crrev.com/f628f1cfaf8aa160417049718324d6c2023142f7/third_party/WebKit/Source/modules/media_controls/resources/mediaControls.css [modify] https://crrev.com/f628f1cfaf8aa160417049718324d6c2023142f7/third_party/WebKit/Source/platform/graphics/paint/PaintController.cpp
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/31058f8f86800d6ce998666cbd9f97dd1d2da459 commit 31058f8f86800d6ce998666cbd9f97dd1d2da459 Author: Min Qin <qinmin@chromium.org> Date: Tue Sep 05 18:37:01 2017 Merge:Fix media element position on MediaDocument The element should be centered Adding back media/media-document-audio-repaint.html which is accidentally removed. And rebaseline the text expectation so it can capture future regressions. BUG= 760484 TBR=wangxianzhu@chromium.org,mlamouri@chromium.org (cherry picked from commit f628f1cfaf8aa160417049718324d6c2023142f7) Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: If7fded84745f1a6a04feab9a7b6c3d237b08c301 Reviewed-on: https://chromium-review.googlesource.com/646526 Reviewed-by: Xianzhu Wang <wangxianzhu@chromium.org> Reviewed-by: Mounir Lamouri <mlamouri@chromium.org> Commit-Queue: Min Qin <qinmin@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#499149} Reviewed-on: https://chromium-review.googlesource.com/650835 Reviewed-by: Min Qin <qinmin@chromium.org> Cr-Commit-Position: refs/branch-heads/3202@{#26} Cr-Branched-From: fa6a5d87adff761bc16afc5498c3f5944c1daa68-refs/heads/master@{#499098} [add] https://crrev.com/31058f8f86800d6ce998666cbd9f97dd1d2da459/third_party/WebKit/LayoutTests/media/media-document-audio-repaint.html [modify] https://crrev.com/31058f8f86800d6ce998666cbd9f97dd1d2da459/third_party/WebKit/LayoutTests/platform/linux/media/media-document-audio-repaint-expected.png [modify] https://crrev.com/31058f8f86800d6ce998666cbd9f97dd1d2da459/third_party/WebKit/LayoutTests/platform/linux/media/media-document-audio-repaint-expected.txt [modify] https://crrev.com/31058f8f86800d6ce998666cbd9f97dd1d2da459/third_party/WebKit/LayoutTests/platform/mac/media/media-document-audio-repaint-expected.png [modify] https://crrev.com/31058f8f86800d6ce998666cbd9f97dd1d2da459/third_party/WebKit/LayoutTests/platform/mac/media/media-document-audio-repaint-expected.txt [modify] https://crrev.com/31058f8f86800d6ce998666cbd9f97dd1d2da459/third_party/WebKit/LayoutTests/platform/win/media/media-document-audio-repaint-expected.png [modify] https://crrev.com/31058f8f86800d6ce998666cbd9f97dd1d2da459/third_party/WebKit/LayoutTests/platform/win/media/media-document-audio-repaint-expected.txt [delete] https://crrev.com/73c7e0387a8920b6916a530f77c848d4ef175590/third_party/WebKit/LayoutTests/platform/win7/media/media-document-audio-repaint-expected.png [delete] https://crrev.com/73c7e0387a8920b6916a530f77c848d4ef175590/third_party/WebKit/LayoutTests/platform/win7/media/media-document-audio-repaint-expected.txt [modify] https://crrev.com/31058f8f86800d6ce998666cbd9f97dd1d2da459/third_party/WebKit/Source/core/html/media/MediaDocument.cpp [modify] https://crrev.com/31058f8f86800d6ce998666cbd9f97dd1d2da459/third_party/WebKit/Source/modules/media_controls/resources/mediaControls.css [modify] https://crrev.com/31058f8f86800d6ce998666cbd9f97dd1d2da459/third_party/WebKit/Source/platform/graphics/paint/PaintController.cpp
Comment 1 by mlamouri@chromium.org
, Aug 30 2017Owner: qin...@chromium.org
Status: Assigned (was: Unconfirmed)