overlord in docker: should not put app in docker shared folder. |
||||
Issue descriptionCurrently Overlord in docker will copy whole app folder into /cros_docker/overlord, because the htpasswd must live in the root folder for http resources. This will make deployment pretty difficult when updating docker images. I think we should only put htpasswd and key files in /cros_docker/overlord, and write a script to (1) mount bind the files to overlord folder (2) start overlord daemon.
,
Aug 30 2017
I think we can pass the path to the htpasswd file as a command line argument instead of finding it in the app directory. If the argument is not specified, we default to the current path (under app).
,
Aug 30 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/platform/factory/+/c1df45fc35877ad06266887a898eda2b2031b3ea commit c1df45fc35877ad06266887a898eda2b2031b3ea Author: Peter Shih <pihsun@chromium.org> Date: Wed Aug 30 17:09:04 2017 overlord: Add argument to set .htpasswd file path. Add a command line argument to set .htpasswd file path other than the default app/overlord.htpasswd. BUG= chromium:760483 TEST=make test TEST=manually Change-Id: I38ca3cf8eaf3157c1223d86aebb641dc5e26f0ba Reviewed-on: https://chromium-review.googlesource.com/643008 Commit-Ready: Pi-Hsun Shih <pihsun@chromium.org> Tested-by: Pi-Hsun Shih <pihsun@chromium.org> Reviewed-by: Wei-Ning Huang <wnhuang@chromium.org> [modify] https://crrev.com/c1df45fc35877ad06266887a898eda2b2031b3ea/go/src/overlord/overlord.go [modify] https://crrev.com/c1df45fc35877ad06266887a898eda2b2031b3ea/go/src/overlord/cmd/overlord_lan_disc/main.go [modify] https://crrev.com/c1df45fc35877ad06266887a898eda2b2031b3ea/Makefile [modify] https://crrev.com/c1df45fc35877ad06266887a898eda2b2031b3ea/go/src/overlord/cmd/overlordd/main.go
,
Aug 31 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/platform/factory/+/2a3d23ed847d86cc23cc036b44ff5fa981d7c5dd commit 2a3d23ed847d86cc23cc036b44ff5fa981d7c5dd Author: Peter Shih <pihsun@chromium.org> Date: Thu Aug 31 05:23:27 2017 Overlord: Don't put app in docker shared folder. Don't put app directory in /cros_docker, so it can be updated with docker image. Some config files (SSL certificate, .htpasswd file) would be put in /cros_docker/overlord/config. BUG= chromium:760483 TEST=make test TEST=manually. Change-Id: I3e4a625171b6661f16b192e234a707169128a9aa Reviewed-on: https://chromium-review.googlesource.com/643009 Commit-Ready: Pi-Hsun Shih <pihsun@chromium.org> Tested-by: Pi-Hsun Shih <pihsun@chromium.org> Reviewed-by: Hung-Te Lin <hungte@chromium.org> Reviewed-by: Wei-Ning Huang <wnhuang@chromium.org> [modify] https://crrev.com/2a3d23ed847d86cc23cc036b44ff5fa981d7c5dd/go/src/overlord/setup.sh [modify] https://crrev.com/2a3d23ed847d86cc23cc036b44ff5fa981d7c5dd/setup/cros_docker.sh
,
Sep 11 2017
,
Jan 22 2018
,
Jan 23 2018
|
||||
►
Sign in to add a comment |
||||
Comment 1 Deleted