Issue metadata
Sign in to add a comment
|
Regression: Close button overlaps with the long username on password bubble |
||||||||||||||||||||||
Issue descriptionChrome Version:62.0.3200.0 OS: Ubuntu 14.04 What steps will reproduce the problem? (1)Launch chrome and open webstore (2)Sign-in with some valid credentials (3)Open the password bubble and edit the username with long text Expected:Close button should not overlap on the long username Actual:Instead, it overlaps This is a Regression issue broken in M-62 will update other info soon..
,
Aug 30 2017
Able to reproduce this issue on Ubuntu 14.04 using chrome latest dev #62.0.3200.0. This issue is not observed on Mac OS 10.12.6.
,
Aug 30 2017
Issue 760505 has been merged into this issue.
,
Aug 30 2017
++Correction Manual Bisect Info: ================== Good Build:62.0.3194.0 Bad Build: 62.0.3196.0
,
Aug 30 2017
Able to reproduce the issue on Windows 7 & Ubuntu 14.04 using chrome latest canary-62.0.3199.0. Manual Bisect Info: ================== Good Build: 62.0.3194.0 _Revision-496533 Bad Build: 62.0.3196.0 _Revision-497279 Per revision bisect info: ------------------------ You are probably looking for a change made after 496975 (known good), but no later than 496976 (first known bad). CHANGELOG URL: The script might not always return single CL as suspectas some perf builds might get missing due to failure. https://chromium.googlesource.com/chromium/src/+log/3244bc11b60f7478fc2adf93d85b21263470f395..9ee7e2b3307a6fc1b67a4365c8b71c4cce914ec1 Suspected CL: ----------- https://chromium.googlesource.com/chromium/src/+/9ee7e2b3307a6fc1b67a4365c8b71c4cce914ec1 Unable to assign to irmakk@ from the above ,hence assigning to the reviewer vasilii@ & cc'd irmakk@ for further investigation. Thanks.!
,
Aug 30 2017
irmakk@, consider the bug assigned to you. brajkumar@, there is no point in reproducing the issue on Mac. It's totally different implementation. Is it really a regression on Linux?
,
Aug 30 2017
vasilii@ Yes it's. Able to reproduce this issue on Linux and Windows.
,
Aug 30 2017
Hi, we are aware of this, see here: crbug.com/758157 Also, I am able to reproduce this in the stable chrome, and my code is not yet in stable chrome as far as I know. When i talked to vasilii@ about this, we've come to the conclusion that it was a long existing bug, which is why I am surprised to hear it is a regression. Will look into it, thanks!
,
Aug 31 2017
Hello again. I have inspected this a little further. Here is a cl from version 62.0.3194.0 (the good build): https://chromium-review.googlesource.com/623669 This cl was merged as crrev.com/2b0a69bac57aa7e1114d147318fab9a4b8e2b91b, so i fetched the version from that commit and i was able to reproduce the bug. (I also am able to reproduce the bug in stable). Therefore, I don't think this is a regression, can we update the label accordingly? :)
,
Nov 6 2017
,
Nov 6 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/ebde979cc2d5fd8956cab9785ad40c276fef4811 commit ebde979cc2d5fd8956cab9785ad40c276fef4811 Author: Vasilii Sukhanov <vasilii@chromium.org> Date: Mon Nov 06 13:49:53 2017 Change the manage passwords bubble to handle overflow better. After https://chromium-review.googlesource.com/c/chromium/src/+/717498 GridLayout respects the minimal width of the column. ManagePasswordItemsView should use the feature instead of conducting layout itself. Bug: 760463 Change-Id: Ib41e68291fd7578bbd4da9eede6cd9bf2064973c Reviewed-on: https://chromium-review.googlesource.com/754834 Reviewed-by: Maxim Kolosovskiy <kolos@chromium.org> Commit-Queue: Vasilii Sukhanov <vasilii@chromium.org> Cr-Commit-Position: refs/heads/master@{#514120} [modify] https://crrev.com/ebde979cc2d5fd8956cab9785ad40c276fef4811/chrome/browser/ui/passwords/manage_passwords_view_utils.h [modify] https://crrev.com/ebde979cc2d5fd8956cab9785ad40c276fef4811/chrome/browser/ui/views/passwords/manage_password_items_view.cc [modify] https://crrev.com/ebde979cc2d5fd8956cab9785ad40c276fef4811/chrome/browser/ui/views/passwords/manage_password_items_view.h [modify] https://crrev.com/ebde979cc2d5fd8956cab9785ad40c276fef4811/chrome/browser/ui/views/passwords/manage_passwords_bubble_view.cc
,
Nov 6 2017
|
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by keerthan...@techmahindra.com
, Aug 30 2017302 KB
302 KB View Download