[DevTools] Grey highlight focus doesn't seen on 'Return to color picker' (X) icon.
Reported by
dchau...@etouch.net,
Aug 30 2017
|
||||
Issue descriptionChrome Version: 61.0.3163.71 (Official Build)6b997a7a08ec6d291101f2966908868ee431ff05-refs/branch-heads/3163@{#980} 32/64-bit. OS: Windows (7,8,8.1,10),Linux (14.04 LTS),Mac OS X(10.11.6,10.12.3). What steps will reproduce the problem? 1. Launch chrome, open DevTools and click to open Color Picker window under Style section. 2. Click on second bidirectional arrow to open 'Color Palettes'. 3. Now, press 'Tab' key from keyboard and observe. 4. Again press 5 times 'Tab' key from keyboard and observe. After step-3: Grey highlight focus doesn't seen on 'Return to color picker' (X) icon. After step-3: Grey focus highlight should seen on 'Return to color picker' (X) icon. Note: After step-4, grey focus highlight is seen on 'Return to color picker' (X) icon. This is a non-regression issue, seen from M-59 series as 'Grey focus highlight' in devtools appears from build # 59.0.3059.0 Kindly review the attached screen-cast for reference.
,
Aug 30 2017
,
Nov 8 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/92ae9b01af0cb9536709df284007e4b1f3d7a533 commit 92ae9b01af0cb9536709df284007e4b1f3d7a533 Author: Erik Luo <luoe@chromium.org> Date: Wed Nov 08 21:47:53 2017 DevTools: allow single tab to close icon in color picker Currently, opening the color palette overlay will cover up other controls in color picker. However, pressing Tab can still focus elements in the background. By hiding the main controls when they are in the background, we can prevent them from stealing focus. Bug: 760458 Change-Id: If3af30976efff860d692100823233b0c5cdc5dfb Reviewed-on: https://chromium-review.googlesource.com/688834 Reviewed-by: Pavel Feldman <pfeldman@chromium.org> Commit-Queue: Erik Luo <luoe@chromium.org> Cr-Commit-Position: refs/heads/master@{#514953} [modify] https://crrev.com/92ae9b01af0cb9536709df284007e4b1f3d7a533/third_party/WebKit/Source/devtools/front_end/color_picker/Spectrum.js [modify] https://crrev.com/92ae9b01af0cb9536709df284007e4b1f3d7a533/third_party/WebKit/Source/devtools/front_end/color_picker/spectrum.css
,
Nov 8 2017
,
Nov 9 2017
Note : Rechecked the above issue on Windows (7,8,8.1,10),Linux (14.04 LTS),Mac OS X(10.12.6) with latest canary chrome version : 64.0.3263.0 and the issue is not reproducible. Kindly refer the attached screen cast for reference. |
||||
►
Sign in to add a comment |
||||
Comment 1 by rbasuvula@chromium.org
, Aug 30 2017