New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 760457 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Sep 2017
Cc:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Chrome , Mac
Pri: 3
Type: Feature

Blocking:
issue 740783



Sign in to add a comment

desktop-pwas: Change context menu strings if inside app

Project Member Reported by ortuno@chromium.org, Aug 30 2017

Issue description

"Open in tab" and "Open in window" aren't clear when in an App context e.g. a Bookmark App. We should change them to be more explicit when in an app window:

Menu items for link to same app:

1. "Open in new [App Name] window"
2. "Open in new Chrome tab"
3. "Open in Chrome incognito window"

Menu items for link to other apps:

1. "Open in [App Name]"
2. "Open in new Chrome tab"
3. "Open in Chrome incognito window"

Menu items for link to regular websites:

1. "Open in new Chrome tab"
2. "Open in Chrome incognito window"


 
to same app.png
38.4 KB View Download
to other app.png
43.3 KB View Download
to regular website.png
41.1 KB View Download
Project Member

Comment 1 by bugdroid1@chromium.org, Sep 11 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/256c413fc87fe8ba5fa2fa61350078dbb1b9f813

commit 256c413fc87fe8ba5fa2fa61350078dbb1b9f813
Author: Giovanni Ortuño Urquidi <ortuno@chromium.org>
Date: Mon Sep 11 05:34:23 2017

desktop-pwas: Change "Open in" strings when inside an app window.

When in an app window:

Menu items for link to same app:

1. "Open in new [App Name] window"
2. "Open in new Chrome tab"
3. "Open in Chrome incognito window"

Menu items for link to other apps:

1. "Open in [App Name]"
2. "Open in new Chrome tab"
3. "Open in Chrome incognito window"

Menu items for link to regular websites:

1. "Open in new Chrome tab"
2. "Open in Chrome incognito window"

Bug:  760457 
Change-Id: I95e1b6c84e62cd9e9c829c508a3707fe5bd0fda4
Reviewed-on: https://chromium-review.googlesource.com/646887
Reviewed-by: Avi Drissman <avi@chromium.org>
Reviewed-by: Matt Giuca <mgiuca@chromium.org>
Commit-Queue: Giovanni Ortuño Urquidi <ortuno@chromium.org>
Cr-Commit-Position: refs/heads/master@{#500842}
[modify] https://crrev.com/256c413fc87fe8ba5fa2fa61350078dbb1b9f813/chrome/app/chromium_strings.grd
[modify] https://crrev.com/256c413fc87fe8ba5fa2fa61350078dbb1b9f813/chrome/app/generated_resources.grd
[modify] https://crrev.com/256c413fc87fe8ba5fa2fa61350078dbb1b9f813/chrome/app/google_chrome_strings.grd
[modify] https://crrev.com/256c413fc87fe8ba5fa2fa61350078dbb1b9f813/chrome/browser/renderer_context_menu/render_view_context_menu.cc
[modify] https://crrev.com/256c413fc87fe8ba5fa2fa61350078dbb1b9f813/chrome/browser/renderer_context_menu/render_view_context_menu.h
[modify] https://crrev.com/256c413fc87fe8ba5fa2fa61350078dbb1b9f813/chrome/browser/renderer_context_menu/render_view_context_menu_browsertest.cc

Comment 2 by ortuno@chromium.org, Sep 11 2017

Status: Fixed (was: Started)

Sign in to add a comment