Issue metadata
Sign in to add a comment
|
Regression:Double focus highlight is seen on 'Take photo','Choose a File' icons in changePicture overlay |
||||||||||||||||||||||
Issue descriptionChrome Version:62.0.3199.0/9892.0.0 dev-channel Daisy,Kip,Minnie OS:Chrome OS What steps will reproduce the problem? (1)Sign in to user ->Launch chrome,goto chrome://settings/changePicture (2)click on Take photo and Observe the focus on it(please refer screenshots attached) Actual:Double focus highlight is seen on 'Take photo','Choose a File' icons Expected:Double focus highlight shouldn't be seen This is a Regression issue as same is working fine in 62.0.3198.0/9887.0.0 dev channel Minnie Note: Issue is not seen in Linux,Windows OS @stevenjb: Please confirm the above issue
,
Aug 30 2017
https://chromium.googlesource.com/chromium/src/+/914e228fdc6106f5a301f715826a9b8313165beb caused this. Can you take a look?
,
Aug 30 2017
hcarmona@ can you please take a look at this issue and merge the fix asap if needed?
,
Aug 31 2017
Looking into this CL coming soon
,
Aug 31 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/66da542bbad774a44e664dd37daba98bc85c40b7 commit 66da542bbad774a44e664dd37daba98bc85c40b7 Author: Hector Carmona <hcarmona@chromium.org> Date: Thu Aug 31 18:35:22 2017 Remove outline from icons in the profile picture chooser. Bug: 760447 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I7cfebbe0d8f98ffa3bad8fff61c2ce1b9e3cab37 Reviewed-on: https://chromium-review.googlesource.com/644714 Reviewed-by: Steven Bennetts <stevenjb@chromium.org> Commit-Queue: Hector Carmona <hcarmona@chromium.org> Cr-Commit-Position: refs/heads/master@{#498928} [modify] https://crrev.com/66da542bbad774a44e664dd37daba98bc85c40b7/ui/webui/resources/cr_elements/chromeos/cr_picture/cr_picture_list.html
,
Aug 31 2017
Issue 753555 is targeted to fix an A11y issue for M61, that issue caused this regression. (Merge Requested, but not yet approved) Fix for this regression is trivial, so requesting merge assuming other issue will be accepted. Consequence of not merging this is extra highlight, merge risk is very low: 1 line of CSS, which is why i'm merge-requesting with out this being on ToT for at least 24 hours. Just to clarify: will only merge if https://crbug.com/753555 is merge approved AND this issue is also merge approved.
,
Aug 31 2017
This bug requires manual review: We are only 4 days from stable. Please contact the milestone owner if you have questions. Owners: amineer@(Android), cmasso@(iOS), ketakid@(ChromeOS), govind@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Aug 31 2017
Approving merge to M61 Chrome OS.
,
Aug 31 2017
,
Aug 31 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/66acf8e56a259fe485e09d79d5dd6f8232cf0932 commit 66acf8e56a259fe485e09d79d5dd6f8232cf0932 Author: Hector Carmona <hcarmona@chromium.org> Date: Thu Aug 31 20:51:24 2017 Remove outline from icons in the profile picture chooser. TBR=hcarmona@chromium.org (cherry picked from commit 66da542bbad774a44e664dd37daba98bc85c40b7) Bug: 760447 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I7cfebbe0d8f98ffa3bad8fff61c2ce1b9e3cab37 Reviewed-on: https://chromium-review.googlesource.com/644714 Reviewed-by: Steven Bennetts <stevenjb@chromium.org> Commit-Queue: Hector Carmona <hcarmona@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#498928} Reviewed-on: https://chromium-review.googlesource.com/646753 Reviewed-by: Hector Carmona <hcarmona@chromium.org> Cr-Commit-Position: refs/branch-heads/3163@{#1045} Cr-Branched-From: ff259bab28b35d242e10186cd63af7ed404fae0d-refs/heads/master@{#488528} [modify] https://crrev.com/66acf8e56a259fe485e09d79d5dd6f8232cf0932/ui/webui/resources/cr_elements/chromeos/cr_picture/cr_picture_list.html
,
Aug 31 2017
,
Jan 22 2018
,
Jan 23 2018
|
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by steve...@chromium.org
, Aug 30 2017Labels: -M-62 M-61
Owner: reve...@chromium.org