This is a serious security regression. If you are not able to fix this quickly, please revert the change that introduced it.

If this doesn't affect a release branch, or has not been properly classified for severity, please update the Security_Impact or Security_Severity labels, and remove the ReleaseBlock label. To disable this altogether, apply ReleaseBlock-NA.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

lukasza: this appears to having started crashing very recently. I see you changed the method where it's crashing; do you mind triaging? I didn't see anything obvious in the regression range that would cause this.

It seems to me that when BlinkTestController::OnAllServiceWorkersCleared is called, the |this| object has already been destroyed (it is wrapped in base::Unretained inside BlinkTestController::OnTestFinished - AFAICT this base::Unretained dates back to r189974 by jochen@).

Given that the problem only affects test code (the crash and the base::Unretained are inside BlinkTestController), I don't think there is any security impact here.

This implies that OnAllServiceWorkersCleared comes in long after the corresponding RenderView is deleted. This should not happen.

ClusterFuzz has detected this issue as fixed in range 502500:502501.

Detailed report: https://clusterfuzz.com/testcase?key=5481438316331008

Fuzzer: inferno_layout_test_unmodified
Job Type: windows_asan_content_shell
Platform Id: windows

Crash Type: Stack-buffer-overflow READ 4
Crash Address: 0x0054e9dc
Crash State:
  content::BlinkTestController::OnAllServiceWorkersCleared
  base::debug::TaskAnnotator::RunTask
  base::MessageLoop::RunTask
  
Sanitizer: address (ASAN)

Recommended Security Severity: Medium

Regressed: https://clusterfuzz.com/revisions?job=windows_asan_content_shell&range=494575:494617
Fixed: https://clusterfuzz.com/revisions?job=windows_asan_content_shell&range=502500:502501

Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=5481438316331008

See https://github.com/google/clusterfuzz-tools for more information.

If you suspect that the result above is incorrect, try re-doing that job on the test case report page.

ClusterFuzz testcase 5481438316331008 is verified as fixed, so closing issue as verified.

If this is incorrect, please add ClusterFuzz-Wrong label and re-open the issue.

This bug has been closed for more than 14 weeks. Removing security view restrictions.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot