Omnibox disappears on opening a content suggestion in new incognito tab and navigating back to normal tab |
|||
Issue descriptionApp Version: 62.0.3199.0 iOS Version: 10.3.3, 11.0 beta 7 Device : iPhones only Precondition : 1- Enable content suggestions. Steps to reproduce: 1. Launch chrome. 2. Scroll the content suggestions. 3. Tap on More link below the content suggestions. 4. Long tap on any link > Tap on open in new incognito tab. 5. Tap on tabswithcer button > Navigate back to normal tab. Scenario 2 : 1. Launch chrome. 2. Scroll the content suggestions. 3. Tap on More link below the content suggestions. 4. Tap on GLIF icon > Dismiss the GLIF screen. Observed results: Omnibox is not displayed in normal tab Expected results: Omnibox should be displayed Number of times you were able to reproduce: 5/5 Bug reproducible after clean install: Yes Bug reproducible after clearing cache and cookies: Yes Bug reproducible on Chrome Mobile on Android: NA Bug reproducible on Safari/Firefox: Firefox: NA, Safari: NA Bug reproducible on current stable build (App Version, iOS Version): NA, New Feature in M62 Bug reproducible on the current beta channel build (App Version, iOS Version): NA, New Feature in M62 Link to video : https://drive.google.com/a/google.com/file/d/0B--UpU2GW2EpWVduNTR1MkV1blU/view?usp=sharing
,
Aug 31 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/e107adb0da7ba682fc76707721d0c558f2c7232f commit e107adb0da7ba682fc76707721d0c558f2c7232f Author: Gauthier Ambard <gambard@chromium.org> Date: Thu Aug 31 09:49:42 2017 Adapt scroll offset to content on back navigation When the user navigates back to Home using the back arrow, the offset stored might be bigger than the content of the collection. If the collection is set to an offset bigger than the content, some constraints are not possible to satisfy and the omnibox is not displayed. This CL fixes it by limiting the offset. Bug: 760439 Change-Id: I5f30bcc4e36d3ff03d9caf809bfd1e0e85cd3d5b Reviewed-on: https://chromium-review.googlesource.com/645348 Reviewed-by: Olivier Robin <olivierrobin@chromium.org> Commit-Queue: Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#498800} [modify] https://crrev.com/e107adb0da7ba682fc76707721d0c558f2c7232f/ios/chrome/browser/content_suggestions/content_suggestions_coordinator.mm [modify] https://crrev.com/e107adb0da7ba682fc76707721d0c558f2c7232f/ios/chrome/browser/ui/content_suggestions/content_suggestions_view_controller.h [modify] https://crrev.com/e107adb0da7ba682fc76707721d0c558f2c7232f/ios/chrome/browser/ui/content_suggestions/content_suggestions_view_controller.mm
,
Aug 31 2017
,
Sep 4 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/6c143cff422710413b2ff7b13da6e17175806352 commit 6c143cff422710413b2ff7b13da6e17175806352 Author: Gauthier Ambard <gambard@chromium.org> Date: Mon Sep 04 11:10:47 2017 Test ContentSuggestions opening and back Add an EG test to ContentSuggestions to test the behavior of the collection when loading more items, scrolling down, opening an item, going back. It tests that the position of the collection is correct and that the omnibox is correctly displayed, to prevent the bug 760439 . Bug: 760439 , 749981 Change-Id: I20efb3c0ecb6799059eab359c47dd5ae763b1965 Reviewed-on: https://chromium-review.googlesource.com/645970 Commit-Queue: Gauthier Ambard <gambard@chromium.org> Reviewed-by: Jean-François Geyelin <jif@chromium.org> Reviewed-by: Jan Krcal <jkrcal@chromium.org> Cr-Commit-Position: refs/heads/master@{#499477} [modify] https://crrev.com/6c143cff422710413b2ff7b13da6e17175806352/components/ntp_snippets/mock_content_suggestions_provider.cc [modify] https://crrev.com/6c143cff422710413b2ff7b13da6e17175806352/components/ntp_snippets/mock_content_suggestions_provider.h [modify] https://crrev.com/6c143cff422710413b2ff7b13da6e17175806352/ios/chrome/browser/ui/content_suggestions/BUILD.gn [modify] https://crrev.com/6c143cff422710413b2ff7b13da6e17175806352/ios/chrome/browser/ui/content_suggestions/content_suggestions_egtest.mm [modify] https://crrev.com/6c143cff422710413b2ff7b13da6e17175806352/ios/chrome/browser/ui/content_suggestions/ntp_home_egtest.mm [modify] https://crrev.com/6c143cff422710413b2ff7b13da6e17175806352/ios/chrome/browser/ui/content_suggestions/ntp_home_provider_test_singleton.mm [add] https://crrev.com/6c143cff422710413b2ff7b13da6e17175806352/ios/chrome/browser/ui/content_suggestions/ntp_home_test_utils.h [add] https://crrev.com/6c143cff422710413b2ff7b13da6e17175806352/ios/chrome/browser/ui/content_suggestions/ntp_home_test_utils.mm
,
Sep 12 2017
verified the issue on the build 63.0.3213.0 canary tested on iPhone7+(iOS 11). Omnibox is displayed on navigating back to ntp,works fine |
|||
►
Sign in to add a comment |
|||
Comment 1 by sczs@chromium.org
, Aug 30 2017Status: Assigned (was: Untriaged)