New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 760404 link

Starred by 1 user
Status: Fixed
Owner:
█ petershih@chromium.org
Last visit > 30 days ago
Closed: Sep 2017
Cc:
█ itspeter@chromium.org
█ chuntsen@chromium.org
chromeos-factory-eng@google.com
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 3
Type: Bug



Sign in to add a comment

rf_graphyte should not use shopfloor.UploadAuxLogs

Project Member Reported by hungte@chromium.org, Aug 30 2017 
From akahuang:

"If the SN problem in station based testing is fixed, I think we can remove the upload aux log.

And we also need a convenient way to search the log file from bigquery/gcs. RF eng sometimes need the result file directly"

Shen-en, please make the changes so rf_graphyte won't need UploadAuxLogs. It should only use TestLog parameters and attachments.

And you can work with chuntsen to make sure you can find and download result files quickly.

Comment 1 by petershih@chromium.org, Aug 31 2017 

We have already used BigQuery to query from testlog events to get graphyte results. For example, https://bigquery.cloud.google.com/savedquery/85420926802:a326782628154763b5f766062b656b17 . And we've shared these queries to our RF engs.

Now, the aux log only serves as a last resort to get the graphyte log, and as an easier way to download the graphyte logs in batch (this can also be done by the script https://chromium.googlesource.com/chromiumos/platform/factory/+/master/devtools/instalog/get_attachments.py#). So, aux logs are safe to be removed.

Noticeably, it is very important to make sure we can get hardware SN, so the RF engs can find the log for a certain failing board. The mentioned SN problem makes the 'serialNumbers' field useless. So I suggest to keep another copy of SN in the testlog attachment file name, so we can still get serial number from there. This is what we've done (thanks to akahuang@ !) in previous builds, and saved our life back then.
Project Member

Comment 2 by bugdroid1@chromium.org, Aug 31 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform/factory/+/a6d803be1b63c8c30fc3b15874a7fa167f684776

commit a6d803be1b63c8c30fc3b15874a7fa167f684776
Author: Shen-En Shih <petershih@chromium.org>
Date: Thu Aug 31 11:52:21 2017

rf_graphyte: Do not need to upload aux logs

No need to upload aux log. All the logs can be fetched
from BigQuery and Google Cloud Storage.

BUG= chromium:760404 
TEST=make test

Change-Id: Ia084f213d144087392f9e4eb2444dd03b7e842b9
Reviewed-on: https://chromium-review.googlesource.com/644971
Commit-Ready: Shen-En Shih <petershih@chromium.org>
Tested-by: Shen-En Shih <petershih@chromium.org>
Reviewed-by: Hung-Te Lin <hungte@chromium.org>

[modify] https://crrev.com/a6d803be1b63c8c30fc3b15874a7fa167f684776/po/zh-CN.po
[modify] https://crrev.com/a6d803be1b63c8c30fc3b15874a7fa167f684776/py/test/pytests/rf_graphyte/rf_graphyte.py
[modify] https://crrev.com/a6d803be1b63c8c30fc3b15874a7fa167f684776/py/test/pytests/rf_graphyte/README.md

Comment 3 by petershih@chromium.org, Sep 6 2017 

CL is merged on ToT. Mark as fixed.

Comment 4 by hungte@chromium.org, Sep 6 2017

Status: Fixed (was: Assigned)

Comment 5 by dchan@chromium.org, Jan 22 2018

Status: Archived (was: Fixed)

Comment 6 by dchan@chromium.org, Jan 23 2018

Status: Fixed (was: Archived)
►

Sign in to add a comment