Two-finger tap on the background should show context menu for the current folder |
|||||||||||
Issue descriptionChrome Version: 62.0.3199.0 Steps To Reproduce: (1) Tap an item in the file list with two fingers. See context menu appears. (2) Tap on the empty part of the view with two fingers (below the file list items). Expected Result: The file is unselected. Context menu for the current folder appears. (The blue highlight disappear, and the menu has only "New folder" item enabled.) Actual Result: Context menu for the file tapped in step 1 appears. (The blue highlight stays there, and the menu has items like "Copy". Those commands are applied to the file when chosen.)
,
Aug 30 2017
,
Aug 30 2017
,
Sep 6 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/858e2ad104ced10b1c6a498250f42490247d31c1 commit 858e2ad104ced10b1c6a498250f42490247d31c1 Author: Tatsuhisa Yamaguchi <yamaguchi@chromium.org> Date: Wed Sep 06 08:48:13 2017 Open context menu of current folder by two-finger tapping at background. This change cancels selection when tapping the padding region in the file list view view by two fingers. This is same as right-click of mouse, however, since two-finger tapping will not produce mousedown events, it must be handled separately. Also, the inViewport function in cr.ui.List is not compatible with touch events and was always getting false. Bug: 760400 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I10b197e1ba0e0ed32b3c1ee036c487e7fc70199c Reviewed-on: https://chromium-review.googlesource.com/642641 Reviewed-by: Naoki Fukino <fukino@chromium.org> Reviewed-by: Michael Giuffrida <michaelpg@chromium.org> Commit-Queue: Tatsuhisa Yamaguchi <yamaguchi@chromium.org> Cr-Commit-Position: refs/heads/master@{#499906} [modify] https://crrev.com/858e2ad104ced10b1c6a498250f42490247d31c1/ui/file_manager/file_manager/foreground/js/ui/file_table_list.js [modify] https://crrev.com/858e2ad104ced10b1c6a498250f42490247d31c1/ui/webui/resources/js/cr/ui/list.js
,
Sep 6 2017
,
Sep 6 2017
This bug requires manual review: Request affecting a post-stable build Please contact the milestone owner if you have questions. Owners: amineer@(Android), cmasso@(iOS), ketakid@(ChromeOS), govind@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Sep 6 2017
Approving merge to M61 and M62.
,
Sep 7 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/038068410e18229a4b5bacceab84ed27f4ae87d0 commit 038068410e18229a4b5bacceab84ed27f4ae87d0 Author: Tatsuhisa Yamaguchi <yamaguchi@chromium.org> Date: Thu Sep 07 00:47:09 2017 Open context menu of current folder by two-finger tapping at background. This change cancels selection when tapping the padding region in the file list view view by two fingers. This is same as right-click of mouse, however, since two-finger tapping will not produce mousedown events, it must be handled separately. Also, the inViewport function in cr.ui.List is not compatible with touch events and was always getting false. TBR=yamaguchi@chromium.org (cherry picked from commit 858e2ad104ced10b1c6a498250f42490247d31c1) Bug: 760400 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I10b197e1ba0e0ed32b3c1ee036c487e7fc70199c Reviewed-on: https://chromium-review.googlesource.com/642641 Reviewed-by: Naoki Fukino <fukino@chromium.org> Reviewed-by: Michael Giuffrida <michaelpg@chromium.org> Commit-Queue: Tatsuhisa Yamaguchi <yamaguchi@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#499906} Reviewed-on: https://chromium-review.googlesource.com/654337 Reviewed-by: Tatsuhisa Yamaguchi <yamaguchi@chromium.org> Cr-Commit-Position: refs/branch-heads/3163@{#1128} Cr-Branched-From: ff259bab28b35d242e10186cd63af7ed404fae0d-refs/heads/master@{#488528} [modify] https://crrev.com/038068410e18229a4b5bacceab84ed27f4ae87d0/ui/file_manager/file_manager/foreground/js/ui/file_table_list.js [modify] https://crrev.com/038068410e18229a4b5bacceab84ed27f4ae87d0/ui/webui/resources/js/cr/ui/list.js
,
Sep 7 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/c2f7710e26c0909a34c810a53ae94d7a31ef4d39 commit c2f7710e26c0909a34c810a53ae94d7a31ef4d39 Author: Tatsuhisa Yamaguchi <yamaguchi@chromium.org> Date: Thu Sep 07 00:51:37 2017 Open context menu of current folder by two-finger tapping at background. This change cancels selection when tapping the padding region in the file list view view by two fingers. This is same as right-click of mouse, however, since two-finger tapping will not produce mousedown events, it must be handled separately. Also, the inViewport function in cr.ui.List is not compatible with touch events and was always getting false. TBR=yamaguchi@chromium.org (cherry picked from commit 858e2ad104ced10b1c6a498250f42490247d31c1) Bug: 760400 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I10b197e1ba0e0ed32b3c1ee036c487e7fc70199c Reviewed-on: https://chromium-review.googlesource.com/642641 Reviewed-by: Naoki Fukino <fukino@chromium.org> Reviewed-by: Michael Giuffrida <michaelpg@chromium.org> Commit-Queue: Tatsuhisa Yamaguchi <yamaguchi@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#499906} Reviewed-on: https://chromium-review.googlesource.com/654357 Reviewed-by: Tatsuhisa Yamaguchi <yamaguchi@chromium.org> Cr-Commit-Position: refs/branch-heads/3202@{#59} Cr-Branched-From: fa6a5d87adff761bc16afc5498c3f5944c1daa68-refs/heads/master@{#499098} [modify] https://crrev.com/c2f7710e26c0909a34c810a53ae94d7a31ef4d39/ui/file_manager/file_manager/foreground/js/ui/file_table_list.js [modify] https://crrev.com/c2f7710e26c0909a34c810a53ae94d7a31ef4d39/ui/webui/resources/js/cr/ui/list.js
,
Sep 7 2017
,
Jan 22 2018
,
Jan 23 2018
|
|||||||||||
►
Sign in to add a comment |
|||||||||||
Comment 1 by yamaguchi@chromium.org
, Aug 30 2017