New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 760395 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Sep 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 2
Type: Bug



Sign in to add a comment

[Feedback Stable] Open a second Chrome when tapping on bookmark links in overflow menu

Project Member Reported by hongchic...@chromium.org, Aug 30 2017

Issue description

Chrome Version: 60.0.3112.107, 59.0.3071.125
OS: Android 7.0 + SDK 24 + Samsung devices

What steps will reproduce the problem?
go to overflow menu --> bookmarks --> tap on a bookmark link --> no response --> tap again on the bookmark link --> bookmark was open in another Chrome 

user quote: "Use bookmarks would be open one more chrome. I using system Android 7.0. Please fix it."

Users on Samsung A5, A7 and N9 mentioned this issue happened after they updated to Android 7.0

M59
http://feedback/#/Report/70435494140
http://feedback/#/Report/68684326931
http://feedback/#/Report/69624642824
http://feedback/#/Report/69612954420
http://feedback/#/Report/69597642654
http://feedback/#/Report/69871842565
http://feedback/#/Report/69200596455
http://feedback/#/Report/69937761902
http://feedback/#/Report/70175568227

M60
http://feedback/#/Report/71715223264


For graphics-related bugs, please copy/paste the contents of the about:gpu
page at the end of this report.

 
Cc: sandeepkumars@chromium.org
Labels: TE-DesktopTriage Needs-Feedback
Tested the issue using #60.0.3112.107 on Android 7.0.0 Samsung Galaxy S6 edge plus and was not able to reproduce the issue as per the steps mentioned below.

1. Launched Chrome 
2. Clicked on customize and control menu
3. tapped on bookmark's link
4. Navigated to mobile bookmarks page. 

@hongchichang: Could you please find the above steps and please let us know if we missed any steps from end.

Thanks!!
Labels: -TE-DesktopTriage Needs-triage-Mobile
#1 yes, I am reaching out to user for repro steps and screenshot. Thanks. 

Comment 4 by ram...@chromium.org, Aug 31 2017

Components: UI>Browser>Mobile>MultiWindow
Labels: -Pri-3 M-62 Pri-2
Owner: twelling...@chromium.org
Status: Assigned (was: Untriaged)
Device:Samsung Galaxy Note 5
Android Version: NRD90M
Chrome Version: 60.0.3112.107


Steps to Repro:
1. Start Chrome.
2. Hit the soft key on device to invoke Multi-Window mode
3. Select more options and Bookmarks.
4. Select an existing bookmark.(selected 'yahoo.com')

Expected resuts:
Yahoo.com web site should be opened.

Results:
Yahoo.com is dropped in background.

Please find logs and video record @
http://go/chrome-androidlogs1/7/760395

Added files:

openBookmark.mp4
openBookmark.log

This is due to issue 749348. Samsung is continuing to use their own multi-window implementation instead of Android's default implementation and it's not playing nicely with the Chrome support added in N.
Project Member

Comment 6 by bugdroid1@chromium.org, Sep 5 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f7d28125db409a4f74f003205214c14eed3e090c

commit f7d28125db409a4f74f003205214c14eed3e090c
Author: Theresa Wellington <twellington@google.com>
Date: Tue Sep 05 16:11:00 2017

Disable Samsung multi-instance for Monochrome builds

On Android N, Samsung's implementation of multi-instance mode doesn't
interact well with Chrome's implementation of multi-instance. Monochrome
targets N+, so we can conditionally disable Samsung multi-instance for
Monochrome builds.

BUG= 760395 , 749348

Change-Id: Iff4b831c0bed8c91987028f450f63e7b478f5a6c
Reviewed-on: https://chromium-review.googlesource.com/647382
Reviewed-by: Ted Choc <tedchoc@chromium.org>
Commit-Queue: Theresa <twellington@chromium.org>
Cr-Commit-Position: refs/heads/master@{#499648}
[modify] https://crrev.com/f7d28125db409a4f74f003205214c14eed3e090c/chrome/android/java/AndroidManifest.xml

Status: Fixed (was: Assigned)
On MonoChrome builds (which target N+), we have disabled Samsung's multi-instance mode.

Previously, in multi-window mode on Samsung devices, if you went to the home screen and tapped the Chrome icon, a second Chrome window would be created. Now, if you go to the home screen and tap the Chrome icon the existing window will be focused (a second window will *not* be created). This behavior matches non-Samsung devices.

Samsung multi-window/multi-instance behavior now matches the model we use for other devices, where the only way to create a second Chrome window is to select "Move to other window" from the app menu or from the long-press context menu.

On older versions of Samsung (M and below), Chrome still supports Samsung multi-instance and behavior should be unchanged from older Chrome versions.
Project Member

Comment 8 by bugdroid1@chromium.org, Nov 2 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6a88f133dfdc75f185c2359b92bcb5610747f2db

commit 6a88f133dfdc75f185c2359b92bcb5610747f2db
Author: Theresa Wellington <twellington@google.com>
Date: Thu Nov 02 16:38:55 2017

Fix Samsung multi-instance disalbe for Monochrome builds

The min_sdk_version is a string and needs to be converted to an int for
proper comparision.

BUG= 760395 , 749348

Change-Id: I5f9b99452d01dd37f9a7a64a0f20120b089b0017
Reviewed-on: https://chromium-review.googlesource.com/751541
Reviewed-by: Ted Choc <tedchoc@chromium.org>
Commit-Queue: Theresa <twellington@chromium.org>
Cr-Commit-Position: refs/heads/master@{#513515}
[modify] https://crrev.com/6a88f133dfdc75f185c2359b92bcb5610747f2db/chrome/android/java/AndroidManifest.xml

Verified with chrome version '64.0.3261.0'

Sign in to add a comment