Multiple browser_tests failing on Win7 Tests (dbg)(1) |
||||||
Issue descriptionFirst breakage: https://uberchromegw.corp.google.com/i/chromium.win/builders/Win7%20Tests%20%28dbg%29%281%29/builds/62765 Log: base::win::internal::ModifyCode [0x103B26C3+387] invalid_parameter [0x747EE551+161] std::_Vector_const_iterator<std::_Vector_val<std::_Simple_types<base::RepeatingCallback<void __cdecl(void)> > > >::operator++ [0x0C5E5780+144] std::_Vector_iterator<std::_Vector_val<std::_Simple_types<base::RepeatingCallback<void __cdecl(void)> > > >::operator++ [0x0C5E57DF+15] mojo::SyncHandleRegistry::Wait [0x0C5E6D4D+685] IPC::SyncChannel::WaitForReply [0x0FD9DA34+356]
,
Aug 30 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/0029db1595c245cbe93dd8b6f3039e9af625a452 commit 0029db1595c245cbe93dd8b6f3039e9af625a452 Author: Tarun Bansal <tbansal@chromium.org> Date: Wed Aug 30 00:16:55 2017 Speculatively revert "Mojo: Allow duplicate events in SyncHandleRegistry" This reverts commit 327ed962ca0353e72e18a5eeeab5112d7d7058b6. Reason for revert: Suspected for breaking browser_tests failing on Win7 Tests (dbg)(1) See crbug.com/760381 Original change's description: > Mojo: Allow duplicate events in SyncHandleRegistry > > Allows mulitple registrations for the same WaitableEvent in > SyncHandleRegistry to allow for instances of independent nested waiters > unwittingly waiting on the same event. > > BUG=754945 > R=yzshen@chromium.org > > Change-Id: Ia166d860bf2a07a2db9dc39ae1350b8758950ff4 > Reviewed-on: https://chromium-review.googlesource.com/641402 > Reviewed-by: Yuzhu Shen <yzshen@chromium.org> > Commit-Queue: Ken Rockot <rockot@chromium.org> > Cr-Commit-Position: refs/heads/master@{#498246} TBR=rockot@chromium.org,yzshen@chromium.org Change-Id: I5f95fbcd9f3b602ccc16e381ca5f851445a55297 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 754945, 760381 Reviewed-on: https://chromium-review.googlesource.com/642546 Reviewed-by: Tarun Bansal <tbansal@chromium.org> Commit-Queue: Tarun Bansal <tbansal@chromium.org> Cr-Commit-Position: refs/heads/master@{#498298} [modify] https://crrev.com/0029db1595c245cbe93dd8b6f3039e9af625a452/ipc/ipc_sync_channel.cc [modify] https://crrev.com/0029db1595c245cbe93dd8b6f3039e9af625a452/ipc/ipc_sync_message_filter.cc [modify] https://crrev.com/0029db1595c245cbe93dd8b6f3039e9af625a452/mojo/public/cpp/bindings/lib/sync_event_watcher.cc [modify] https://crrev.com/0029db1595c245cbe93dd8b6f3039e9af625a452/mojo/public/cpp/bindings/lib/sync_handle_registry.cc [modify] https://crrev.com/0029db1595c245cbe93dd8b6f3039e9af625a452/mojo/public/cpp/bindings/sync_handle_registry.h
,
Aug 30 2017
,
Aug 30 2017
,
Aug 30 2017
After revert, the next build looks green: https://uberchromegw.corp.google.com/i/chromium.win/builders/Win7%20Tests%20%28dbg%29%281%29/builds/62768 Handing off the bug to rockot to track reland of the CL.
,
Aug 30 2017
,
Aug 30 2017
I'd consider this fixed by the revert. I don't think it makes sense to associate the reland with this bug. |
||||||
►
Sign in to add a comment |
||||||
Comment 1 by tbansal@chromium.org
, Aug 30 2017