New issue
Advanced search Search tips

Issue 760371 link

Starred by 1 user

Issue metadata

Status: Assigned
Owner:
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Feature


Participants' hotlists:
Tiff-List


Sign in to add a comment

Organize routing in Sheriff-o-Matic better

Project Member Reported by zhangtiff@chromium.org, Aug 29 2017

Issue description

Routing in Sheriff-o-Matic is getting a little bit hackish now that our pages are getting more complex. Nested subroutes in particular are a pain right now. 

Polymer's app-route element I believe will be much nicer and easier to extend: https://www.webcomponents.org/element/PolymerElements/app-route 
 
app-route is still in beta, so we'll probably want to wait a bit before deciding to use it. It also uses 2-way data binding to broadcast the URL of the page as well (like iron-location), which, if we do eventually switch to something like redux (and possibly after the Polymer 3 transition...) would be a problem. 
Summary: Organize routing in Sheriff-o-Matic better (was: Switch to app-route instead of iron-location)
Looked at PolyGerrit, and it looks like they use their own custom-implemented router to deal with this. 

Looking more into app-route, it doesn't seem to really provide all that much besides url parsing. 

We could probably get away with refactoring our routes into a more standard system. PolyGerrit basically has a file with a huge bunch of regexes and a lot of other things. Not the prettiest, but I think it beats having random url parsing logic spread between components. 
Labels: -Milestone-UX Milestone-CodeHealth Type-Feature

Sign in to add a comment