New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 760367 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Last visit 28 days ago
Closed: Dec 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 3
Type: Bug



Sign in to add a comment

DevTools: Runtime.callFunctionOn should accept execution context

Project Member Reported by lushnikov@chromium.org, Aug 29 2017

Issue description

The protocol's Runtime.callFunctionOn should accept execution context and pass global object as function receiver.


 
Project Member

Comment 1 by bugdroid1@chromium.org, Aug 31 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2c95b04d921d895c30a5fabfa54e1f0d30441ff0

commit 2c95b04d921d895c30a5fabfa54e1f0d30441ff0
Author: Andrey Lushnikov <lushnikov@chromium.org>
Date: Thu Aug 31 00:05:03 2017

DevTools: rebaseline tests preparing for Rutnime.callFunctionOn change

This patch disables and rebaslines a few devtools tests to make it
possible to land the changes to V8:
https://chromium-review.googlesource.com/c/v8/v8/+/641921

BUG= 760367 
R=kozy

Change-Id: I336a2764e552778c2d2ab6b7ec30a9ab56ace711
Reviewed-on: https://chromium-review.googlesource.com/642512
Commit-Queue: Andrey Lushnikov <lushnikov@chromium.org>
Reviewed-by: Aleksey Kozyatinskiy <kozyatinskiy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#498681}
[modify] https://crrev.com/2c95b04d921d895c30a5fabfa54e1f0d30441ff0/third_party/WebKit/LayoutTests/TestExpectations
[modify] https://crrev.com/2c95b04d921d895c30a5fabfa54e1f0d30441ff0/third_party/WebKit/LayoutTests/http/tests/devtools/console/console-tainted-globals.html
[modify] https://crrev.com/2c95b04d921d895c30a5fabfa54e1f0d30441ff0/third_party/WebKit/LayoutTests/inspector/runtime/runtime-callFunctionOn.html

Project Member

Comment 2 by bugdroid1@chromium.org, Aug 31 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/v8/v8.git/+/257f9494a6dc62487b209aca73dfff02c3efa359

commit 257f9494a6dc62487b209aca73dfff02c3efa359
Author: Andrey Lushnikov <lushnikov@chromium.org>
Date: Thu Aug 31 02:23:06 2017

Reland of Inspector: Runtime.callFunctionOn to accept executionContextId

This patch:
- teaches Runtime.callFunctionOn to accept executionContextId instead of
  objectId.
- adds the optional objectGroup parameter to the Runtime.callFunctionOn.

R=kozy
TBR=pfeldman
BUG= chromium:760367 

Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel
Change-Id: I024654860f23a9e79fb57865ba5bd472692ea526
Reviewed-on: https://chromium-review.googlesource.com/641921
Commit-Queue: Andrey Lushnikov <lushnikov@chromium.org>
Reviewed-by: Pavel Feldman <pfeldman@chromium.org>
Reviewed-by: Aleksey Kozyatinskiy <kozyatinskiy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#47725}
[modify] https://crrev.com/257f9494a6dc62487b209aca73dfff02c3efa359/src/inspector/js_protocol.json
[modify] https://crrev.com/257f9494a6dc62487b209aca73dfff02c3efa359/src/inspector/v8-runtime-agent-impl.cc
[modify] https://crrev.com/257f9494a6dc62487b209aca73dfff02c3efa359/src/inspector/v8-runtime-agent-impl.h
[modify] https://crrev.com/257f9494a6dc62487b209aca73dfff02c3efa359/test/inspector/runtime/call-function-on-async-expected.txt
[modify] https://crrev.com/257f9494a6dc62487b209aca73dfff02c3efa359/test/inspector/runtime/call-function-on-async.js

Status: Fixed (was: Assigned)

Sign in to add a comment