New issue
Advanced search Search tips

Issue 760356 link

Starred by 2 users
Status: Fixed
Owner:
sammiequon@chromium.org
Closed: Sep 2017
Cc:
omrilio@chromium.org
x...@chromium.org
zork@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug



Sign in to add a comment

Window grid bounds are not updated correctly if dragging an unsnappable ARC app window in overview mode

Project Member Reported by x...@chromium.org, Aug 29 2017 
Chrome Version: (copy from chrome://version)
OS: Chrome

What steps will reproduce the problem?
(1) Enable splitscreen --enable-tablet-splitscreen
(2) Open several browser windows and an ARC app window, which can't be snapped. 
(3) Press and drag the ARC app window around

What is the expected result?
Window grid bounds should not change.

What happens instead?
Window grid bounds changed.

I think it's introduced by https://chromium-review.googlesource.com/c/chromium/src/+/615790.
Project Member

Comment 1 by bugdroid1@chromium.org, Aug 30 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d6dcc0357e7f67ec0979a8a26b8613902f340892

commit d6dcc0357e7f67ec0979a8a26b8613902f340892
Author: Sammie Quon <sammiequon@google.com>
Date: Wed Aug 30 18:20:16 2017

wm: Do not allow unsnappable windows to move window grid.

Also do not show phantom window.

Test: manual, WindowSelectorTest.DraggingNonSnapableAppWithSplitView
Bug:  760356 
Change-Id: Ida67c83680ebd7614afff341d65134ef2acf35b6
Reviewed-on: https://chromium-review.googlesource.com/641988
Reviewed-by: Xiaoqian Dai <xdai@chromium.org>
Reviewed-by: Mitsuru Oshima <oshima@chromium.org>
Commit-Queue: Sammie Quon <sammiequon@chromium.org>
Cr-Commit-Position: refs/heads/master@{#498538}
[modify] https://crrev.com/d6dcc0357e7f67ec0979a8a26b8613902f340892/ash/wm/overview/overview_window_drag_controller.cc
[modify] https://crrev.com/d6dcc0357e7f67ec0979a8a26b8613902f340892/ash/wm/overview/window_selector_unittest.cc

Comment 2 by zalcorn@chromium.org, Aug 31 2017

Components: UI>Shell>OverviewMode

Comment 3 by sammiequon@chromium.org, Sep 6 2017

Status: Fixed (was: Assigned)
►

Sign in to add a comment