New issue
Advanced search Search tips

Issue 760353 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Sep 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 3
Type: Bug



Sign in to add a comment

DevTools: errors when opening Application panel

Project Member Reported by pfeldman@chromium.org, Aug 29 2017

Issue description

"Request Storage.trackCacheStorageForOrigin failed. {"code":-32602,"message":":// is not a valid URL"}"
 
Got it to reproduce by navigating to chrome://dino

Failing here at GURL::is_valid
https://cs.chromium.org/chromium/src/content/browser/devtools/protocol/storage_handler.cc?l=256

Should "://" be an invalid url?
Project Member

Comment 2 by bugdroid1@chromium.org, Sep 12 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/de1a3f7ba4fe7910c9cfec0ff595163b2e936503

commit de1a3f7ba4fe7910c9cfec0ff595163b2e936503
Author: kristipark <kristipark@chromium.org>
Date: Tue Sep 12 00:07:53 2017

[DevTools] Check valid origin before tracking for Cache Storage live update

Added valid origin check before tracking/untracking an origin.

Bug:  760353 
Change-Id: I1de5cf59b274838f0632b8d8141772d4929cc794
Reviewed-on: https://chromium-review.googlesource.com/648472
Commit-Queue: Kristi Park <kristipark@chromium.org>
Reviewed-by: Pavel Feldman <pfeldman@chromium.org>
Reviewed-by: Daniel Murphy <dmurph@chromium.org>
Cr-Commit-Position: refs/heads/master@{#501107}
[modify] https://crrev.com/de1a3f7ba4fe7910c9cfec0ff595163b2e936503/third_party/WebKit/Source/devtools/front_end/sdk/ServiceWorkerCacheModel.js

Status: Fixed (was: Assigned)

Sign in to add a comment