MD Extensions: Keyboard shortcut page styling needs to match the design mock |
||||
Issue descriptionincluding: - input style (static, focused, x-button for clear) - dropdown style (including disabled state) - check multi-row layout with an extension that takes multiple keyboard shortcuts.
,
Sep 7 2017
,
Sep 8 2017
,
Sep 12 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/5e46162f91a7dfdf410f11a667eb44616dc57667 commit 5e46162f91a7dfdf410f11a667eb44616dc57667 Author: Scott Chen <scottchen@chromium.org> Date: Tue Sep 12 00:12:11 2017 WebUI: adjust md-select styling Change the positioning and overlapping of the focus and underline. Bug: 763451 , 760331 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: Ib91dfa1e9963e1e280e52f0627b6460516553137 Reviewed-on: https://chromium-review.googlesource.com/657276 Commit-Queue: Scott Chen <scottchen@chromium.org> Reviewed-by: Dave Schuyler <dschuyler@chromium.org> Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#501109} [modify] https://crrev.com/5e46162f91a7dfdf410f11a667eb44616dc57667/ui/webui/resources/html/md_select_css.html
,
Sep 27 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/ede95e57e7fcccc7a29217ebd5611e1ca1b0623a commit ede95e57e7fcccc7a29217ebd5611e1ca1b0623a Author: Scott Chen <scottchen@chromium.org> Date: Wed Sep 27 03:06:41 2017 MD Extensions: shortcut page styling. This CL updates the keyboard shortcuts page to be closer to mock. Changes include: - text/border colors - paper-input styling - vertical alignment within each rows - shortcut text display ("+" to " + ") Bug: 760331 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: Ia71f7c40f6c93b8d4b824439ea17bae40c8e4a88 Reviewed-on: https://chromium-review.googlesource.com/663770 Commit-Queue: Scott Chen <scottchen@chromium.org> Reviewed-by: Dave Schuyler <dschuyler@chromium.org> Cr-Commit-Position: refs/heads/master@{#504564} [modify] https://crrev.com/ede95e57e7fcccc7a29217ebd5611e1ca1b0623a/chrome/browser/resources/md_extensions/detail_view.html [modify] https://crrev.com/ede95e57e7fcccc7a29217ebd5611e1ca1b0623a/chrome/browser/resources/md_extensions/keyboard_shortcuts.html [modify] https://crrev.com/ede95e57e7fcccc7a29217ebd5611e1ca1b0623a/chrome/browser/resources/md_extensions/shortcut_input.html [modify] https://crrev.com/ede95e57e7fcccc7a29217ebd5611e1ca1b0623a/chrome/browser/resources/md_extensions/shortcut_input.js [modify] https://crrev.com/ede95e57e7fcccc7a29217ebd5611e1ca1b0623a/chrome/browser/resources/settings/settings_page/settings_subpage.html [modify] https://crrev.com/ede95e57e7fcccc7a29217ebd5611e1ca1b0623a/chrome/test/data/webui/extensions/extension_shortcut_input_test.js [modify] https://crrev.com/ede95e57e7fcccc7a29217ebd5611e1ca1b0623a/ui/webui/resources/cr_elements/shared_vars_css.html
,
Sep 27 2017
|
||||
►
Sign in to add a comment |
||||
Comment 1 by scottchen@chromium.org
, Sep 7 2017