New issue
Advanced search Search tips

Issue 760320 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Jun 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug


Sign in to add a comment

Content_Unittests Viz Process Separation

Project Member Reported by jonr...@chromium.org, Aug 29 2017

Issue description

As a part of the work to split services/viz into a separate process, the testing dependencies on it need to be updated.

We need to identify all locations with direct dependencies, and update them accordingly. These will be tracked in bugs that block this one.

We will also need to look into providing a test interface to FrameSinkManager so that we stub out this test boundary
 
 
Blockedon: 760213
Blockedon: 762235
Blockedon: 762279
Blockedon: 762510
Blockedon: 762512
Blockedon: 762514
Blockedon: 762516
Blockedon: 762519
Blockedon: 762521
Blockedon: 762523
Blockedon: 762524
Blockedon: 762526
Blocking: 601863
Components: -Internals>Viz Internals>Services>Viz
Migrating from Internals>Viz to Internals>Services>Viz.
Blocking: -601863 730193
Blockedon: 764873
Blockedon: 763458
Blockedon: 795301
Blockedon: 795397
Blockedon: 795400
Blockedon: 796605
Project Member

Comment 22 by bugdroid1@chromium.org, Jan 8 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/cecd295635a75a65f5b55e8dc33a9799bf58cb27

commit cecd295635a75a65f5b55e8dc33a9799bf58cb27
Author: Jonathan <jonross@chromium.org>
Date: Mon Jan 08 16:01:07 2018

Update viz_content_unittests filter

A new failing test
RenderWidgetHostViewAuraTest.BackgroundColorMatchesCompositorFrame was added
to viz_content_unittests. This updates the filter to disable it.

TBR=kylechar@chromium.org

Bug:  760320 
Change-Id: If36f7ba36ebd598535920233148e9bd7a3fd94ac
Reviewed-on: https://chromium-review.googlesource.com/854232
Reviewed-by: Jonathan Ross <jonross@chromium.org>
Commit-Queue: Jonathan Ross <jonross@chromium.org>
Cr-Commit-Position: refs/heads/master@{#527640}
[modify] https://crrev.com/cecd295635a75a65f5b55e8dc33a9799bf58cb27/testing/buildbot/filters/viz.content_unittests.filter

Project Member

Comment 23 by bugdroid1@chromium.org, Jan 9 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/32cbeb9703d56b479737f083c83317c3c867db87

commit 32cbeb9703d56b479737f083c83317c3c867db87
Author: Jonathan <jonross@chromium.org>
Date: Tue Jan 09 23:45:21 2018

Add viz_content_unittests to CQ

The viz_content_unittests have been stable on the FYI bots. This change adds
them to the main viz test config used on linux and chromeos bots.

TBR=sky@chromium.org

Bug:  760320 
Change-Id: Id7fd93578afdd17fead8944c4e8a009c4fb3d831
Reviewed-on: https://chromium-review.googlesource.com/857544
Reviewed-by: Jonathan Ross <jonross@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: Jonathan Ross <jonross@chromium.org>
Cr-Commit-Position: refs/heads/master@{#528171}
[modify] https://crrev.com/32cbeb9703d56b479737f083c83317c3c867db87/testing/buildbot/chromium.chromiumos.json
[modify] https://crrev.com/32cbeb9703d56b479737f083c83317c3c867db87/testing/buildbot/chromium.linux.json
[modify] https://crrev.com/32cbeb9703d56b479737f083c83317c3c867db87/testing/buildbot/chromium.sandbox.json
[modify] https://crrev.com/32cbeb9703d56b479737f083c83317c3c867db87/testing/buildbot/test_suites.pyl

Project Member

Comment 24 by bugdroid1@chromium.org, Jan 29 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6ce41505d2c049de1b66ac1dcbd5179fad4d6539

commit 6ce41505d2c049de1b66ac1dcbd5179fad4d6539
Author: Jonathan <jonross@chromium.org>
Date: Mon Jan 29 14:45:05 2018

Update viz_content_unittests filter

Recent bug fixes have lead to more passing tests. Re-enable them.

TBR=kylechar@chromium.org

Bug:  760320 
Change-Id: Iaf8bb1985bda1de31af30c775180f64bdf3d526e
Reviewed-on: https://chromium-review.googlesource.com/860277
Reviewed-by: Jonathan Ross <jonross@chromium.org>
Reviewed-by: kylechar <kylechar@chromium.org>
Commit-Queue: Jonathan Ross <jonross@chromium.org>
Cr-Commit-Position: refs/heads/master@{#532423}
[modify] https://crrev.com/6ce41505d2c049de1b66ac1dcbd5179fad4d6539/testing/buildbot/filters/viz.content_unittests.filter

Project Member

Comment 25 by bugdroid1@chromium.org, Mar 1 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0454751ad3e5636de70ff3c3c565ae3aae6c1261

commit 0454751ad3e5636de70ff3c3c565ae3aae6c1261
Author: jonross <jonross@chromium.org>
Date: Thu Mar 01 15:58:54 2018

Re-enable fixed viz_content_unittests

Some viz_content_unittests have been fixed, re-enabling them.

TBR=kylechar@chromium.org
TEST=RenderWidgetHostTest.FrameToken_RendererCrash,
     RenderWidgetHostTest.NewContentRenderingTimeout,
     RenderWidgetHostTest.SwapCompositorFrameWithBadSourceId

Bug:  760320 
Change-Id: Ib52cd12d381575a134893d1d2d6f4b51021b4428
Reviewed-on: https://chromium-review.googlesource.com/943462
Reviewed-by: Jonathan Ross <jonross@chromium.org>
Cr-Commit-Position: refs/heads/master@{#540167}
[modify] https://crrev.com/0454751ad3e5636de70ff3c3c565ae3aae6c1261/testing/buildbot/filters/viz.content_unittests.filter

Status: Fixed (was: Untriaged)
All tests that were affected by the split have been updated. We have full CQ coverage of these tests as well for our upcoming Finches.

There are separate issues tracking CQ work for future OSes.
The known failures are tracked separately.

So I'm marking this as fixed.

Sign in to add a comment