New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 760316 link

Starred by 5 users

Issue metadata

Status: Assigned
Owner:
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug

Blocking:
issue 747132



Sign in to add a comment

Persist local files as remote files

Project Member Reported by allada@chromium.org, Aug 29 2017

Issue description

This is a tracking bug to allow users to emulate local files as being remote files in chrome devtools.

The idea is that users will be able to have chrome fill in remote url requests and serve a local file in it's place.

Design doc:
https://docs.google.com/document/d/1hQNBxeQiNr0pgO1Qr8I8tnBhdmrRikoT2pD-qzYwPDE
 
Blocking: 747132
Project Member

Comment 2 by bugdroid1@chromium.org, Sep 15 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2ca62566b77bec7469abef5f76822d2a5baab344

commit 2ca62566b77bec7469abef5f76822d2a5baab344
Author: Nathan Bruer <allada@chromium.org>
Date: Fri Sep 15 20:36:37 2017

[Devtools] Moved request interception to use blobs

Since javascript does not handle binary data as strings very
well, this patch moves request interception to work with blobs
instead.

R=caseq
BUG= 747132 ,760316

Change-Id: Icf56b69ca29ed8514f7da3ce234d635ede948907
Reviewed-on: https://chromium-review.googlesource.com/667929
Commit-Queue: Blaise Bruer <allada@chromium.org>
Reviewed-by: Andrey Kosyakov <caseq@chromium.org>
Cr-Commit-Position: refs/heads/master@{#502352}
[modify] https://crrev.com/2ca62566b77bec7469abef5f76822d2a5baab344/third_party/WebKit/Source/devtools/front_end/sdk/NetworkManager.js

Project Member

Comment 3 by bugdroid1@chromium.org, Oct 2 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c93bdaddfeef7468f586d9efdf4eb54068f5b34a

commit c93bdaddfeef7468f586d9efdf4eb54068f5b34a
Author: Nathan Bruer <allada@chromium.org>
Date: Mon Oct 02 22:17:08 2017

[Devtools] Add warning icon if request interception is enabled

Adds a warning triangle if request interception is currently active.

R=pfeldman,dgozman
BUG=760316

Change-Id: I7ad10215bc20885fd78b13c5d870c3c9f0745e6f
Reviewed-on: https://chromium-review.googlesource.com/690954
Commit-Queue: Blaise Bruer <allada@chromium.org>
Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#505813}
[modify] https://crrev.com/c93bdaddfeef7468f586d9efdf4eb54068f5b34a/third_party/WebKit/Source/devtools/front_end/main/Main.js

Project Member

Comment 4 by bugdroid1@chromium.org, Oct 2 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4dfb9b15797774b934e16f326fa72211f92ada06

commit 4dfb9b15797774b934e16f326fa72211f92ada06
Author: Nathan Bruer <allada@chromium.org>
Date: Mon Oct 02 22:42:41 2017

[Devtools] Added file path return to save response

Adds the ability for devtools to know where a file was saved on disk
when a save dialog was saved. This will allow us to serve files from
disk for interception.

R=pfeldman,dgozman
BUG=760316

Change-Id: Ic4477032219c66d00439bc7adecdb4783512a418
Reviewed-on: https://chromium-review.googlesource.com/690625
Reviewed-by: Andrey Kosyakov <caseq@chromium.org>
Reviewed-by: Pavel Feldman <pfeldman@chromium.org>
Commit-Queue: Blaise Bruer <allada@chromium.org>
Cr-Commit-Position: refs/heads/master@{#505825}
[modify] https://crrev.com/4dfb9b15797774b934e16f326fa72211f92ada06/chrome/browser/devtools/devtools_file_helper.cc
[modify] https://crrev.com/4dfb9b15797774b934e16f326fa72211f92ada06/chrome/browser/devtools/devtools_file_helper.h
[modify] https://crrev.com/4dfb9b15797774b934e16f326fa72211f92ada06/chrome/browser/devtools/devtools_ui_bindings.cc
[modify] https://crrev.com/4dfb9b15797774b934e16f326fa72211f92ada06/chrome/browser/devtools/devtools_ui_bindings.h
[modify] https://crrev.com/4dfb9b15797774b934e16f326fa72211f92ada06/third_party/WebKit/LayoutTests/http/tests/devtools/profiler/heap-snapshot-loader.html
[modify] https://crrev.com/4dfb9b15797774b934e16f326fa72211f92ada06/third_party/WebKit/Source/devtools/front_end/bindings/FileUtils.js
[modify] https://crrev.com/4dfb9b15797774b934e16f326fa72211f92ada06/third_party/WebKit/Source/devtools/front_end/devtools_compatibility.js
[modify] https://crrev.com/4dfb9b15797774b934e16f326fa72211f92ada06/third_party/WebKit/Source/devtools/front_end/host/InspectorFrontendHostAPI.js
[modify] https://crrev.com/4dfb9b15797774b934e16f326fa72211f92ada06/third_party/WebKit/Source/devtools/front_end/workspace/FileManager.js
[modify] https://crrev.com/4dfb9b15797774b934e16f326fa72211f92ada06/third_party/WebKit/Source/devtools/front_end/workspace/UISourceCode.js

Project Member

Comment 5 by bugdroid1@chromium.org, Oct 16 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e325e1edea421401611a067a28eba637ba519e85

commit e325e1edea421401611a067a28eba637ba519e85
Author: Nathan Bruer <allada@chromium.org>
Date: Mon Oct 16 21:09:56 2017

[Devtools] Front-end network interception no longer supports wildcard

Removed support for wildcard support in front-end interception since
it's not needed yet. Also moved away from abstract classes in SDK and
instead use handlers.

R=pfeldman,dgozman,caseq
BUG=760316

Change-Id: If883126fff6fa6fa381977299c2eba9c48d5af7b
Reviewed-on: https://chromium-review.googlesource.com/716560
Reviewed-by: Pavel Feldman <pfeldman@chromium.org>
Commit-Queue: Blaise Bruer <allada@chromium.org>
Cr-Commit-Position: refs/heads/master@{#509169}
[modify] https://crrev.com/e325e1edea421401611a067a28eba637ba519e85/third_party/WebKit/LayoutTests/http/tests/devtools/sdk/network-interception-wildcard-pattern-matching-expected.txt
[modify] https://crrev.com/e325e1edea421401611a067a28eba637ba519e85/third_party/WebKit/LayoutTests/http/tests/devtools/sdk/network-interception-wildcard-pattern-matching.js
[modify] https://crrev.com/e325e1edea421401611a067a28eba637ba519e85/third_party/WebKit/Source/devtools/front_end/sdk/NetworkManager.js

Project Member

Comment 6 by bugdroid1@chromium.org, Oct 17 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a0b551964b33ad89e66ff4edbc537ce009e9e1dd

commit a0b551964b33ad89e66ff4edbc537ce009e9e1dd
Author: Nathan Bruer <allada@chromium.org>
Date: Tue Oct 17 18:37:11 2017

[Devtools] Root folders will always show in workspaces if of filesystem

If the filesystem is empty the root folder of a filesystem type project
will always exist in the filesystem navigator.

R=lushnikov,einbinder,pfeldman
BUG=760316, 704053 

Change-Id: I7364829b247b712bd4b8aa59b490cbdeb514cea2
Reviewed-on: https://chromium-review.googlesource.com/716872
Reviewed-by: Andrey Lushnikov <lushnikov@chromium.org>
Commit-Queue: Blaise Bruer <allada@chromium.org>
Cr-Commit-Position: refs/heads/master@{#509440}
[modify] https://crrev.com/a0b551964b33ad89e66ff4edbc537ce009e9e1dd/third_party/WebKit/Source/devtools/front_end/sources/NavigatorView.js
[modify] https://crrev.com/a0b551964b33ad89e66ff4edbc537ce009e9e1dd/third_party/WebKit/Source/devtools/front_end/sources/SourcesNavigator.js
[modify] https://crrev.com/a0b551964b33ad89e66ff4edbc537ce009e9e1dd/third_party/WebKit/Source/devtools/front_end/sources/SourcesPanel.js

Project Member

Comment 7 by bugdroid1@chromium.org, Oct 18 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f3222c498f606154becfbd82214cf6dc7e874df1

commit f3222c498f606154becfbd82214cf6dc7e874df1
Author: Nathan Bruer <allada@chromium.org>
Date: Wed Oct 18 00:18:28 2017

[Devtools] Added ability to manage binding outside of workspaces

Adds new interfaces to manage bindings from outside persistence mappers.

* Adds ignoreProject/removeIgnoredProject - This is used to ignore a
project and automapping will not auto-map anything in these projects.
* Added addBinding/removeBinding - These are used to manually bind two
UISourceCodes together.

R=lushnikov,pfeldman
BUG=760316

Change-Id: Id86a368a1b5ec50c34ed38deee8714b190fb6869
Reviewed-on: https://chromium-review.googlesource.com/720244
Reviewed-by: Andrey Lushnikov <lushnikov@chromium.org>
Commit-Queue: Blaise Bruer <allada@chromium.org>
Cr-Commit-Position: refs/heads/master@{#509620}
[modify] https://crrev.com/f3222c498f606154becfbd82214cf6dc7e874df1/third_party/WebKit/Source/devtools/front_end/persistence/Automapping.js
[modify] https://crrev.com/f3222c498f606154becfbd82214cf6dc7e874df1/third_party/WebKit/Source/devtools/front_end/persistence/DefaultMapping.js
[modify] https://crrev.com/f3222c498f606154becfbd82214cf6dc7e874df1/third_party/WebKit/Source/devtools/front_end/persistence/Persistence.js

Project Member

Comment 8 by bugdroid1@chromium.org, Oct 18 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6316a74bbedcbb0ab433d4e9a55efade54f5b177

commit 6316a74bbedcbb0ab433d4e9a55efade54f5b177
Author: Nathan Bruer <allada@chromium.org>
Date: Wed Oct 18 04:40:33 2017

[Devtools] Add request interception experiment

This patch adds the ability to intercept requests and rewrite them with
content that as changed in the devtools session.

see: https://user-images.githubusercontent.com/1831202/31698204-2668249e-b371-11e7-814f-4253aa61ed7d.png
see: https://user-images.githubusercontent.com/1831202/31698205-26818cea-b371-11e7-804a-68a172537644.png

R=lushnikov,pfeldman,einbinder
BUG=760316

Change-Id: I9ab2fc3aeca22cf49bc20f2be569c543f9fa4ab8
Reviewed-on: https://chromium-review.googlesource.com/720160
Commit-Queue: Blaise Bruer <allada@chromium.org>
Reviewed-by: Andrey Lushnikov <lushnikov@chromium.org>
Cr-Commit-Position: refs/heads/master@{#509684}
[modify] https://crrev.com/6316a74bbedcbb0ab433d4e9a55efade54f5b177/third_party/WebKit/Source/devtools/BUILD.gn
[modify] https://crrev.com/6316a74bbedcbb0ab433d4e9a55efade54f5b177/third_party/WebKit/Source/devtools/front_end/common/ResourceType.js
[modify] https://crrev.com/6316a74bbedcbb0ab433d4e9a55efade54f5b177/third_party/WebKit/Source/devtools/front_end/main/Main.js
[modify] https://crrev.com/6316a74bbedcbb0ab433d4e9a55efade54f5b177/third_party/WebKit/Source/devtools/front_end/network/NetworkConfigView.js
[modify] https://crrev.com/6316a74bbedcbb0ab433d4e9a55efade54f5b177/third_party/WebKit/Source/devtools/front_end/network/module.json
[modify] https://crrev.com/6316a74bbedcbb0ab433d4e9a55efade54f5b177/third_party/WebKit/Source/devtools/front_end/network/networkConfigView.css
[modify] https://crrev.com/6316a74bbedcbb0ab433d4e9a55efade54f5b177/third_party/WebKit/Source/devtools/front_end/persistence/Automapping.js
[add] https://crrev.com/6316a74bbedcbb0ab433d4e9a55efade54f5b177/third_party/WebKit/Source/devtools/front_end/persistence/NetworkPersistenceManager.js
[modify] https://crrev.com/6316a74bbedcbb0ab433d4e9a55efade54f5b177/third_party/WebKit/Source/devtools/front_end/persistence/PersistenceUtils.js
[modify] https://crrev.com/6316a74bbedcbb0ab433d4e9a55efade54f5b177/third_party/WebKit/Source/devtools/front_end/persistence/module.json
[modify] https://crrev.com/6316a74bbedcbb0ab433d4e9a55efade54f5b177/third_party/WebKit/Source/devtools/front_end/source_frame/UISourceCodeFrame.js
[modify] https://crrev.com/6316a74bbedcbb0ab433d4e9a55efade54f5b177/third_party/WebKit/Source/devtools/front_end/sources/NavigatorView.js

Project Member

Comment 9 by bugdroid1@chromium.org, Oct 19 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6f2068c4da67d94bea69bbfddb0d19ca94f3765a

commit 6f2068c4da67d94bea69bbfddb0d19ca94f3765a
Author: Nathan Bruer <allada@chromium.org>
Date: Thu Oct 19 08:23:06 2017

[Devtools] NetworkOverride experiment now safely encodes filenames

When using network persistence and save a file that is not safe to save
with the desired name on the filesystem, devtools will now encode parts
that are deemed 'unsafe' to save on filesystem.

Example: 'con' and 'nul' are not allowed on windows. '?' also not
allowed on windows.

R=lushnikov,pfeldman
BUG=760316

Change-Id: I29bd227fc3f7f5f10a6b80ed45d21b6a7a6d34a2
Reviewed-on: https://chromium-review.googlesource.com/727195
Commit-Queue: Blaise Bruer <allada@chromium.org>
Reviewed-by: Andrey Lushnikov <lushnikov@chromium.org>
Cr-Commit-Position: refs/heads/master@{#510031}
[add] https://crrev.com/6f2068c4da67d94bea69bbfddb0d19ca94f3765a/third_party/WebKit/LayoutTests/http/tests/devtools/network/network-persistence-filename-safety-expected.txt
[add] https://crrev.com/6f2068c4da67d94bea69bbfddb0d19ca94f3765a/third_party/WebKit/LayoutTests/http/tests/devtools/network/network-persistence-filename-safety.js
[modify] https://crrev.com/6f2068c4da67d94bea69bbfddb0d19ca94f3765a/third_party/WebKit/Source/devtools/front_end/persistence/NetworkPersistenceManager.js
[modify] https://crrev.com/6f2068c4da67d94bea69bbfddb0d19ca94f3765a/third_party/WebKit/Source/devtools/front_end/workspace/UISourceCode.js

Project Member

Comment 10 by bugdroid1@chromium.org, Oct 21 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5b3a36963ca23583933aebd1565af3ae8ccb9841

commit 5b3a36963ca23583933aebd1565af3ae8ccb9841
Author: Nathan Bruer <allada@chromium.org>
Date: Sat Oct 21 02:01:28 2017

[Devtools] Network Overrides new UI

Introduces new UI for network overrides / request interception. Upon navigating
to new pages projects auto start intercepting if the project is setup for that
domain. If you save a file that was served over the network it will create a file
in your configured directory and only load from the disk when the network request
is requested.

see:
https://user-images.githubusercontent.com/1831202/31845308-522b1dee-b5b4-11e7-8a40-a2fda45a083c.png
https://user-images.githubusercontent.com/1831202/31845309-524068f2-b5b4-11e7-807a-6f57f44f4ba8.png

Bug=760316

Change-Id: I64dba9502456761b192221c46fbd4b3eb0c18765
Reviewed-on: https://chromium-review.googlesource.com/729984
Commit-Queue: Blaise Bruer <allada@chromium.org>
Reviewed-by: Andrey Lushnikov <lushnikov@chromium.org>
Cr-Commit-Position: refs/heads/master@{#510641}
[modify] https://crrev.com/5b3a36963ca23583933aebd1565af3ae8ccb9841/third_party/WebKit/LayoutTests/http/tests/devtools/quick-open/command-menu-expected.txt
[modify] https://crrev.com/5b3a36963ca23583933aebd1565af3ae8ccb9841/third_party/WebKit/Source/devtools/front_end/network/NetworkConfigView.js
[modify] https://crrev.com/5b3a36963ca23583933aebd1565af3ae8ccb9841/third_party/WebKit/Source/devtools/front_end/network/networkConfigView.css
[modify] https://crrev.com/5b3a36963ca23583933aebd1565af3ae8ccb9841/third_party/WebKit/Source/devtools/front_end/persistence/Automapping.js
[modify] https://crrev.com/5b3a36963ca23583933aebd1565af3ae8ccb9841/third_party/WebKit/Source/devtools/front_end/persistence/DefaultMapping.js
[modify] https://crrev.com/5b3a36963ca23583933aebd1565af3ae8ccb9841/third_party/WebKit/Source/devtools/front_end/persistence/FileSystemWorkspaceBinding.js
[modify] https://crrev.com/5b3a36963ca23583933aebd1565af3ae8ccb9841/third_party/WebKit/Source/devtools/front_end/persistence/IsolatedFileSystemManager.js
[modify] https://crrev.com/5b3a36963ca23583933aebd1565af3ae8ccb9841/third_party/WebKit/Source/devtools/front_end/persistence/NetworkPersistenceManager.js
[modify] https://crrev.com/5b3a36963ca23583933aebd1565af3ae8ccb9841/third_party/WebKit/Source/devtools/front_end/persistence/Persistence.js
[modify] https://crrev.com/5b3a36963ca23583933aebd1565af3ae8ccb9841/third_party/WebKit/Source/devtools/front_end/persistence/PersistenceUtils.js
[modify] https://crrev.com/5b3a36963ca23583933aebd1565af3ae8ccb9841/third_party/WebKit/Source/devtools/front_end/persistence/module.json
[modify] https://crrev.com/5b3a36963ca23583933aebd1565af3ae8ccb9841/third_party/WebKit/Source/devtools/front_end/source_frame/UISourceCodeFrame.js
[modify] https://crrev.com/5b3a36963ca23583933aebd1565af3ae8ccb9841/third_party/WebKit/Source/devtools/front_end/sources/NavigatorView.js
[modify] https://crrev.com/5b3a36963ca23583933aebd1565af3ae8ccb9841/third_party/WebKit/Source/devtools/front_end/sources/SourcesNavigator.js
[modify] https://crrev.com/5b3a36963ca23583933aebd1565af3ae8ccb9841/third_party/WebKit/Source/devtools/front_end/sources/module.json
[modify] https://crrev.com/5b3a36963ca23583933aebd1565af3ae8ccb9841/third_party/WebKit/Source/devtools/front_end/sources/navigatorView.css

Project Member

Comment 11 by bugdroid1@chromium.org, Oct 23 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f1a7c1b105ea6203f0d32222e64b6975a15a3116

commit f1a7c1b105ea6203f0d32222e64b6975a15a3116
Author: Pavel Feldman <pfeldman@chromium.org>
Date: Mon Oct 23 09:35:23 2017

DevTools: deprecate Save action in favor of the overrides, prepare code for 'Save for overrides' action.

Bug: 760316
Change-Id: Ic97f88896305246681dcb83c46cc06db3b14be8b
Reviewed-on: https://chromium-review.googlesource.com/732186
Commit-Queue: Pavel Feldman <pfeldman@chromium.org>
Reviewed-by: Andrey Lushnikov <lushnikov@chromium.org>
Cr-Commit-Position: refs/heads/master@{#510747}
[delete] https://crrev.com/b8e471180e6cedd7929e706f1087a1468143ecac/third_party/WebKit/LayoutTests/http/tests/devtools/uisourcecode-has-content-on-save-expected.txt
[delete] https://crrev.com/b8e471180e6cedd7929e706f1087a1468143ecac/third_party/WebKit/LayoutTests/http/tests/devtools/uisourcecode-has-content-on-save.js
[modify] https://crrev.com/f1a7c1b105ea6203f0d32222e64b6975a15a3116/third_party/WebKit/Source/devtools/BUILD.gn
[modify] https://crrev.com/f1a7c1b105ea6203f0d32222e64b6975a15a3116/third_party/WebKit/Source/devtools/front_end/bindings/ContentProviderBasedProject.js
[modify] https://crrev.com/f1a7c1b105ea6203f0d32222e64b6975a15a3116/third_party/WebKit/Source/devtools/front_end/components/Linkifier.js
[modify] https://crrev.com/f1a7c1b105ea6203f0d32222e64b6975a15a3116/third_party/WebKit/Source/devtools/front_end/persistence/FileSystemWorkspaceBinding.js
[modify] https://crrev.com/f1a7c1b105ea6203f0d32222e64b6975a15a3116/third_party/WebKit/Source/devtools/front_end/persistence/IsolatedFileSystem.js
[modify] https://crrev.com/f1a7c1b105ea6203f0d32222e64b6975a15a3116/third_party/WebKit/Source/devtools/front_end/persistence/NetworkPersistenceManager.js
[modify] https://crrev.com/f1a7c1b105ea6203f0d32222e64b6975a15a3116/third_party/WebKit/Source/devtools/front_end/persistence/Persistence.js
[add] https://crrev.com/f1a7c1b105ea6203f0d32222e64b6975a15a3116/third_party/WebKit/Source/devtools/front_end/persistence/PersistenceActions.js
[modify] https://crrev.com/f1a7c1b105ea6203f0d32222e64b6975a15a3116/third_party/WebKit/Source/devtools/front_end/persistence/module.json
[modify] https://crrev.com/f1a7c1b105ea6203f0d32222e64b6975a15a3116/third_party/WebKit/Source/devtools/front_end/snippets/ScriptSnippetModel.js
[modify] https://crrev.com/f1a7c1b105ea6203f0d32222e64b6975a15a3116/third_party/WebKit/Source/devtools/front_end/sources/SourcesNavigator.js
[modify] https://crrev.com/f1a7c1b105ea6203f0d32222e64b6975a15a3116/third_party/WebKit/Source/devtools/front_end/sources/SourcesPanel.js
[modify] https://crrev.com/f1a7c1b105ea6203f0d32222e64b6975a15a3116/third_party/WebKit/Source/devtools/front_end/workspace/FileManager.js
[modify] https://crrev.com/f1a7c1b105ea6203f0d32222e64b6975a15a3116/third_party/WebKit/Source/devtools/front_end/workspace/UISourceCode.js
[modify] https://crrev.com/f1a7c1b105ea6203f0d32222e64b6975a15a3116/third_party/WebKit/Source/devtools/front_end/workspace/Workspace.js

Project Member

Comment 12 by bugdroid1@chromium.org, Oct 23 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9632e816dc04d623052aa11c6dcf4b4e6e5c8646

commit 9632e816dc04d623052aa11c6dcf4b4e6e5c8646
Author: Pavel Feldman <pfeldman@chromium.org>
Date: Mon Oct 23 16:23:34 2017

DevTools: bring ContentProvider::contentEncoded() back in a non-breaking manner, migrate some of the call sites.

Bug: 760316
Change-Id: I017332725388d7f65ff8ab2e9072aab0c46a0b32
Reviewed-on: https://chromium-review.googlesource.com/732524
Commit-Queue: Pavel Feldman <pfeldman@chromium.org>
Reviewed-by: Blaise Bruer <allada@chromium.org>
Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#510814}
[modify] https://crrev.com/9632e816dc04d623052aa11c6dcf4b4e6e5c8646/third_party/WebKit/LayoutTests/http/tests/devtools/resource-tree/resource-tree-invalid-mime-type-css-content.html
[modify] https://crrev.com/9632e816dc04d623052aa11c6dcf4b4e6e5c8646/third_party/WebKit/Source/devtools/front_end/bindings/ContentProviderBasedProject.js
[modify] https://crrev.com/9632e816dc04d623052aa11c6dcf4b4e6e5c8646/third_party/WebKit/Source/devtools/front_end/bindings/ResourceMapping.js
[modify] https://crrev.com/9632e816dc04d623052aa11c6dcf4b4e6e5c8646/third_party/WebKit/Source/devtools/front_end/bindings/StylesSourceMapping.js
[modify] https://crrev.com/9632e816dc04d623052aa11c6dcf4b4e6e5c8646/third_party/WebKit/Source/devtools/front_end/common/ContentProvider.js
[modify] https://crrev.com/9632e816dc04d623052aa11c6dcf4b4e6e5c8646/third_party/WebKit/Source/devtools/front_end/common/StaticContentProvider.js
[modify] https://crrev.com/9632e816dc04d623052aa11c6dcf4b4e6e5c8646/third_party/WebKit/Source/devtools/front_end/extensions/ExtensionServer.js
[modify] https://crrev.com/9632e816dc04d623052aa11c6dcf4b4e6e5c8646/third_party/WebKit/Source/devtools/front_end/network/RequestResponseView.js
[modify] https://crrev.com/9632e816dc04d623052aa11c6dcf4b4e6e5c8646/third_party/WebKit/Source/devtools/front_end/persistence/FileSystemWorkspaceBinding.js
[modify] https://crrev.com/9632e816dc04d623052aa11c6dcf4b4e6e5c8646/third_party/WebKit/Source/devtools/front_end/persistence/IsolatedFileSystem.js
[modify] https://crrev.com/9632e816dc04d623052aa11c6dcf4b4e6e5c8646/third_party/WebKit/Source/devtools/front_end/persistence/NetworkPersistenceManager.js
[modify] https://crrev.com/9632e816dc04d623052aa11c6dcf4b4e6e5c8646/third_party/WebKit/Source/devtools/front_end/sdk/CSSStyleSheetHeader.js
[modify] https://crrev.com/9632e816dc04d623052aa11c6dcf4b4e6e5c8646/third_party/WebKit/Source/devtools/front_end/sdk/ContentProviders.js
[modify] https://crrev.com/9632e816dc04d623052aa11c6dcf4b4e6e5c8646/third_party/WebKit/Source/devtools/front_end/sdk/NetworkRequest.js
[modify] https://crrev.com/9632e816dc04d623052aa11c6dcf4b4e6e5c8646/third_party/WebKit/Source/devtools/front_end/sdk/Resource.js
[modify] https://crrev.com/9632e816dc04d623052aa11c6dcf4b4e6e5c8646/third_party/WebKit/Source/devtools/front_end/sdk/Script.js
[modify] https://crrev.com/9632e816dc04d623052aa11c6dcf4b4e6e5c8646/third_party/WebKit/Source/devtools/front_end/snippets/ScriptSnippetModel.js
[modify] https://crrev.com/9632e816dc04d623052aa11c6dcf4b4e6e5c8646/third_party/WebKit/Source/devtools/front_end/workspace/UISourceCode.js
[modify] https://crrev.com/9632e816dc04d623052aa11c6dcf4b4e6e5c8646/third_party/WebKit/Source/devtools/front_end/workspace/Workspace.js

Cc: allada@chromium.org einbinder@chromium.org
 Issue 754371  has been merged into this issue.
Project Member

Comment 14 by bugdroid1@chromium.org, Nov 10 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/76e8a50d855d02323a509da2545e47400d78b3e9

commit 76e8a50d855d02323a509da2545e47400d78b3e9
Author: Nathan Bruer <allada@chromium.org>
Date: Fri Nov 10 23:14:00 2017

[Devtools] Disable cache when request interception is on

This patch disables cache when request interception is enabled.

R=caseq
BUG=760316

Change-Id: I15e05766bee3a4c666150fbf15b5da2604a98a0d
Reviewed-on: https://chromium-review.googlesource.com/764516
Reviewed-by: Andrey Kosyakov <caseq@chromium.org>
Commit-Queue: Blaise Bruer <allada@chromium.org>
Cr-Commit-Position: refs/heads/master@{#515731}
[add] https://crrev.com/76e8a50d855d02323a509da2545e47400d78b3e9/third_party/WebKit/LayoutTests/http/tests/devtools/network/disable-cache-on-interception-expected.txt
[add] https://crrev.com/76e8a50d855d02323a509da2545e47400d78b3e9/third_party/WebKit/LayoutTests/http/tests/devtools/network/disable-cache-on-interception.js
[modify] https://crrev.com/76e8a50d855d02323a509da2545e47400d78b3e9/third_party/WebKit/Source/devtools/front_end/sdk/NetworkManager.js

Project Member

Comment 15 by bugdroid1@chromium.org, Nov 15 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/825da8d1b1ced4498241a62a5e3d608641ba4772

commit 825da8d1b1ced4498241a62a5e3d608641ba4772
Author: Nathan Bruer <allada@chromium.org>
Date: Wed Nov 15 03:13:10 2017

[Devtools] Saving files for overrides now removes ref hashes properly

Removes ref's from the url properly when saving files for overrides.

R=lushnikov
BUG=760316

Change-Id: I799f9d8f26c1b92fa74cba7fa5282fc705b67c34
Reviewed-on: https://chromium-review.googlesource.com/764950
Commit-Queue: Blaise Bruer <allada@chromium.org>
Reviewed-by: Andrey Lushnikov <lushnikov@chromium.org>
Cr-Commit-Position: refs/heads/master@{#516579}
[modify] https://crrev.com/825da8d1b1ced4498241a62a5e3d608641ba4772/third_party/WebKit/LayoutTests/http/tests/devtools/components/parsed-url-expected.txt
[modify] https://crrev.com/825da8d1b1ced4498241a62a5e3d608641ba4772/third_party/WebKit/LayoutTests/http/tests/devtools/components/parsed-url.js
[add] https://crrev.com/825da8d1b1ced4498241a62a5e3d608641ba4772/third_party/WebKit/LayoutTests/http/tests/devtools/overrides/files-save-without-hash-expected.txt
[add] https://crrev.com/825da8d1b1ced4498241a62a5e3d608641ba4772/third_party/WebKit/LayoutTests/http/tests/devtools/overrides/files-save-without-hash.js
[modify] https://crrev.com/825da8d1b1ced4498241a62a5e3d608641ba4772/third_party/WebKit/Source/devtools/front_end/bindings_test_runner/IsolatedFilesystemTestRunner.js
[modify] https://crrev.com/825da8d1b1ced4498241a62a5e3d608641ba4772/third_party/WebKit/Source/devtools/front_end/common/ParsedURL.js
[modify] https://crrev.com/825da8d1b1ced4498241a62a5e3d608641ba4772/third_party/WebKit/Source/devtools/front_end/persistence/NetworkPersistenceManager.js

Project Member

Comment 16 by bugdroid1@chromium.org, Nov 22 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6f159e98a120272fef17688e068a2104fb0cbade

commit 6f159e98a120272fef17688e068a2104fb0cbade
Author: Nathan Bruer <allada@chromium.org>
Date: Wed Nov 22 02:55:59 2017

[Devtools] Added 'Overrides' setting to settings screen

Adds ability to manage the overrides in devtools in the settings screen.

See: https://imgur.com/a/Sp6gI

R=dgozman,lushnikov,pfeldman
BUG=760316

Change-Id: I2b53e2df880cb21d3b4f63e63fcca7f6cdd75bc4
Reviewed-on: https://chromium-review.googlesource.com/780366
Reviewed-by: Pavel Feldman <pfeldman@chromium.org>
Commit-Queue: Blaise Bruer <allada@chromium.org>
Cr-Commit-Position: refs/heads/master@{#518512}
[modify] https://crrev.com/6f159e98a120272fef17688e068a2104fb0cbade/third_party/WebKit/Source/devtools/BUILD.gn
[modify] https://crrev.com/6f159e98a120272fef17688e068a2104fb0cbade/third_party/WebKit/Source/devtools/front_end/persistence/NetworkPersistenceManager.js
[add] https://crrev.com/6f159e98a120272fef17688e068a2104fb0cbade/third_party/WebKit/Source/devtools/front_end/persistence/OverridesSettingsTab.js
[modify] https://crrev.com/6f159e98a120272fef17688e068a2104fb0cbade/third_party/WebKit/Source/devtools/front_end/persistence/WorkspaceSettingsTab.js
[modify] https://crrev.com/6f159e98a120272fef17688e068a2104fb0cbade/third_party/WebKit/Source/devtools/front_end/persistence/module.json
[add] https://crrev.com/6f159e98a120272fef17688e068a2104fb0cbade/third_party/WebKit/Source/devtools/front_end/persistence/overridesSettingsTab.css
[modify] https://crrev.com/6f159e98a120272fef17688e068a2104fb0cbade/third_party/WebKit/Source/devtools/front_end/settings/module.json

Owner: einbinder@chromium.org
Project Member

Comment 19 by bugdroid1@chromium.org, Dec 12 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/92f494ea2f1692a2cb8bd7217a5aaa170240edbd

commit 92f494ea2f1692a2cb8bd7217a5aaa170240edbd
Author: Joel Einbinder <einbinder@chromium.org>
Date: Tue Dec 12 01:45:25 2017

DevTools: Don't throw an error when filesystems are re-added

This removes and re-adds a filesystem if it was already added instead
of throwing an error. It makes it easier to work with overrides if
you are coming from an old version of overrides or add the folder to
the wrong type of persistence.

Bug: 760316
Change-Id: I8578fef29eba2529ded714cf8bf8582d616c439d
Reviewed-on: https://chromium-review.googlesource.com/820569
Reviewed-by: Pavel Feldman <pfeldman@chromium.org>
Commit-Queue: Joel Einbinder <einbinder@chromium.org>
Cr-Commit-Position: refs/heads/master@{#523296}
[modify] https://crrev.com/92f494ea2f1692a2cb8bd7217a5aaa170240edbd/chrome/browser/devtools/devtools_file_helper.cc

Project Member

Comment 20 by bugdroid1@chromium.org, Dec 14 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d4df2427968500b476bb6c6e77c0d25b5a55dcb4

commit d4df2427968500b476bb6c6e77c0d25b5a55dcb4
Author: Joel Einbinder <einbinder@chromium.org>
Date: Thu Dec 14 21:02:43 2017

DevTools: Use a single overrides project for every domain

This patch removes the overrides panel from the settings.

Bug: 760316
Change-Id: I443a3afd81c1b9414d47106e15c95c7ab9f4a99f
Reviewed-on: https://chromium-review.googlesource.com/826144
Commit-Queue: Joel Einbinder <einbinder@chromium.org>
Reviewed-by: Pavel Feldman <pfeldman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#524171}
[modify] https://crrev.com/d4df2427968500b476bb6c6e77c0d25b5a55dcb4/third_party/WebKit/LayoutTests/http/tests/devtools/network/network-persistence-filename-safety.js
[modify] https://crrev.com/d4df2427968500b476bb6c6e77c0d25b5a55dcb4/third_party/WebKit/LayoutTests/http/tests/devtools/overrides/can-edit-iframe-html.js
[modify] https://crrev.com/d4df2427968500b476bb6c6e77c0d25b5a55dcb4/third_party/WebKit/LayoutTests/http/tests/devtools/overrides/files-save-without-hash.js
[modify] https://crrev.com/d4df2427968500b476bb6c6e77c0d25b5a55dcb4/third_party/WebKit/LayoutTests/http/tests/devtools/overrides/project-added-with-existing-files-bind.js
[modify] https://crrev.com/d4df2427968500b476bb6c6e77c0d25b5a55dcb4/third_party/WebKit/Source/devtools/BUILD.gn
[modify] https://crrev.com/d4df2427968500b476bb6c6e77c0d25b5a55dcb4/third_party/WebKit/Source/devtools/front_end/bindings_test_runner/IsolatedFilesystemTestRunner.js
[modify] https://crrev.com/d4df2427968500b476bb6c6e77c0d25b5a55dcb4/third_party/WebKit/Source/devtools/front_end/bindings_test_runner/OverridesTestRunner.js
[modify] https://crrev.com/d4df2427968500b476bb6c6e77c0d25b5a55dcb4/third_party/WebKit/Source/devtools/front_end/persistence/NetworkPersistenceManager.js
[delete] https://crrev.com/07b2da7e739f822b90789b91beadd9c15ed94a9d/third_party/WebKit/Source/devtools/front_end/persistence/OverridesSettingsTab.js
[modify] https://crrev.com/d4df2427968500b476bb6c6e77c0d25b5a55dcb4/third_party/WebKit/Source/devtools/front_end/persistence/PersistenceUtils.js
[modify] https://crrev.com/d4df2427968500b476bb6c6e77c0d25b5a55dcb4/third_party/WebKit/Source/devtools/front_end/persistence/WorkspaceSettingsTab.js
[modify] https://crrev.com/d4df2427968500b476bb6c6e77c0d25b5a55dcb4/third_party/WebKit/Source/devtools/front_end/persistence/module.json
[delete] https://crrev.com/07b2da7e739f822b90789b91beadd9c15ed94a9d/third_party/WebKit/Source/devtools/front_end/persistence/overridesSettingsTab.css
[modify] https://crrev.com/d4df2427968500b476bb6c6e77c0d25b5a55dcb4/third_party/WebKit/Source/devtools/front_end/sources/NavigatorView.js
[modify] https://crrev.com/d4df2427968500b476bb6c6e77c0d25b5a55dcb4/third_party/WebKit/Source/devtools/front_end/sources/SourcesNavigator.js
[modify] https://crrev.com/d4df2427968500b476bb6c6e77c0d25b5a55dcb4/third_party/WebKit/Source/devtools/front_end/sources/UISourceCodeFrame.js
[modify] https://crrev.com/d4df2427968500b476bb6c6e77c0d25b5a55dcb4/third_party/WebKit/Source/devtools/front_end/sources/navigatorView.css

Project Member

Comment 21 by bugdroid1@chromium.org, Jan 3 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5b8e536aa4797fc395f07b1f02551fb4f0440dee

commit 5b8e536aa4797fc395f07b1f02551fb4f0440dee
Author: Joel Einbinder <einbinder@chromium.org>
Date: Wed Jan 03 01:59:27 2018

DevTools: Overrides: Rebind to the latest network UISourceCode

Bug: 760316
Change-Id: I2e1a5b06e1b3b5e2e1e3151ca2299172b789ffa5
Reviewed-on: https://chromium-review.googlesource.com/827941
Reviewed-by: Pavel Feldman <pfeldman@chromium.org>
Commit-Queue: Joel Einbinder <einbinder@chromium.org>
Cr-Commit-Position: refs/heads/master@{#526582}
[modify] https://crrev.com/5b8e536aa4797fc395f07b1f02551fb4f0440dee/third_party/WebKit/Source/devtools/front_end/persistence/NetworkPersistenceManager.js

Project Member

Comment 22 by bugdroid1@chromium.org, Jan 3 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9fb113f6d5363a58168c5ad5c07a7a0dadf921fe

commit 9fb113f6d5363a58168c5ad5c07a7a0dadf921fe
Author: Joel Einbinder <einbinder@chromium.org>
Date: Wed Jan 03 21:19:36 2018

DevTools: Overrides: Properly unbind removed network UISourceCodes

Bug: 760316
Change-Id: I6ff545945a5475efd621741d973eaf451e776011
Reviewed-on: https://chromium-review.googlesource.com/831047
Reviewed-by: Pavel Feldman <pfeldman@chromium.org>
Commit-Queue: Joel Einbinder <einbinder@chromium.org>
Cr-Commit-Position: refs/heads/master@{#526818}
[modify] https://crrev.com/9fb113f6d5363a58168c5ad5c07a7a0dadf921fe/third_party/WebKit/Source/devtools/front_end/persistence/NetworkPersistenceManager.js

Project Member

Comment 23 by bugdroid1@chromium.org, Jan 8 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c67f7305100b6a95af160378d5cec051c4fdff79

commit c67f7305100b6a95af160378d5cec051c4fdff79
Author: Joel Einbinder <einbinder@chromium.org>
Date: Mon Jan 08 20:20:32 2018

DevTools: Make overrides setting sticky

Bug: 760316
Change-Id: Idbb1612fd5da5f58a5ced54467b35ce52fe6c378
Reviewed-on: https://chromium-review.googlesource.com/846355
Reviewed-by: Pavel Feldman <pfeldman@chromium.org>
Commit-Queue: Joel Einbinder <einbinder@chromium.org>
Cr-Commit-Position: refs/heads/master@{#527733}
[modify] https://crrev.com/c67f7305100b6a95af160378d5cec051c4fdff79/third_party/WebKit/Source/devtools/front_end/persistence/module.json

Project Member

Comment 24 by bugdroid1@chromium.org, Jan 9 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/615b5e83e50d4e23256b0306e0734b6b9e6d5db5

commit 615b5e83e50d4e23256b0306e0734b6b9e6d5db5
Author: Joel Einbinder <einbinder@chromium.org>
Date: Tue Jan 09 19:20:35 2018

DevTools: Don't add override filesystem uiSourceCodes to tab history

Bug: 760316
Change-Id: I66b27aeced913ed178b8e6d24423184ad8dcf7ae
Reviewed-on: https://chromium-review.googlesource.com/846251
Reviewed-by: Pavel Feldman <pfeldman@chromium.org>
Commit-Queue: Joel Einbinder <einbinder@chromium.org>
Cr-Commit-Position: refs/heads/master@{#528064}
[modify] https://crrev.com/615b5e83e50d4e23256b0306e0734b6b9e6d5db5/third_party/WebKit/Source/devtools/front_end/sources/SourcesView.js

Project Member

Comment 25 by bugdroid1@chromium.org, Jan 10 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/488905fdd5e26484c89d66079ad288d48dfdbad3

commit 488905fdd5e26484c89d66079ad288d48dfdbad3
Author: Joel Einbinder <einbinder@chromium.org>
Date: Wed Jan 10 00:08:44 2018

[Devtools] Add ability for devtools to open folder on OS

Adds 'Reveal in finder' like utilities in devtools and adds context menu
link to all persistence actionable items and navigator context menu.

R=dgozman,lushnikov,pfeldman
BUG=760316

Change-Id: I657a5b6448abc0a8d5c23bcbbbabcf16beafa74e
Reviewed-on: https://chromium-review.googlesource.com/767650
Reviewed-by: Pavel Feldman <pfeldman@chromium.org>
Reviewed-by: Tom Sepez <tsepez@chromium.org>
Commit-Queue: Joel Einbinder <einbinder@chromium.org>
Cr-Commit-Position: refs/heads/master@{#528180}
[modify] https://crrev.com/488905fdd5e26484c89d66079ad288d48dfdbad3/chrome/browser/devtools/devtools_embedder_message_dispatcher.cc
[modify] https://crrev.com/488905fdd5e26484c89d66079ad288d48dfdbad3/chrome/browser/devtools/devtools_embedder_message_dispatcher.h
[modify] https://crrev.com/488905fdd5e26484c89d66079ad288d48dfdbad3/chrome/browser/devtools/devtools_file_helper.cc
[modify] https://crrev.com/488905fdd5e26484c89d66079ad288d48dfdbad3/chrome/browser/devtools/devtools_file_helper.h
[modify] https://crrev.com/488905fdd5e26484c89d66079ad288d48dfdbad3/chrome/browser/devtools/devtools_ui_bindings.cc
[modify] https://crrev.com/488905fdd5e26484c89d66079ad288d48dfdbad3/chrome/browser/devtools/devtools_ui_bindings.h
[modify] https://crrev.com/488905fdd5e26484c89d66079ad288d48dfdbad3/third_party/WebKit/Source/devtools/front_end/common/ParsedURL.js
[modify] https://crrev.com/488905fdd5e26484c89d66079ad288d48dfdbad3/third_party/WebKit/Source/devtools/front_end/devtools_compatibility.js
[modify] https://crrev.com/488905fdd5e26484c89d66079ad288d48dfdbad3/third_party/WebKit/Source/devtools/front_end/host/InspectorFrontendHost.js
[modify] https://crrev.com/488905fdd5e26484c89d66079ad288d48dfdbad3/third_party/WebKit/Source/devtools/front_end/host/InspectorFrontendHostAPI.js
[modify] https://crrev.com/488905fdd5e26484c89d66079ad288d48dfdbad3/third_party/WebKit/Source/devtools/front_end/persistence/PersistenceActions.js
[modify] https://crrev.com/488905fdd5e26484c89d66079ad288d48dfdbad3/third_party/WebKit/Source/devtools/front_end/sources/NavigatorView.js

Project Member

Comment 26 by bugdroid1@chromium.org, Jan 10 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ed683e36356007a48e51235b65edf78cf26a4e91

commit ed683e36356007a48e51235b65edf78cf26a4e91
Author: Joel Einbinder <einbinder@chromium.org>
Date: Wed Jan 10 22:48:02 2018

DevTools: Fix 'Open in containing folder' on Windows

File urls begin with an extra slash which is an invalid path on Windows

BUG=760316

Change-Id: I1685671fdba0c235a6fbf5157dfa7595cb077040
Reviewed-on: https://chromium-review.googlesource.com/860879
Reviewed-by: Pavel Feldman <pfeldman@chromium.org>
Commit-Queue: Joel Einbinder <einbinder@chromium.org>
Cr-Commit-Position: refs/heads/master@{#528453}
[modify] https://crrev.com/ed683e36356007a48e51235b65edf78cf26a4e91/third_party/WebKit/Source/devtools/front_end/common/ParsedURL.js

Project Member

Comment 27 by bugdroid1@chromium.org, Jan 13 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/89269516ae409745c1182c23fe3de8ce17118da5

commit 89269516ae409745c1182c23fe3de8ce17118da5
Author: Joel Einbinder <einbinder@chromium.org>
Date: Sat Jan 13 02:10:24 2018

DevTools: Bring Overrides out of experiment

Bug: 760316
Change-Id: I101c3e375c1a85c8ed5139a357b0068e7f7eb122
Reviewed-on: https://chromium-review.googlesource.com/861252
Reviewed-by: Pavel Feldman <pfeldman@chromium.org>
Commit-Queue: Joel Einbinder <einbinder@chromium.org>
Cr-Commit-Position: refs/heads/master@{#529147}
[modify] https://crrev.com/89269516ae409745c1182c23fe3de8ce17118da5/third_party/WebKit/Source/devtools/front_end/main/Main.js
[modify] https://crrev.com/89269516ae409745c1182c23fe3de8ce17118da5/third_party/WebKit/Source/devtools/front_end/sources/module.json

Project Member

Comment 28 by bugdroid1@chromium.org, Jan 17 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7c2202d209e01cbcd951fa7cdb5c2f8b04f2b9f6

commit 7c2202d209e01cbcd951fa7cdb5c2f8b04f2b9f6
Author: Joel Einbinder <einbinder@chromium.org>
Date: Wed Jan 17 05:44:24 2018

DevTools: treat network content as truth when saving for overrides

This prevents a race where rapidly changing a uiSourceCode recently saved for
overrides would lose commits immediately after saving.

Bug: 760316

Change-Id: I4249ca6e6cfa1f6a4ecb32cc7ac61371a08b99df
Reviewed-on: https://chromium-review.googlesource.com/869372
Commit-Queue: Joel Einbinder <einbinder@chromium.org>
Reviewed-by: Andrey Lushnikov <lushnikov@chromium.org>
Cr-Commit-Position: refs/heads/master@{#529636}
[modify] https://crrev.com/7c2202d209e01cbcd951fa7cdb5c2f8b04f2b9f6/third_party/WebKit/Source/devtools/front_end/persistence/NetworkPersistenceManager.js

Project Member

Comment 29 by bugdroid1@chromium.org, Jan 17 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9dd74e24ba1f2fc38bbe45dbf51d806c7c791851

commit 9dd74e24ba1f2fc38bbe45dbf51d806c7c791851
Author: Joel Einbinder <einbinder@chromium.org>
Date: Wed Jan 17 22:39:17 2018

DevTools: Update Overrides Sidebar UI

This renames 'Setup Overrides' into 'Select folder for overrides' and
adds a 'Clear configuration' button.

Bug: 760316
Change-Id: I6fea47570d98b077bf0ece4cda36fe097cdd8d72
Reviewed-on: https://chromium-review.googlesource.com/861331
Reviewed-by: Paul Irish <paulirish@chromium.org>
Reviewed-by: Pavel Feldman <pfeldman@chromium.org>
Commit-Queue: Joel Einbinder <einbinder@chromium.org>
Cr-Commit-Position: refs/heads/master@{#529931}
[modify] https://crrev.com/9dd74e24ba1f2fc38bbe45dbf51d806c7c791851/third_party/WebKit/Source/devtools/front_end/sources/SourcesNavigator.js

Sign in to add a comment